From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E67BC433FE for ; Mon, 11 Oct 2021 10:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6E1B60E74 for ; Mon, 11 Oct 2021 10:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235792AbhJKKaL (ORCPT ); Mon, 11 Oct 2021 06:30:11 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3957 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235446AbhJKKaK (ORCPT ); Mon, 11 Oct 2021 06:30:10 -0400 Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HSZgK64P2z687Dq; Mon, 11 Oct 2021 18:25:17 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 12:28:09 +0200 Received: from localhost (10.52.122.204) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 11:28:08 +0100 Date: Mon, 11 Oct 2021 11:27:50 +0100 From: Jonathan Cameron To: Mark Brown CC: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan , "Alan Hayward" , Luis Machado , "Salil Akerkar" , Basant Kumar Dwivedi , Szabolcs Nagy , , Subject: Re: [PATCH v1 10/38] arm64/sve: Generalise vector length configuration prctl() for SME Message-ID: <20211011112750.00004066@Huawei.com> In-Reply-To: <20210930181144.10029-11-broonie@kernel.org> References: <20210930181144.10029-1-broonie@kernel.org> <20210930181144.10029-11-broonie@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.122.204] X-ClientProxiedBy: lhreml723-chm.china.huawei.com (10.201.108.74) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, 30 Sep 2021 19:11:16 +0100 Mark Brown wrote: > In preparation for adding SME support update the bulk of the implementation > for the vector length configuration prctl() calls to be independent of > vector type. > > Signed-off-by: Mark Brown And let the trivial continue (which is just a reflection of the fact I don't have enough of a grasp on this to find anything substantial - or there is nothing there to find :) ... > /* > - * Clamp to the maximum vector length that VL-agnostic SVE code can > - * work with. A flag may be assigned in the future to allow setting > - * of larger vector lengths without confusing older software. > + * Clamp to the maximum vector length that VL-agnostic code > + * can work with. A flag may be assigned in the future to > + * allow setting of larger vector lengths without confusing > + * older software. Why the oddly short wrapping at sub 70 chars? > */ > - if (vl > SVE_VL_ARCH_MAX) > - vl = SVE_VL_ARCH_MAX; > + if (vl > VL_ARCH_MAX) > + vl = VL_ARCH_MAX; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF843C433F5 for ; Mon, 11 Oct 2021 10:30:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF0A060E05 for ; Mon, 11 Oct 2021 10:30:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF0A060E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AK4qVixsq3jM/zsaCqxYUOTzhx6UJTGZJ2nb0jusQXA=; b=ik0BBkLwh6XF8i UKnRU+4ja3L98I6sIEg4i2DwaZBTaex9cqunnE7bt4rsvKpfO4Mf9DnJma605uiZ6Vu98E9sJw8WW PQXzMuZ71tZ+ZSMmACTOWm1h2u5HVNdo0EtL/liMXgFgtHnISM6tU86ZanMQRRKFCVL7rW/H6W3CT ZT6j8Fdx3nfvkIoazYfRpaMz5GGItU9sC+9FsVNDrmwre8Y6xNqKW/xicuupTmDkt4bNuta7MPugV mJGfW5p5e8C+4BDP3kqxBNUJyP4ulYyBNBw/cA/yJq6od4Vum7KBwczICy1atv4+wlui+AXS+2/Z7 u+cxP3PYI1195TaCMAKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZsXX-008qvO-Cu; Mon, 11 Oct 2021 10:28:15 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZsXT-008quC-Jh for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 10:28:13 +0000 Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HSZgK64P2z687Dq; Mon, 11 Oct 2021 18:25:17 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 12:28:09 +0200 Received: from localhost (10.52.122.204) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 11:28:08 +0100 Date: Mon, 11 Oct 2021 11:27:50 +0100 From: Jonathan Cameron To: Mark Brown CC: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan , "Alan Hayward" , Luis Machado , "Salil Akerkar" , Basant Kumar Dwivedi , Szabolcs Nagy , , Subject: Re: [PATCH v1 10/38] arm64/sve: Generalise vector length configuration prctl() for SME Message-ID: <20211011112750.00004066@Huawei.com> In-Reply-To: <20210930181144.10029-11-broonie@kernel.org> References: <20210930181144.10029-1-broonie@kernel.org> <20210930181144.10029-11-broonie@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.122.204] X-ClientProxiedBy: lhreml723-chm.china.huawei.com (10.201.108.74) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_032811_843432_5F5887E3 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 30 Sep 2021 19:11:16 +0100 Mark Brown wrote: > In preparation for adding SME support update the bulk of the implementation > for the vector length configuration prctl() calls to be independent of > vector type. > > Signed-off-by: Mark Brown And let the trivial continue (which is just a reflection of the fact I don't have enough of a grasp on this to find anything substantial - or there is nothing there to find :) ... > /* > - * Clamp to the maximum vector length that VL-agnostic SVE code can > - * work with. A flag may be assigned in the future to allow setting > - * of larger vector lengths without confusing older software. > + * Clamp to the maximum vector length that VL-agnostic code > + * can work with. A flag may be assigned in the future to > + * allow setting of larger vector lengths without confusing > + * older software. Why the oddly short wrapping at sub 70 chars? > */ > - if (vl > SVE_VL_ARCH_MAX) > - vl = SVE_VL_ARCH_MAX; > + if (vl > VL_ARCH_MAX) > + vl = VL_ARCH_MAX; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel