From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD830C433EF for ; Mon, 11 Oct 2021 13:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A537E60F35 for ; Mon, 11 Oct 2021 13:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235283AbhJKNUW (ORCPT ); Mon, 11 Oct 2021 09:20:22 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3963 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231392AbhJKNUW (ORCPT ); Mon, 11 Oct 2021 09:20:22 -0400 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HSfRh3S3Lz67YMc; Mon, 11 Oct 2021 21:15:28 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 15:18:20 +0200 Received: from localhost (10.52.122.204) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 14:18:19 +0100 Date: Mon, 11 Oct 2021 14:18:01 +0100 From: Jonathan Cameron To: Mark Brown CC: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan , "Alan Hayward" , Luis Machado , "Salil Akerkar" , Basant Kumar Dwivedi , Szabolcs Nagy , , Subject: Re: [PATCH v1 08/38] arm64/sve: Track vector lengths for tasks in an array Message-ID: <20211011141801.0000224a@Huawei.com> In-Reply-To: References: <20210930181144.10029-1-broonie@kernel.org> <20210930181144.10029-9-broonie@kernel.org> <20211011112057.00007b90@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.122.204] X-ClientProxiedBy: lhreml723-chm.china.huawei.com (10.201.108.74) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, 11 Oct 2021 14:14:16 +0100 Mark Brown wrote: > On Mon, Oct 11, 2021 at 11:20:57AM +0100, Jonathan Cameron wrote: > > Mark Brown wrote: > > > > As for SVE we will track a per task SME vector length for tasks. Convert > > > the existing storage for the vector length into an array and update > > > fpsimd_flush_task() to initialise this in a function. > > > I'm clearly having a trivial comment day. Given reduction in indenting > > it would be nice perhaps to reformat comments to take that into account. > > Again I'll have done this to make it clearer that things are just being > moved about - as a reviewer I do find things like that very helpful. > > > I'm also unconvinced the trivial wrappers are worthwhile. (maybe you drop > > those later?) > > They do hide what we're doing from the rest of the series which makes > the whole thing a lot easier to work with, especially if we change what > data structures we use or there's some debate as to the names of the > constants. A bunch of them directly map onto existing trivial wrappers > too, there's been some stylistic preference for that. > > If people want to remove the wrappers I'd propose leaving them for now > then adding a patch afterwards which removes them, or at least waiting > until we've got very firm agreement from Catalin and Will on the data > structures and constants. > Makes sense. J From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06233C433F5 for ; Mon, 11 Oct 2021 13:20:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC05A60F35 for ; Mon, 11 Oct 2021 13:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BC05A60F35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I+C3+qnUlzFkB2/nL9iurtL9GrMN4zMYiDWeR7lGjbE=; b=1F7QaoLS5Dqlav qxngH1uCYXznqu6wH6epMG+Ykq77sAR8xzNH0cMFUvZbtdyRNwYBtddDurtiTFOTU9/9D2vdba8VL tMGlaWMwpXK2J813u/ui5HNIIQIz+bGS5dua5xtIniCmehlHr8scrzlMoEY0LeH4WY1W6hU/PMwlO yP6cUhCheAgzwLo77cLEXc88xeop7PxjuoS3ycRXfnQaJScrdOL96KETK3YV1JbXUo4XHakGLaFae 89nQN13VQLZY3NxKNkn4ZjhXm5AU92n9GMTP9fVBTgUzh9J2L+gG0oifE3uumCSAT7KkBRY3C0vty ZgTP6jK/9RIPQFOsNbUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZvCX-009Ttm-Ct; Mon, 11 Oct 2021 13:18:45 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZvCC-009ToH-2S for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 13:18:26 +0000 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HSfRh3S3Lz67YMc; Mon, 11 Oct 2021 21:15:28 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 15:18:20 +0200 Received: from localhost (10.52.122.204) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 11 Oct 2021 14:18:19 +0100 Date: Mon, 11 Oct 2021 14:18:01 +0100 From: Jonathan Cameron To: Mark Brown CC: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan , "Alan Hayward" , Luis Machado , "Salil Akerkar" , Basant Kumar Dwivedi , Szabolcs Nagy , , Subject: Re: [PATCH v1 08/38] arm64/sve: Track vector lengths for tasks in an array Message-ID: <20211011141801.0000224a@Huawei.com> In-Reply-To: References: <20210930181144.10029-1-broonie@kernel.org> <20210930181144.10029-9-broonie@kernel.org> <20211011112057.00007b90@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.122.204] X-ClientProxiedBy: lhreml723-chm.china.huawei.com (10.201.108.74) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_061824_306075_BF501903 X-CRM114-Status: GOOD ( 20.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 11 Oct 2021 14:14:16 +0100 Mark Brown wrote: > On Mon, Oct 11, 2021 at 11:20:57AM +0100, Jonathan Cameron wrote: > > Mark Brown wrote: > > > > As for SVE we will track a per task SME vector length for tasks. Convert > > > the existing storage for the vector length into an array and update > > > fpsimd_flush_task() to initialise this in a function. > > > I'm clearly having a trivial comment day. Given reduction in indenting > > it would be nice perhaps to reformat comments to take that into account. > > Again I'll have done this to make it clearer that things are just being > moved about - as a reviewer I do find things like that very helpful. > > > I'm also unconvinced the trivial wrappers are worthwhile. (maybe you drop > > those later?) > > They do hide what we're doing from the rest of the series which makes > the whole thing a lot easier to work with, especially if we change what > data structures we use or there's some debate as to the names of the > constants. A bunch of them directly map onto existing trivial wrappers > too, there's been some stylistic preference for that. > > If people want to remove the wrappers I'd propose leaving them for now > then adding a patch afterwards which removes them, or at least waiting > until we've got very firm agreement from Catalin and Will on the data > structures and constants. > Makes sense. J _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel