From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
stable-rt@vger.kernel.org, Chunyu Hu <chuhu@redhat.com>
Subject: Re: [RFC RT v5.10] [rt] repair usage of raw_v6_hashinfo.lock in raw_seq_start()
Date: Mon, 11 Oct 2021 18:33:33 +0200 [thread overview]
Message-ID: <20211011163333.2o64amr4qks4gpdm@linutronix.de> (raw)
In-Reply-To: <YVuwBEWw4F7NGUd2@uudg.org>
On 2021-10-04 22:53:08 [-0300], Luis Claudio R. Goncalves wrote:
> Avoid a possible circular locking dependency by taking the softirq_ctrl.lock
> before taking raw_v6_hashinfo.lock in raw_seq_start(), keeping locking order
> consistent.
How do you reproduce this one? It does not trigger here. Maybe I'm doing
something wrong. The command
hping3 -C 3 -K 1 -c 1 $ip
triggers raw_icmp_error() from within the softirq processing. And
cat /proc/net/raw
does raw_seq_start(). No BH here. Additionally during boot raw_hash_sk()
is invoked from non-BH context here but it is a write-lock so it has to
disable BH since there is at least one reader in BH.
The ipv4 code looks close to the ipv6. The problem is that hping does
not support v6 :/ Maybe the ipv6 acquires a bh lock somewhere which
leads to this.
Sebastian
next prev parent reply other threads:[~2021-10-11 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 1:53 [RFC RT v5.10] [rt] repair usage of raw_v6_hashinfo.lock in raw_seq_start() Luis Claudio R. Goncalves
2021-10-11 16:33 ` Sebastian Andrzej Siewior [this message]
2021-10-18 15:51 ` Luis Goncalves
2021-10-27 9:06 ` Sebastian Andrzej Siewior
2021-11-04 18:48 ` Luis Goncalves
2021-11-05 17:18 ` Sebastian Andrzej Siewior
2021-11-05 17:31 ` Sebastian Andrzej Siewior
2021-11-04 18:55 ` Luis Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011163333.2o64amr4qks4gpdm@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=chuhu@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.