From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C646C433EF for ; Mon, 11 Oct 2021 18:05:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A5560F0F for ; Mon, 11 Oct 2021 18:05:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 42A5560F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71B936E914; Mon, 11 Oct 2021 18:05:37 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FC766E914; Mon, 11 Oct 2021 18:05:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="224348516" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="224348516" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 11:05:35 -0700 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="526090756" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 11:05:35 -0700 Date: Mon, 11 Oct 2021 11:00:50 -0700 From: Matthew Brost To: Thanneeru Srinivasulu Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, michal.wajdeczko@intel.com Subject: Re: [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send Message-ID: <20211011180050.GA29821@jons-linux-dev-box> References: <20211011152106.3424810-1-thanneeru.srinivasulu@intel.com> <20211011152106.3424810-5-thanneeru.srinivasulu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211011152106.3424810-5-thanneeru.srinivasulu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 11, 2021 at 08:51:06PM +0530, Thanneeru Srinivasulu wrote: > Inject probe errors -ENXIO, -EBUSY for CT send. > > Signed-off-by: Thanneeru Srinivasulu > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > index 83764db0fd6d..8ffef3abd3da 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > @@ -765,6 +765,14 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len, > u32 status = ~0; /* undefined */ > int ret; > > + ret = i915_inject_probe_error(ct_to_i915(ct), -ENXIO); > + if (ret) > + return ret; > + I don't see where -ENXIO is returned during an error that we handle unless I am missing something. If we don't return -ENXIO anywhere else I don't think we need to inject this error. Matt > + ret = i915_inject_probe_error(ct_to_i915(ct), -EBUSY); > + if (ret) > + return ret; > + > if (unlikely(!ct->enabled)) { > struct intel_guc *guc = ct_to_guc(ct); > struct intel_uc *uc = container_of(guc, struct intel_uc, guc); > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F78C433EF for ; Mon, 11 Oct 2021 18:05:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D7C60F0F for ; Mon, 11 Oct 2021 18:05:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6D7C60F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23C986E915; Mon, 11 Oct 2021 18:05:38 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FC766E914; Mon, 11 Oct 2021 18:05:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="224348516" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="224348516" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 11:05:35 -0700 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="526090756" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 11:05:35 -0700 Date: Mon, 11 Oct 2021 11:00:50 -0700 From: Matthew Brost To: Thanneeru Srinivasulu Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, michal.wajdeczko@intel.com Message-ID: <20211011180050.GA29821@jons-linux-dev-box> References: <20211011152106.3424810-1-thanneeru.srinivasulu@intel.com> <20211011152106.3424810-5-thanneeru.srinivasulu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211011152106.3424810-5-thanneeru.srinivasulu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 11, 2021 at 08:51:06PM +0530, Thanneeru Srinivasulu wrote: > Inject probe errors -ENXIO, -EBUSY for CT send. > > Signed-off-by: Thanneeru Srinivasulu > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > index 83764db0fd6d..8ffef3abd3da 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > @@ -765,6 +765,14 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len, > u32 status = ~0; /* undefined */ > int ret; > > + ret = i915_inject_probe_error(ct_to_i915(ct), -ENXIO); > + if (ret) > + return ret; > + I don't see where -ENXIO is returned during an error that we handle unless I am missing something. If we don't return -ENXIO anywhere else I don't think we need to inject this error. Matt > + ret = i915_inject_probe_error(ct_to_i915(ct), -EBUSY); > + if (ret) > + return ret; > + > if (unlikely(!ct->enabled)) { > struct intel_guc *guc = ct_to_guc(ct); > struct intel_uc *uc = container_of(guc, struct intel_uc, guc); > -- > 2.25.1 >