From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC28CC4332F for ; Tue, 12 Oct 2021 05:51:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ED4460E52 for ; Tue, 12 Oct 2021 05:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232802AbhJLFxs (ORCPT ); Tue, 12 Oct 2021 01:53:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232650AbhJLFxr (ORCPT ); Tue, 12 Oct 2021 01:53:47 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2DCC061570 for ; Mon, 11 Oct 2021 22:51:46 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id h125so6711051pfe.0 for ; Mon, 11 Oct 2021 22:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kBtpCZbIOWtvahLXRDKKDjKecXESKAiO4U+qtM3fqF4=; b=TnaMy710dXLuP2UJpvYYEci0HGuzrNFBasfSx2IKwcweLvhm7Ijn2ywSfxqmyqB+pP 1QN5V1L+gMujcMAp8UkixsGDdqUFYk/ECuh4XIEV25SpY7BcW2YSUxOtLgd5ZBTsf3uY hRmDbHVciUR81IbQvUPR9YFNx5LNWWAoQr41EirdPU2Us/c8VbuBU7Xof9R+ZOMlP/3l tjjZ1mW36NloFY/ns5OkKXzyfaWG0wXP4ClZ3Neg3bYRZBvsULE1WZbaZVDflXXhQvFc ZF/6VxzdRLWUhHgZxgkuDn634tLGA6Ek7AiEFNJ+w1Aemy0Y9wNI4aCjlhgow47qNwoN 9UgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kBtpCZbIOWtvahLXRDKKDjKecXESKAiO4U+qtM3fqF4=; b=B77QyPOUu+8wM2f2E3ePkwbR1ceh9tseCG10UbPk/pMXmpyiWzWko6m2vtGk50jpji rEDUPEzztqQ7fjZjcPA1piFUc3OLkgsERr3zNmzhkdJ8VjCxdY+dC5DbEPpff+vwMNVR rcpPa6rKitiIwLQoN8slfDjgaI/vuxZajZ65HXPxctGwJhKUUDOaFn7HoD4XgGxOupeX wdd7DoGsgxYSEStCvmWxCqZ74r9OzbmQIni7YqyNCScIVVq/XpHJZAnTptXqoADE/3Jw ZgEuqDD/+UeZAAYMLtfRydg8fO5GGF3wui1PkEflbVSs8nr3dqFBcmpi22XHk1t/FsEb 3IMw== X-Gm-Message-State: AOAM532hFZnmy/29ega8qSNWLOltZIyXrtw8UjkZovnkB53FFihXsi+G y7SjNyv4OGG7sOOoLE5rbdVcnw== X-Google-Smtp-Source: ABdhPJxmbvSSSRs/QD+1yS5ZcH1WaRkFLvr50doFVs/VKoJlbooNZMTu2jEh9QgF3xf5jI/HzOhtPQ== X-Received: by 2002:aa7:870b:0:b0:44b:bcef:32b4 with SMTP id b11-20020aa7870b000000b0044bbcef32b4mr29407229pfo.41.1634017905739; Mon, 11 Oct 2021 22:51:45 -0700 (PDT) Received: from localhost ([106.201.113.61]) by smtp.gmail.com with ESMTPSA id y142sm9477261pfc.169.2021.10.11.22.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 22:51:45 -0700 (PDT) Date: Tue, 12 Oct 2021 11:21:43 +0530 From: Viresh Kumar To: Hector Martin , Sibi Sankar , Saravana Kannan Cc: linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Message-ID: <20211012055143.xmkbvhbnolspgjin@vireshk-i7> References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-5-marcan@marcan.st> <20211012032144.2ltlpat7orrsyr6k@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-10-21, 14:34, Hector Martin wrote: > The table *is* assigned to a genpd (the memory controller), it's just that > that genpd isn't actually a parent of the CPU device. Without the patch you > end up with: > > [ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19) > [ 3.042881] cpu cpu4: Failed to set required opps: -19 > [ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19 Hmm, Saravana and Sibi were working on a similar problem earlier and decided to solve this using devfreq instead. Don't remember the exact series which got merged for this, Sibi ? If this part fails, how do you actually set the performance state of the memory controller's genpd ? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0041C433EF for ; Tue, 12 Oct 2021 05:54:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5767360EB6 for ; Tue, 12 Oct 2021 05:54:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5767360EB6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1eSJ/ZNDsaSUGDjBUazaUKoMyx8y6iWAW0uhiXZZ2+g=; b=3lQn1pRUynZpN8 YnrDjz1oKBdaE2GmOLhYx6Tmn37Jh7XKos3wgmJGtnibv5Ss4RFHgJSrVlvxwxmuvZLHmsX94hvVG x9cDT5B6GDnsCi0wxVEOb5gy1QL264cNeNNI2jAO5MTRlNMVb3mIu656Cbvvjnp6DF/9N5B3rrUO8 z0tUtMGzb6W04+jP64BORIZDpLtIg0iRDexVUu7LdWeWtWoiGUNeFXiwmKgbSdCdSO1HfQ3mhUXud jJp9f5xI072BA0/Kmqoua+a4H8ER1DjPNCiRO1hNO2F9ZCIbHpP0O+8cqndTPFGEibcrs4eiK4PrI e3Qau/+/Nq45Gsq45ZLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maAhb-00BeJk-0G; Tue, 12 Oct 2021 05:51:51 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maAhW-00BeJ8-RI for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 05:51:48 +0000 Received: by mail-pg1-x52f.google.com with SMTP id r2so12869229pgl.10 for ; Mon, 11 Oct 2021 22:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kBtpCZbIOWtvahLXRDKKDjKecXESKAiO4U+qtM3fqF4=; b=TnaMy710dXLuP2UJpvYYEci0HGuzrNFBasfSx2IKwcweLvhm7Ijn2ywSfxqmyqB+pP 1QN5V1L+gMujcMAp8UkixsGDdqUFYk/ECuh4XIEV25SpY7BcW2YSUxOtLgd5ZBTsf3uY hRmDbHVciUR81IbQvUPR9YFNx5LNWWAoQr41EirdPU2Us/c8VbuBU7Xof9R+ZOMlP/3l tjjZ1mW36NloFY/ns5OkKXzyfaWG0wXP4ClZ3Neg3bYRZBvsULE1WZbaZVDflXXhQvFc ZF/6VxzdRLWUhHgZxgkuDn634tLGA6Ek7AiEFNJ+w1Aemy0Y9wNI4aCjlhgow47qNwoN 9UgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kBtpCZbIOWtvahLXRDKKDjKecXESKAiO4U+qtM3fqF4=; b=TtJU9+sacVBODzGN4yMwshy8K/nutXtu4fee2YNP348vPlesPmN7ekN/uz1pcacmrJ T30XfyQRR5ad9gOZeUQsvZrEq1ObQYHzrWRQYe1sQAujlM+Vpakyd2rQiodhujJ21hmm T9BHEraTYn4vgmpn+t6iDbFggaGOn3D+9yc9pjbZ2x0G/uPl4RQ6QvSky4h+FxVmxHEc 4Mfb1G44djP24S6kGYK35XJetgjqXzpyZuxYtosUdwEDThHSMTTWCp7rtVCuhhHU7DU1 eFGHo3JOy4G+wO5GjrE5bFiUWEDOoMrzB83L1NOX5rSowlk6jgVnbl2tiASEYqcnWABh 7VOA== X-Gm-Message-State: AOAM532q/OvrptGHLVgMy73dbEUyRD60/TBoQZyU9Fcq4NxbpM2LLGDo OkXOpPiO23250nLE43x/Hex8UA== X-Google-Smtp-Source: ABdhPJxmbvSSSRs/QD+1yS5ZcH1WaRkFLvr50doFVs/VKoJlbooNZMTu2jEh9QgF3xf5jI/HzOhtPQ== X-Received: by 2002:aa7:870b:0:b0:44b:bcef:32b4 with SMTP id b11-20020aa7870b000000b0044bbcef32b4mr29407229pfo.41.1634017905739; Mon, 11 Oct 2021 22:51:45 -0700 (PDT) Received: from localhost ([106.201.113.61]) by smtp.gmail.com with ESMTPSA id y142sm9477261pfc.169.2021.10.11.22.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 22:51:45 -0700 (PDT) Date: Tue, 12 Oct 2021 11:21:43 +0530 From: Viresh Kumar To: Hector Martin , Sibi Sankar , Saravana Kannan Cc: linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Message-ID: <20211012055143.xmkbvhbnolspgjin@vireshk-i7> References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-5-marcan@marcan.st> <20211012032144.2ltlpat7orrsyr6k@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_225146_958139_C4DA9FAE X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12-10-21, 14:34, Hector Martin wrote: > The table *is* assigned to a genpd (the memory controller), it's just that > that genpd isn't actually a parent of the CPU device. Without the patch you > end up with: > > [ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19) > [ 3.042881] cpu cpu4: Failed to set required opps: -19 > [ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19 Hmm, Saravana and Sibi were working on a similar problem earlier and decided to solve this using devfreq instead. Don't remember the exact series which got merged for this, Sibi ? If this part fails, how do you actually set the performance state of the memory controller's genpd ? -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel