From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03932C433EF for ; Tue, 12 Oct 2021 06:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE49460F21 for ; Tue, 12 Oct 2021 06:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232431AbhJLGWw (ORCPT ); Tue, 12 Oct 2021 02:22:52 -0400 Received: from verein.lst.de ([213.95.11.211]:40081 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231190AbhJLGWw (ORCPT ); Tue, 12 Oct 2021 02:22:52 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6C0EF68B05; Tue, 12 Oct 2021 08:20:49 +0200 (CEST) Date: Tue, 12 Oct 2021 08:20:49 +0200 From: Christoph Hellwig To: Mikulas Patocka Cc: Christoph Hellwig , Jens Axboe , Ming Lei , Zdenek Kabelac , linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard Message-ID: <20211012062049.GB17407@lst.de> References: <20210924155822.GA10064@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote: > Do you want this patch? Yes, this looks like what I want. Minor nitpicks below: > + .fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED, I'd probably call this fallocate_supported_flags. > + .fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE, Please avoid over 80 lines for a plain list of flags. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C2AC433F5 for ; Tue, 12 Oct 2021 06:21:18 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D599460C4D for ; Tue, 12 Oct 2021 06:21:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D599460C4D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-YIxwRtOlOBaU_IfE-4Sshg-1; Tue, 12 Oct 2021 02:21:12 -0400 X-MC-Unique: YIxwRtOlOBaU_IfE-4Sshg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4CA61926DA3; Tue, 12 Oct 2021 06:21:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5755660853; Tue, 12 Oct 2021 06:21:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 95E7F1803B30; Tue, 12 Oct 2021 06:21:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19C6KwAn011158 for ; Tue, 12 Oct 2021 02:20:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id AE9552026D60; Tue, 12 Oct 2021 06:20:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA07A2026D46 for ; Tue, 12 Oct 2021 06:20:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ECD9D811E7F for ; Tue, 12 Oct 2021 06:20:55 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-7MYAUIiAMzK691jhlZJ4gQ-1; Tue, 12 Oct 2021 02:20:51 -0400 X-MC-Unique: 7MYAUIiAMzK691jhlZJ4gQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 6C0EF68B05; Tue, 12 Oct 2021 08:20:49 +0200 (CEST) Date: Tue, 12 Oct 2021 08:20:49 +0200 From: Christoph Hellwig To: Mikulas Patocka Message-ID: <20211012062049.GB17407@lst.de> References: <20210924155822.GA10064@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Ming Lei , linux-block@vger.kernel.org, dm-devel@redhat.com, Zdenek Kabelac , Christoph Hellwig Subject: Re: [dm-devel] [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote: > Do you want this patch? Yes, this looks like what I want. Minor nitpicks below: > + .fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED, I'd probably call this fallocate_supported_flags. > + .fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE, Please avoid over 80 lines for a plain list of flags. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel