All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	"Francisco Iglesias" <frasse.iglesias@gmail.com>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>,
	"Joel Stanley" <joel@jms.id.au>
Subject: [PULL 17/18] aspeed/wdt: Add trace events
Date: Tue, 12 Oct 2021 09:37:27 +0200	[thread overview]
Message-ID: <20211012073728.257748-18-clg@kaod.org> (raw)
In-Reply-To: <20211012073728.257748-1-clg@kaod.org>

Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/watchdog/wdt_aspeed.c | 5 +++++
 hw/watchdog/trace-events | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
index 69c37af9a6e9..146ffcd71301 100644
--- a/hw/watchdog/wdt_aspeed.c
+++ b/hw/watchdog/wdt_aspeed.c
@@ -19,6 +19,7 @@
 #include "hw/sysbus.h"
 #include "hw/watchdog/wdt_aspeed.h"
 #include "migration/vmstate.h"
+#include "trace.h"
 
 #define WDT_STATUS                      (0x00 / 4)
 #define WDT_RELOAD_VALUE                (0x04 / 4)
@@ -60,6 +61,8 @@ static uint64_t aspeed_wdt_read(void *opaque, hwaddr offset, unsigned size)
 {
     AspeedWDTState *s = ASPEED_WDT(opaque);
 
+    trace_aspeed_wdt_read(offset, size);
+
     offset >>= 2;
 
     switch (offset) {
@@ -140,6 +143,8 @@ static void aspeed_wdt_write(void *opaque, hwaddr offset, uint64_t data,
     AspeedWDTClass *awc = ASPEED_WDT_GET_CLASS(s);
     bool enable;
 
+    trace_aspeed_wdt_write(offset, size, data);
+
     offset >>= 2;
 
     switch (offset) {
diff --git a/hw/watchdog/trace-events b/hw/watchdog/trace-events
index c3bafbffa911..e7523e22aaf2 100644
--- a/hw/watchdog/trace-events
+++ b/hw/watchdog/trace-events
@@ -5,3 +5,7 @@ cmsdk_apb_watchdog_read(uint64_t offset, uint64_t data, unsigned size) "CMSDK AP
 cmsdk_apb_watchdog_write(uint64_t offset, uint64_t data, unsigned size) "CMSDK APB watchdog write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u"
 cmsdk_apb_watchdog_reset(void) "CMSDK APB watchdog: reset"
 cmsdk_apb_watchdog_lock(uint32_t lock) "CMSDK APB watchdog: lock %" PRIu32
+
+# wdt-aspeed.c
+aspeed_wdt_read(uint64_t addr, uint32_t size) "@0x%" PRIx64 " size=%d"
+aspeed_wdt_write(uint64_t addr, uint32_t size, uint64_t data) "@0x%" PRIx64 " size=%d value=0x%"PRIx64
-- 
2.31.1



  parent reply	other threads:[~2021-10-12  7:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  7:37 [PULL 00/18] aspeed queue Cédric Le Goater
2021-10-12  7:37 ` [PULL 01/18] aspeed/smc: Add watchdog Control/Status Registers Cédric Le Goater
2021-10-12  7:37 ` [PULL 02/18] aspeed/smc: Introduce aspeed_smc_error() helper Cédric Le Goater
2021-10-12  7:37 ` [PULL 03/18] aspeed/smc: Stop using the model name for the memory regions Cédric Le Goater
2021-10-12  7:37 ` [PULL 04/18] aspeed/smc: Drop AspeedSMCController structure Cédric Le Goater
2021-10-12  7:37 ` [PULL 05/18] aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash Cédric Le Goater
2021-10-12  7:37 ` [PULL 06/18] aspeed/smc: Remove the 'size' " Cédric Le Goater
2021-10-12  7:37 ` [PULL 07/18] aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs' Cédric Le Goater
2021-10-12  7:37 ` [PULL 08/18] aspeed/smc: QOMify AspeedSMCFlash Cédric Le Goater
2021-10-12  7:37 ` [PULL 09/18] aspeed/smc: Add default reset values Cédric Le Goater
2021-10-12  7:37 ` [PULL 10/18] aspeed/smc: Introduce a new addr_width() class handler Cédric Le Goater
2021-10-12  7:37 ` [PULL 11/18] aspeed/smc: Remove unused attribute 'irqline' Cédric Le Goater
2021-10-12  7:37 ` [PULL 12/18] aspeed/i2c: QOMify AspeedI2CBus Cédric Le Goater
2021-10-12  7:37 ` [PULL 13/18] hw: aspeed_gpio: Fix pin I/O type declarations Cédric Le Goater
2021-10-12  7:37 ` [PULL 14/18] hw: aspeed_gpio: Fix GPIO array indexing Cédric Le Goater
2021-10-12  7:37 ` [PULL 15/18] hw/adc: Add basic Aspeed ADC model Cédric Le Goater
2021-10-12  7:37 ` [PULL 16/18] hw/arm: Integrate ADC model into Aspeed SoC Cédric Le Goater
2021-10-12  7:37 ` Cédric Le Goater [this message]
2021-10-12  7:37 ` [PULL 18/18] aspeed/smc: Dump address offset in trace events Cédric Le Goater
2021-10-12 13:15 ` [PULL 00/18] aspeed queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012073728.257748-18-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=frasse.iglesias@gmail.com \
    --cc=joel@jms.id.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.