From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: akpm@linux-foundation.org, bp@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer
Date: Tue, 12 Oct 2021 20:01:06 -0400 [thread overview]
Message-ID: <20211012200106.1afdbb0b@gandalf.local.home> (raw)
In-Reply-To: <20211012213523.39801-1-ahalaney@redhat.com>
On Tue, 12 Oct 2021 16:35:23 -0500
Andrew Halaney <ahalaney@redhat.com> wrote:
> --- a/init/main.c
> +++ b/init/main.c
> @@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
> for (p = &envp_init[2]; *p; p++)
> end += sprintf(end, " %s", *p);
>
> + pr_notice("The kernel command line has unknown parameters. They are either\n");
> + pr_notice("misspelled, not valid for the current kernel configuration,\n");
> + pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
> + pr_notice("be passed to init along with those after '--' on the command line.\n");
> pr_notice("Unknown command line parameters:%s\n", unknown_options);
> memblock_free(unknown_options, len);
What about just changing it to simply say:
pr_notice("Unknown kernel command line parameters "%s", will be passed to user space.\n",
unknown_options);
-- Steve
next prev parent reply other threads:[~2021-10-13 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 21:35 [PATCH] init: Make unknown command line param message clearer Andrew Halaney
2021-10-13 0:01 ` Steven Rostedt [this message]
2021-10-13 0:18 ` Randy Dunlap
2021-10-13 0:22 ` Steven Rostedt
2021-10-13 12:56 ` Andrew Halaney
2021-10-13 13:03 ` Steven Rostedt
2021-10-13 13:10 ` Borislav Petkov
2021-10-13 22:35 Andrew Halaney
2021-10-13 22:49 ` Randy Dunlap
2021-10-13 23:12 ` Andrew Morton
2021-10-14 12:47 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012200106.1afdbb0b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ahalaney@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.