From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93CEC433F5 for ; Tue, 12 Oct 2021 21:13:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D93060D43 for ; Tue, 12 Oct 2021 21:13:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D93060D43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0F6B1834CC; Tue, 12 Oct 2021 23:13:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="d/Hgx9BB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D51F834CC; Tue, 12 Oct 2021 23:13:50 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1AF8F83477 for ; Tue, 12 Oct 2021 23:13:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id r1so667550qta.12 for ; Tue, 12 Oct 2021 14:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yDfaL8LMFLNp+1KPL7F+nbgce1sj1tVVE0+M4INCgGA=; b=d/Hgx9BBegfhNZPzDtQ3m8oIpNzJ178CqkIldBT2yvNVmLlSjLSvim+zeB7CO8LVVF oP/UnOv9JILWiRv7joTwnwFT9wmIsJIRDCQEGRQnUNJZzbwlePRqnwP7hcO8IMbWsYBX i6VGWKCZ3vDdgDgFLabEatve7bRc13UOeKrWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yDfaL8LMFLNp+1KPL7F+nbgce1sj1tVVE0+M4INCgGA=; b=Mqfi7v/cqjV48Hes1QPpWqAlJHRdwKghp5+mjlphHoWf8CBMmz09iEWNY1cCHhL1n4 zDyV8sWOWXJhKA4+mpWEUvgBZNzP04hgBBsq/VYNUyUQP96jbOVGuk8P1nBCD1NB6fMz A7/Dopkw0v+N7QmBEaIIkxSplau/kHqbj2Hyr+6JF50nyyMr6tfUTXYUPZVAdwmGkIJ2 D70iHIAAZuaVLpjuXjGwrDbDk78jPJYjwd4pWbqW6Kh6ySMVXECtoXtMow5K6Z0Vr67a qpOeQVY75UQxlJc5Lk9jVHc5BEftnjS6UXyIQJDmuVG7WrPvmPSTN2NmhslM54H8H+UN TnQw== X-Gm-Message-State: AOAM533Ai6IXBoU8g/qSdNue7pji1jLTkk+thKKJw1EWxvbamNI8vidD yhNirFsY3bK6xqGUChz9jxpn9GzBkSNCiA== X-Google-Smtp-Source: ABdhPJxWAFAeVcprYWbsOatKuhSk7aK5Mbqg4GStYMyop2GPhzJMDBadRrhQd/wBwwx4dDnN0jB8VQ== X-Received: by 2002:a05:622a:48c:: with SMTP id p12mr26026697qtx.59.1634073225909; Tue, 12 Oct 2021 14:13:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e98d-c49f-f596-1fb5.res6.spectrum.com. [2603:6081:7b01:cbda:e98d:c49f:f596:1fb5]) by smtp.gmail.com with ESMTPSA id w17sm6883655qts.53.2021.10.12.14.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 14:13:45 -0700 (PDT) Date: Tue, 12 Oct 2021 17:13:43 -0400 From: Tom Rini To: Simon Glass Cc: AKASHI Takahiro , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , U-Boot Mailing List Subject: Re: [RFC 00/22] efi_loader: more tightly integrate UEFI disks to device model Message-ID: <20211012211343.GH7964@bill-the-cat> References: <20211001050228.55183-1-takahiro.akashi@linaro.org> <20211012150023.GY7964@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XGJ4AFwUsJ5M8gfn" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --XGJ4AFwUsJ5M8gfn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 12, 2021 at 02:31:15PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 12 Oct 2021 at 09:00, Tom Rini wrote: > > > > On Sun, Oct 10, 2021 at 08:14:00AM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 30 Sept 2021 at 23:02, AKASHI Takahiro > > > wrote: > > > > > > > > The purpose of this RPC is to reignite the discussion about how UEFI > > > > subystem would best be integrated into U-Boot device model. > > > > In the past, I poposed a couple of patch series, the latest one[1], > > > > while Heinrich revealed his idea[2], and the approach taken here is > > > > something between them, with a focus on block device handlings. > > > > > > > > # The code is a PoC and not well tested yet. > > > > > > > > Disks in UEFI world: > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > In general in UEFI world, accessing to any device is performed thro= ugh > > > > a 'protocol' interface which are installed to (or associated with) = the device's > > > > UEFI handle (or an opaque pointer to UEFI object data). Protocols a= re > > > > implemented by either the UEFI system itself or UEFI drivers. > > > > > > > > For block IO's, it is a device which has EFI_BLOCK_IO_PROTOCOL (efi= _disk > > > > hereafter). Currently, every efi_disk may have one of two origins: > > > > a.U-Boot's block devices or related partitions > > > > (lib/efi_loader/efi_disk.c) > > > > b.UEFI objects which are implemented as a block device by UEFI driv= ers. > > > > (lib/efi_driver/efi_block_device.c) > > > > > > > > All the efi_diskss as (a) will be enumelated and created only once = at UEFI > > > > subsystem initialization (efi_disk_register()), which is triggered = by > > > > first executing one of UEFI-related U-Boot commands, like "bootefi", > > > > "setenv -e" or "efidebug". > > > > EFI_BLOCK_IO_PROTOCOL is implemented by UEFI system using blk_desc(= ->ops) > > > > in the corresponding udevice(UCLASS_BLK). > > > > > > > > On the other hand, efi_disk as (b) will be created each time UEFI b= oot > > > > services' connect_controller() is executed in UEFI app which, as a = (device) > > > > controller, gives the method to access the device's data, > > > > ie. EFI_BLOCK_IO_PROTOCOL. > > > > > > > > >>> more details >>> > > > > Internally, connect_controller() search for UEFI driver that can su= pport > > > > this controller/protocol, 'efi_block' driver(UCLASS_EFI) in this ca= se, > > > > then calls the driver's 'bind' interface, which eventually installs > > > > the controller's EFI_BLOCK_IO_PROTOCOL to efi_disk object. > > > > 'efi_block' driver also create a corresponding udevice(UCLASS_BLK) = for > > > > * creating additional partitions efi_disk's, and > > > > * supporting a file system (EFI_SIMPLE_FILE_SYSTEM_PROTOCOL) on i= t. > > > > <<< <<< > > > > > > > > Issues: > > > > =3D=3D=3D=3D=3D=3D=3D > > > > 1. While an efi_disk represents a device equally for either a whole= disk > > > > or a partition in UEFI world, the device model treats only a who= le > > > > disk as a real block device or udevice(UCLASS_BLK). > > > > > > > > 2. efi_disk holds and makes use of "blk_desc" data even though blk_= desc > > > > in plat_data is supposed to be private and not to be accessed ou= tside > > > > the device model. > > > > # This issue, though, exists for all the implmenetation of U-Boot > > > > # file systems as well. > > > > > > Yes, this was a migration convenience and we should be able to unpick= it now. > > > > > > However we still have SPL_BLK so need to consider whether we can drop= that. > > > > To be clear here, in that I can hand-wave my way to seeing a use case > > for lib/efi_loader/ under SPL, it would not be in a world where we also > > still would be supporting the non-DM infrastructure, and is also not a > > near-term goal. >=20 > OK good. Perhaps we should add a migration method for SPL_BLK? It > would be good to know where we are in terms of the size stuff. I don't > see a lot of boards rushing to use of-platdata, though. What do you mean? Since we have platforms that need to support 12 or 16 KiB of space for SPL, we're not going to enforce SPL_DM. But those platforms can / do need to boot from MMC (SD card I think usually). In terms of platforms that could, but don't, enable SPL_BLK, that's just the platforms that disable SPL_BLK today as it defaults to enabled when possible. --=20 Tom --XGJ4AFwUsJ5M8gfn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFl+ocACgkQFHw5/5Y0 tyzeAgwAh8BhSRMjDYAtV6DSGPwT+6ugfdPtm8IVxA8SMiNpn/K4hB4Tr/JnJ2So VHQBy4K3rFKRe51ayHvyltqw+FQaVzFtiFp7IHVKxqrZqfVfjLgKsgXL422S9J2S JEtfsICdenPOFfTUJK1gJBa5ZQXDww1rhjCxHHl3vlGsthiPqhGVLtGcFxdShwkX et8e2W1Wk5mZ2RMNBpXJADeQw9gTe39WY5anDLtSqZkkLEjs+SpJf4h1jmczlDC6 F4o6yUoC0/TBdFLvqC3eU0vLEVy6FU5YEamA3lLjeXI38LujGdfisx9XbOYu8Ed1 TsEAIDYUnY9cig/s7jP9WsztssF5IKa0/ALdsmfiWOP/ucOaMOjhfTaPMUVJQsbH APagCh39r3r3PEWR1tUVrTHFv7xJbfpzbFKH8lfMUpeIaNAf8jKAEORnIZWSo7Xa VLQ2PsG1no3v3vx2XxZQoMsV8i8qrvgMy2IsdZyW1NDE+KWhFPL23mFeppk3Qk2C ybUvUBDc =ACAD -----END PGP SIGNATURE----- --XGJ4AFwUsJ5M8gfn--