From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016ACC433F5 for ; Wed, 13 Oct 2021 01:32:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F33C60F21 for ; Wed, 13 Oct 2021 01:32:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F33C60F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C01883267; Wed, 13 Oct 2021 03:32:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="TPcQ9flK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DA70D82BE5; Wed, 13 Oct 2021 03:32:29 +0200 (CEST) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3656083267 for ; Wed, 13 Oct 2021 03:32:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x430.google.com with SMTP id w6so1003798pfd.11 for ; Tue, 12 Oct 2021 18:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ZLrM0/A1yjjfg26D7Ctm/IRsFb64vgVWaIvasIsy2TQ=; b=TPcQ9flKrFcrhP0L59xb61w3ws3tVivfPscBmrIer5y6ytfUg5t+8Kd0/NDET758bb 08sYvCmMYHKe836KxEJjnezOw/tqKOmoyqXe597Bq+T9W+5phCdO9mD9P/wZZh2JV0XZ B6U1y8uhUPF/VV41QelVL50asSYSY/w8y16RsQRbXJ+u2TSs+qjywnFpa+Lhs+8RBMxO l/c6BjFBtYt/63+Ny6RdXP52FxLKYkQssOwb7uAuUM8rutBWa5rh7CXo+EJtiWjELiTA LoOUHpVb5KKaNpv+2cGphif/Lnoqb7k+INX6F0Kw0AAwTliQ3u5VQJjIVIwB6iFvA7L0 4Vzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ZLrM0/A1yjjfg26D7Ctm/IRsFb64vgVWaIvasIsy2TQ=; b=7CFtlY4hftvgX6AIS4liDux1Fx+/0HhluP3XGx5P37uQ/A+Jv+nj3a3JyBEAtqwo1S VivtAOCrKSVFWYJg6oQZrO1BSbMTe9nZ6KcMyTc55MzNd4dbAaIThk1qScBszh5nqlZR I0MOnts2Hu9LQEy414/YNXvBlybwXY8oHKHsrMK+EnlpyHY88umYcZ9jEVlhmDU5jebp wlgkwjvVN6hqLfG0N2ORbpgaUH1Zj0gnZrVoL997OUL4s/eqXYQgj7Zv3jCbHSa605zP bw7fr1q4xM06yo+uDIBKQZ3iD31GZRpEzr1mBWJWy2xSSB1ORsYN6WDM8Vtt2eSWG2sz skWw== X-Gm-Message-State: AOAM533I+DOEJrFPAMvpICvT3vZMjKG7XFht4dd3OMuyawCT71Euk+tn F/6RbJlFotmWOk0A/NkjbJ3bEQ== X-Google-Smtp-Source: ABdhPJxLzdSdHb2HEcDGuIscajegNbEJ30sy+ukqD3hG2B8UfMGdhQE3AnZDbY8+JLk+R+BmcNA2iQ== X-Received: by 2002:a62:1d14:0:b0:44d:3b0b:d027 with SMTP id d20-20020a621d14000000b0044d3b0bd027mr7145793pfd.60.1634088742260; Tue, 12 Oct 2021 18:32:22 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:1d60:171b:3906:2add]) by smtp.gmail.com with ESMTPSA id 60sm3904815pjz.11.2021.10.12.18.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 18:32:21 -0700 (PDT) Date: Wed, 13 Oct 2021 10:32:17 +0900 From: AKASHI Takahiro To: Tom Rini Cc: Simon Glass , Heinrich Schuchardt , U-Boot Mailing List , Alex Graf , Ilias Apalodimas Subject: Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION Message-ID: <20211013013217.GC43695@laputa> Mail-Followup-To: AKASHI Takahiro , Tom Rini , Simon Glass , Heinrich Schuchardt , U-Boot Mailing List , Alex Graf , Ilias Apalodimas References: <20211001050228.55183-15-takahiro.akashi@linaro.org> <20211004032759.GC39720@laputa> <20211008005156.GA34717@laputa> <3455705e-1b04-cf01-3cff-b89f673c5e05@gmx.de> <20211011022925.GE44356@laputa> <64774cd7-2119-347a-4d2b-3715fa2a8029@gmx.de> <20211012151417.GZ7964@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012151417.GZ7964@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 12, 2021 at 11:14:17AM -0400, Tom Rini wrote: > On Mon, Oct 11, 2021 at 10:14:00AM -0600, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 11 Oct 2021 at 09:02, Heinrich Schuchardt wrote: > > > > > > > > > > > > On 10/11/21 16:54, Simon Glass wrote: > > > > Hi Takahiro, > > > > > > > > On Sun, 10 Oct 2021 at 20:29, AKASHI Takahiro > > > > wrote: > > > >> > > > >> Heinrich, > > > >> > > > >> On Fri, Oct 08, 2021 at 10:23:52AM +0200, Heinrich Schuchardt wrote: > > > >>> > > > >>> > > > >>> On 10/8/21 02:51, AKASHI Takahiro wrote: > > > >>>> On Mon, Oct 04, 2021 at 12:27:59PM +0900, AKASHI Takahiro wrote: > > > >>>>> On Fri, Oct 01, 2021 at 11:30:37AM +0200, Heinrich Schuchardt wrote: > > > >>>>>> > > > >>>>>> > > > >>>>>> On 10/1/21 07:01, AKASHI Takahiro wrote: > > > >>>>>>> UCLASS_PARTITION device will be created as a child node of > > > >>>>>>> UCLASS_BLK device. > > > >>>>>>> > > > >>>>>>> Signed-off-by: AKASHI Takahiro > > > >>>>>>> --- > > > >>>>>>> drivers/block/blk-uclass.c | 111 +++++++++++++++++++++++++++++++++++++ > > > >>>>>>> include/blk.h | 9 +++ > > > >>>>>>> include/dm/uclass-id.h | 1 + > > > >>>>>>> 3 files changed, 121 insertions(+) > > > >>>>>>> > > > >>>>>>> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c > > > >>>>>>> index 83682dcc181a..dd7f3c0fe31e 100644 > > > >>>>>>> --- a/drivers/block/blk-uclass.c > > > >>>>>>> +++ b/drivers/block/blk-uclass.c > > > >>>>>>> @@ -12,6 +12,7 @@ > > > >>>>>>> #include > > > >>>>>>> #include > > > >>>>>>> #include > > > >>>>>>> +#include > > > >>>>>>> #include > > > >>>>>>> #include > > > >>>>>>> #include > > > >>>>>>> @@ -695,6 +696,44 @@ int blk_unbind_all(int if_type) > > > >>>>>>> return 0; > > > >>>>>>> } > > > >>>>>>> > > > >>>>>>> +int blk_create_partitions(struct udevice *parent) > > > >>>>>>> +{ > > > >>>>>>> + int part, count; > > > >>>>>>> + struct blk_desc *desc = dev_get_uclass_plat(parent); > > > >>>>>>> + struct disk_partition info; > > > >>>>>>> + struct disk_part *part_data; > > > >>>>>>> + char devname[32]; > > > >>>>>>> + struct udevice *dev; > > > >>>>>>> + int ret; > > > >>>>>>> + > > > >>>>>>> + if (!CONFIG_IS_ENABLED(PARTITIONS) || > > > >>>>>>> + !CONFIG_IS_ENABLED(HAVE_BLOCK_DEVICE)) > > > >>>>>>> + return 0; > > > >>>>>>> + > > > >>>>>>> + /* Add devices for each partition */ > > > >>>>>>> + for (count = 0, part = 1; part <= MAX_SEARCH_PARTITIONS; part++) { > > > >>>>>>> + if (part_get_info(desc, part, &info)) > > > >>>>>>> + continue; > > > >>>>>>> + snprintf(devname, sizeof(devname), "%s:%d", parent->name, > > > >>>>>>> + part); > > > >>>>>>> + > > > >>>>>>> + ret = device_bind_driver(parent, "blk_partition", > > > >>>>>>> + strdup(devname), &dev); > > > >>>>>>> + if (ret) > > > >>>>>>> + return ret; > > > >>>>>>> + > > > >>>>>>> + part_data = dev_get_uclass_plat(dev); > > > >>>>>>> + part_data->partnum = part; > > > >>>>>>> + part_data->gpt_part_info = info; > > > >>>>>>> + count++; > > > >>>>>>> + > > > >>>>>>> + device_probe(dev); > > > >>>>>>> + } > > > >>>>>>> + debug("%s: %d partitions found in %s\n", __func__, count, parent->name); > > > >>>>>>> + > > > >>>>>>> + return 0; > > > >>>>>>> +} > > > >>>>>>> + > > > >>>>>>> static int blk_post_probe(struct udevice *dev) > > > >>>>>>> { > > > >>>>>>> if (IS_ENABLED(CONFIG_PARTITIONS) && > > > >>>>>>> @@ -713,3 +752,75 @@ UCLASS_DRIVER(blk) = { > > > >>>>>>> .post_probe = blk_post_probe, > > > >>>>>>> .per_device_plat_auto = sizeof(struct blk_desc), > > > >>>>>>> }; > > > >>>>>>> + > > > >>>>>>> +static ulong blk_part_read(struct udevice *dev, lbaint_t start, > > > >>>>>>> + lbaint_t blkcnt, void *buffer) > > > >>>>>>> +{ > > > >>>>>>> + struct udevice *parent; > > > >>>>>>> + struct disk_part *part; > > > >>>>>>> + const struct blk_ops *ops; > > > >>>>>>> + > > > >>>>>>> + parent = dev_get_parent(dev); > > > >>>>>> > > > >>>>>> What device type will the parent have if it is a eMMC hardware partition? > > > >>>>>> > > > >>>>>>> + ops = blk_get_ops(parent); > > > >>>>>>> + if (!ops->read) > > > >>>>>>> + return -ENOSYS; > > > >>>>>>> + > > > >>>>>>> + part = dev_get_uclass_plat(dev); > > > >>>>>> > > > >>>>>> You should check that we do not access the block device past the > > > >>>>>> partition end: > > > >>>>> > > > >>>>> Yes, I will fix all of checks. > > > >>>>> > > > >>>>>> struct blk_desc *desc = dev_get_uclass_plat(parent); > > > >>>>>> if ((start + blkcnt) * desc->blksz < part->gpt_part_info.blksz) > > > >>>>>> return -EFAULT. > > > >>>>>> > > > >>>>>>> + start += part->gpt_part_info.start; > > > >>>> > > > >>>> A better solution is: > > > >>>> if (start >= part->gpt_part_info.size) > > > >>>> return 0; > > > >>>> > > > >>>> if ((start + blkcnt) > part->gpt_part_info.size) > > > >>>> blkcnt = part->gpt_part_info.size - start; > > > >>>> start += part->gpt_part_info.start; > > > >>>> instead of returning -EFAULT. > > > >>>> (note that start and blkcnt are in "block".) > > > >>> > > > >>> What is your motivation to support an illegal access? > > > >>> > > > >>> We will implement the EFI_BLOCK_IO_PROTOCOL based on this function. The > > > >>> ReadBlocks() and WriteBlocks() services must return > > > >>> EFI_INVALID_PARAMETER if the read request contains LBAs that are not > > > >>> valid. > > > >> > > > >> I interpreted that 'LBA' was the third parameter to ReadBlocks API, > > > >> and that if the starting block is out of partition region, we should > > > >> return an error (and if not, we still want to trim IO request to fit > > > >> into partition size as other OS's API like linux does). > > > >> Do you think it's incorrect? > > > > > > > > [..] > > > > > > > > Related to this patch I think that the partition type should be really > > > > be a child of the media device: > > > > > > > > - MMC > > > > |- BLK > > > > |- PARTITION > > > > |- BLK > > > > |- PARTITION > > > > |- BLK > > > > |- PARTITION > > > > |- BLK > > > > > > > > It seems more natural to me that putting the partitions under the > > > > top-level BLK device, so that BLK remains a 'terminal' device. > > > > > > > > The partition uclass is different from BLK, of course. It could > > > > contain information about the partition such as its partition number > > > > and UUID. > > > > > > Do you mean hardware partition here? Otherwise I would not know what BLK > > > should model. > > > > I mean that (I think) we should not use BLK to model partitions. A BLK > > should just be a block device. > > > > I don't see any difference between a partition and a hardware > > partition. We presumably end up with a hierarchy though. Do we need a > > HWPARTITION uclass so we can handle the hardware partitions > > differently? > > Note that for eMMC devices, hardware partitions are different from > partition-table partitions. If you boot a system with an eMMC device up > in Linux you typically get mmcblkN, mmcblkNboot0, mmcblkNboot1 and > mmcblkNrpmb, each of which are hardware partitions. It gets tricky in > U-Boot in that you can access each of these with 'mmc dev N M' where M > defaults to 0 and is the user partition (mmcblkN), 1/2 are boot0/boot1 > and 3 is the rpmb area. The 'mmc' command also allows, when possible > and implemented, configuring these partitions, again to the extent > allowed, documented and implemented. Thank you. That is exactly what I tried to mention in my reply at "part: call part_init() in blk_get_device_by_str() only for MMC" ---8<--- # On the other hand, we have to explicitly switch "hw partitions" # with blk_select_hwpart_devnum() on MMC devices even though we use # the *same* udevice(blk_desc). --->8--- The problem with the current U-Boot driver model is that all of "mmcblkN, mmcblkNboot0, mmcblkNboot1 and mmcblkNrpmb" will be linked to the same udevice. We have to do "mmc dev N M" or call blk_select_hwpart[_devnum]() to distinguish them. When it comes to UEFI, I hope we can currently support hw partitions in this way: => efidebug add boot -b 1 FOO mmc 0.1 /foo.bin "" (".1" is a key, I have never tried this syntax though.) But probably its device path won't be properly formatted as expected as Heinrich suggested. -Takahiro Akashi > In terms of modeling, this is akin to how if you use a USB card reader > that supports 4 different form-factor cards, you can end up with 4 > different devices showing up in Linux (if you have one of the nice card > readers that supports multiple cards at once). > > -- > Tom