From: zhihongx.peng@intel.com
To: olivier.matz@6wind.com, dmitry.kozliuk@gmail.com
Cc: dev@dpdk.org, Zhihong Peng <zhihongx.peng@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit
Date: Wed, 13 Oct 2021 01:52:22 +0000 [thread overview]
Message-ID: <20211013015223.1155876-1-zhihongx.peng@intel.com> (raw)
In-Reply-To: <20211008064131.369133-1-zhihongx.peng@intel.com>
From: Zhihong Peng <zhihongx.peng@intel.com>
Malloc cl in the cmdline_stdin_new function, so release in the
cmdline_stdin_exit function is logical, so that cl will not be
released alone.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>
---
doc/guides/rel_notes/release_21_11.rst | 3 +++
lib/cmdline/cmdline_socket.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
index f643a61f44..2f59077709 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -226,6 +226,9 @@ API Changes
the crypto/security operation. This field will be used to communicate
events such as soft expiry with IPsec in lookaside mode.
+* cmdline: ``cmdline_stdin_exit()`` now frees the ``cmdline`` structure.
+ Calls to ``cmdline_free()`` after it need to be deleted from applications.
+
ABI Changes
-----------
diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c
index 998e8ade25..ebd5343754 100644
--- a/lib/cmdline/cmdline_socket.c
+++ b/lib/cmdline/cmdline_socket.c
@@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl)
return;
terminal_restore(cl);
+ cmdline_free(cl);
}
--
2.25.1
next prev parent reply other threads:[~2021-10-13 2:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 2:28 [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-08-31 16:59 ` Stephen Hemminger
2021-09-06 5:45 ` Peng, ZhihongX
2021-08-31 17:52 ` Dmitry Kozlyuk
2021-09-06 5:51 ` Peng, ZhihongX
2021-09-06 7:33 ` Dmitry Kozlyuk
2021-09-30 6:53 ` Peng, ZhihongX
2021-09-30 7:44 ` Dmitry Kozlyuk
2021-10-08 6:55 ` Peng, ZhihongX
2021-09-17 2:15 ` [dpdk-dev] [PATCH v2 1/2] " zhihongx.peng
2021-09-17 2:15 ` [dpdk-dev] [PATCH v2 2/2] app/test: Delete cmdline free function zhihongx.peng
2021-10-08 6:41 ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-08 6:41 ` [dpdk-dev] [PATCH v3 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-11 8:26 ` Dmitry Kozlyuk
2021-10-11 5:20 ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Peng, ZhihongX
2021-10-11 8:25 ` Dmitry Kozlyuk
2021-10-13 1:53 ` Peng, ZhihongX
2021-10-13 2:36 ` Dmitry Kozlyuk
2021-10-13 3:12 ` Peng, ZhihongX
2021-10-13 1:52 ` zhihongx.peng [this message]
2021-10-13 1:52 ` [dpdk-dev] [PATCH v4 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-18 13:58 ` [dpdk-dev] [PATCH v5] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-18 14:29 ` Dmitry Kozlyuk
2021-10-20 7:03 ` Olivier Matz
2021-10-22 21:33 ` Thomas Monjalon
2021-10-20 9:22 ` Peng, ZhihongX
2021-10-15 12:58 ` [dpdk-dev] [PATCH v4 1/2] " Olivier Matz
2021-10-18 5:16 ` Peng, ZhihongX
2021-09-30 6:47 ` [dpdk-dev] [PATCH v2 " Peng, ZhihongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013015223.1155876-1-zhihongx.peng@intel.com \
--to=zhihongx.peng@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.