From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6D7C4332F for ; Wed, 13 Oct 2021 14:24:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1488610FB for ; Wed, 13 Oct 2021 14:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235819AbhJMO0Y convert rfc822-to-8bit (ORCPT ); Wed, 13 Oct 2021 10:26:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:42478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236942AbhJMO0X (ORCPT ); Wed, 13 Oct 2021 10:26:23 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C6F26101D; Wed, 13 Oct 2021 14:24:17 +0000 (UTC) Date: Wed, 13 Oct 2021 10:24:15 -0400 From: Steven Rostedt To: =?UTF-8?B?546L6LSH?= Cc: Miroslav Benes , Guo Ren , Ingo Molnar , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , Colin Ian King , Masami Hiramatsu , "Peter Zijlstra (Intel)" , Nicholas Piggin , Jisheng Zhang , linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, live-patching@vger.kernel.org Subject: Re: [RESEND PATCH v2 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() Message-ID: <20211013102415.10788200@gandalf.local.home> In-Reply-To: <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> References: <75ee86ac-02f2-d687-ab1e-9c8c33032495@linux.alibaba.com> <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, 13 Oct 2021 16:34:53 +0800 ηŽ‹θ΄‡ wrote: > On 2021/10/13 δΈ‹εˆ4:25, Miroslav Benes wrote: > >>> Side note... the comment will eventually conflict with peterz's > >>> https://lore.kernel.org/all/20210929152429.125997206@infradead.org/. > >> > >> Steven, would you like to share your opinion on this patch? > >> > >> If klp_synchronize_transition() will be removed anyway, the comments > >> will be meaningless and we can just drop it :-P > > > > The comment will still be needed in some form. We will handle it depending > > on what gets merged first. peterz's patches are not ready yet. > > Ok, then I'll move it before trylock() inside klp_ftrace_handler() anyway. +1 -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BBBC433EF for ; Wed, 13 Oct 2021 14:24:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CD7660E96 for ; Wed, 13 Oct 2021 14:24:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5CD7660E96 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q60qSDWSDOu5VzxW2tE9LBEmFeZ9x7hbMONr6WeHDkQ=; b=s6RYDH12vk/HzV aqsqFvhOcgGs8js1lufFdlqtsqZMTMDWpNBoEfQkESeBDGDaMNd6JWsO9umsSXf7q9msUeqXxnutY jiJruOiabT+MamiHu/jV4UZlkctAYQXA2PKQR58pGhW8xN77mYNJCqv1gPaJx0XkTOkl8FjM8aPsO AWukMphLrIpEqI0AeTgr8WFDv8kihCLUBwdstAB+KukalF/O4wudrGU3O7lPiyhwvvpQVjigFiE38 t79mmRyL52GIrU+wT3zdZShbucEsv2AlY8rUVFDQ6oy0pNxN7SjeVfXEE+xic+Ede5O8Lpzec0O7i fFVunHrkCpPxbXLDVrxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mafBL-00H8Xp-LK; Wed, 13 Oct 2021 14:24:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mafB6-00H8R2-MR for linux-riscv@lists.infradead.org; Wed, 13 Oct 2021 14:24:23 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C6F26101D; Wed, 13 Oct 2021 14:24:17 +0000 (UTC) Date: Wed, 13 Oct 2021 10:24:15 -0400 From: Steven Rostedt To: =?UTF-8?B?546L6LSH?= Cc: Miroslav Benes , Guo Ren , Ingo Molnar , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , Colin Ian King , Masami Hiramatsu , "Peter Zijlstra (Intel)" , Nicholas Piggin , Jisheng Zhang , linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, live-patching@vger.kernel.org Subject: Re: [RESEND PATCH v2 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() Message-ID: <20211013102415.10788200@gandalf.local.home> In-Reply-To: <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> References: <75ee86ac-02f2-d687-ab1e-9c8c33032495@linux.alibaba.com> <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_072420_817226_659F25BF X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMyBPY3QgMjAyMSAxNjozNDo1MyArMDgwMArnjovotIcgPHl1bi53YW5nQGxpbnV4 LmFsaWJhYmEuY29tPiB3cm90ZToKCj4gT24gMjAyMS8xMC8xMyDkuIvljYg0OjI1LCBNaXJvc2xh diBCZW5lcyB3cm90ZToKPiA+Pj4gU2lkZSBub3RlLi4uIHRoZSBjb21tZW50IHdpbGwgZXZlbnR1 YWxseSBjb25mbGljdCB3aXRoIHBldGVyeidzIAo+ID4+PiBodHRwczovL2xvcmUua2VybmVsLm9y Zy9hbGwvMjAyMTA5MjkxNTI0MjkuMTI1OTk3MjA2QGluZnJhZGVhZC5vcmcvLiAgCj4gPj4KPiA+ PiBTdGV2ZW4sIHdvdWxkIHlvdSBsaWtlIHRvIHNoYXJlIHlvdXIgb3BpbmlvbiBvbiB0aGlzIHBh dGNoPwo+ID4+Cj4gPj4gSWYga2xwX3N5bmNocm9uaXplX3RyYW5zaXRpb24oKSB3aWxsIGJlIHJl bW92ZWQgYW55d2F5LCB0aGUgY29tbWVudHMKPiA+PiB3aWxsIGJlIG1lYW5pbmdsZXNzIGFuZCB3 ZSBjYW4ganVzdCBkcm9wIGl0IDotUCAgCj4gPiAKPiA+IFRoZSBjb21tZW50IHdpbGwgc3RpbGwg YmUgbmVlZGVkIGluIHNvbWUgZm9ybS4gV2Ugd2lsbCBoYW5kbGUgaXQgZGVwZW5kaW5nIAo+ID4g b24gd2hhdCBnZXRzIG1lcmdlZCBmaXJzdC4gcGV0ZXJ6J3MgcGF0Y2hlcyBhcmUgbm90IHJlYWR5 IHlldC4gIAo+IAo+IE9rLCB0aGVuIEknbGwgbW92ZSBpdCBiZWZvcmUgdHJ5bG9jaygpIGluc2lk ZSBrbHBfZnRyYWNlX2hhbmRsZXIoKSBhbnl3YXkuCgorMQoKLS0gU3RldmUKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFE2C433F5 for ; Wed, 13 Oct 2021 14:24:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E1360E96 for ; Wed, 13 Oct 2021 14:24:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40E1360E96 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HTvtr2WHDz2ypR for ; Thu, 14 Oct 2021 01:24:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=srs0=7yos=pb=goodmis.org=rostedt@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HTvtH6tp9z2xss for ; Thu, 14 Oct 2021 01:24:23 +1100 (AEDT) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C6F26101D; Wed, 13 Oct 2021 14:24:17 +0000 (UTC) Date: Wed, 13 Oct 2021 10:24:15 -0400 From: Steven Rostedt To: =?UTF-8?B?546L6LSH?= Subject: Re: [RESEND PATCH v2 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() Message-ID: <20211013102415.10788200@gandalf.local.home> In-Reply-To: <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> References: <75ee86ac-02f2-d687-ab1e-9c8c33032495@linux.alibaba.com> <861d81d6-e202-09f3-f0be-6c77205f9d34@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Peter Zijlstra \(Intel\)" , Paul Walmsley , "James E.J. Bottomley" , Guo Ren , Jisheng Zhang , "H. Peter Anvin" , live-patching@vger.kernel.org, linux-riscv@lists.infradead.org, Miroslav Benes , Paul Mackerras , Joe Lawrence , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , Petr Mladek , Albert Ou , Jiri Kosina , Nicholas Piggin , Borislav Petkov , Josh Poimboeuf , Thomas Gleixner , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , Masami Hiramatsu , Colin Ian King , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 13 Oct 2021 16:34:53 +0800 =E7=8E=8B=E8=B4=87 wrote: > On 2021/10/13 =E4=B8=8B=E5=8D=884:25, Miroslav Benes wrote: > >>> Side note... the comment will eventually conflict with peterz's=20 > >>> https://lore.kernel.org/all/20210929152429.125997206@infradead.org/. = =20 > >> > >> Steven, would you like to share your opinion on this patch? > >> > >> If klp_synchronize_transition() will be removed anyway, the comments > >> will be meaningless and we can just drop it :-P =20 > >=20 > > The comment will still be needed in some form. We will handle it depend= ing=20 > > on what gets merged first. peterz's patches are not ready yet. =20 >=20 > Ok, then I'll move it before trylock() inside klp_ftrace_handler() anyway. +1 -- Steve