Hi Mikulas, I love your patch! Yet something to improve: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on kdave/for-next ceph-client/for-linus cifs/for-next tytso-ext4/dev jaegeuk-f2fs/dev-test mszeredi-fuse/for-next linus/master v5.15-rc5 next-20211012] [cannot apply to hch-configfs/for-next gfs2/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: x86_64-randconfig-a015-20211012 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project adf55ac6657693f7bfbe3087b599b4031a765a44) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c381403746bc0dc3eb5db4b157408430febd6ecf git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727 git checkout c381403746bc0dc3eb5db4b157408430febd6ecf # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/cifs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> fs/cifs/cifsfs.c:1284:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE' .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE | ^ >> fs/cifs/cifsfs.c:1285:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ >> fs/cifs/cifsfs.c:1285:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ >> fs/cifs/cifsfs.c:1286:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ >> fs/cifs/cifsfs.c:1286:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fs/cifs/cifsfs.c:1307:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE' .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE | ^ fs/cifs/cifsfs.c:1308:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1308:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1309:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fs/cifs/cifsfs.c:1309:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fs/cifs/cifsfs.c:1330:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE' .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE | ^ fs/cifs/cifsfs.c:1331:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1331:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1332:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fs/cifs/cifsfs.c:1332:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fs/cifs/cifsfs.c:1351:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE' .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE | ^ fs/cifs/cifsfs.c:1352:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1352:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE' FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | ^ fs/cifs/cifsfs.c:1353:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE' FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. vim +/FALLOC_FL_PUNCH_HOLE +1284 fs/cifs/cifsfs.c 1265 1266 const struct file_operations cifs_file_ops = { 1267 .read_iter = cifs_loose_read_iter, 1268 .write_iter = cifs_file_write_iter, 1269 .open = cifs_open, 1270 .release = cifs_close, 1271 .lock = cifs_lock, 1272 .flock = cifs_flock, 1273 .fsync = cifs_fsync, 1274 .flush = cifs_flush, 1275 .mmap = cifs_file_mmap, 1276 .splice_read = generic_file_splice_read, 1277 .splice_write = iter_file_splice_write, 1278 .llseek = cifs_llseek, 1279 .unlocked_ioctl = cifs_ioctl, 1280 .copy_file_range = cifs_copy_file_range, 1281 .remap_file_range = cifs_remap_file_range, 1282 .setlease = cifs_setlease, 1283 .fallocate = cifs_fallocate, > 1284 .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE | > 1285 FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE | > 1286 FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE, 1287 }; 1288 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org