From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Ramona Alexandra Nechita <ramona.nechita@analog.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: Specify variations of MAX8903
Date: Wed, 13 Oct 2021 20:03:40 +0200 [thread overview]
Message-ID: <20211013180340.hm6kyu45xo3hjofx@earth.universe> (raw)
In-Reply-To: <20210915110340.17411-1-ramona.nechita@analog.com>
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
Hi,
On Wed, Sep 15, 2021 at 02:03:40PM +0300, Ramona Alexandra Nechita wrote:
> MAX8903 has multiple variations (A-E/G/H/J/N/Y).
> Specified them in the Kconfig and in the file comment.
>
> Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
> ---
why? I would expect people to identify this as the correct driver
without this list and it's definetly not grepable.
-- Sebastian
> drivers/power/supply/Kconfig | 2 +-
> drivers/power/supply/max8903_charger.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index c84a7b1caeb6..cca779480b1c 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -442,7 +442,7 @@ config CHARGER_ISP1704
> ISP1707/ISP1704 USB transceivers.
>
> config CHARGER_MAX8903
> - tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
> + tristate "MAX8903A/B/C/D/E/G/H/J/N/Y Battery DC-DC Charger for USB and Adapter Power"
> help
> Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
> The driver supports controlling charger-enable and current-limit
> diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
> index 0bd39b0cc257..4e5c669e6607 100644
> --- a/drivers/power/supply/max8903_charger.c
> +++ b/drivers/power/supply/max8903_charger.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
> + * max8903_charger.c - Maxim 8903A/B/C/D/E/G/H/J/N/Y USB/Adapter Charger Driver
> *
> * Copyright (C) 2011 Samsung Electronics
> * MyungJoo Ham <myungjoo.ham@samsung.com>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-13 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 11:03 [PATCH] power: supply: Specify variations of MAX8903 Ramona Alexandra Nechita
2021-10-13 18:03 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013180340.hm6kyu45xo3hjofx@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ramona.nechita@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.