Re: [PATCH] power: supply: axp288-charger: Optimize register reading method

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]

Hi Kate,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on v5.15-rc5]
[cannot apply to next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kate-Hsuan/power-supply-axp288-charger-Optimize-register-reading-method/20211012-134702
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: x86_64-randconfig-a004-20211004 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/f9d2d930e04a8ae3368545c472183e5085d0c687
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kate-Hsuan/power-supply-axp288-charger-Optimize-register-reading-method/20211012-134702
        git checkout f9d2d930e04a8ae3368545c472183e5085d0c687
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/power/supply/axp288_charger.c: In function 'axp288_charger_usb_update_property':
>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror=implicit-function-declaration]
     411 |  ret = iosf_mbi_block_punit_i2c_access();
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror=implicit-function-declaration]
     430 |  iosf_mbi_unblock_punit_i2c_access();
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/iosf_mbi_block_punit_i2c_access +411 drivers/power/supply/axp288_charger.c

   401	
   402	static int axp288_charger_usb_update_property(struct axp288_chrg_info *info)
   403	{
   404		int ret = 0;
   405	
   406		if (info->valid && time_before(jiffies, info->last_updated + AXP288_REG_UPDATE_INTERVAL))
   407			return 0;
   408	
   409		dev_dbg(&info->pdev->dev, "Charger updating register values...\n");
   410	
 > 411		ret = iosf_mbi_block_punit_i2c_access();
   412		if (ret < 0)
   413			return ret;
   414	
   415		ret = axp288_charger_reg_readb(info, AXP20X_PWR_INPUT_STATUS, &info->input_status);
   416		if (ret < 0)
   417			goto out;
   418	
   419		ret = axp288_charger_reg_readb(info, AXP20X_PWR_OP_MODE, &info->op_mode);
   420		if (ret < 0)
   421			goto out;
   422	
   423		ret = axp288_charger_reg_readb(info, AXP20X_CHRG_BAK_CTRL, &info->backend_control);
   424		if (ret < 0)
   425			goto out;
   426	
   427		info->last_updated = jiffies;
   428		info->valid = true;
   429	out:
 > 430		iosf_mbi_unblock_punit_i2c_access();
   431		return ret;
   432	}
   433	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30522 bytes --]