All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH] tools: mksunxiboot: Use sunxi_image header directly
Date: Thu, 14 Oct 2021 01:19:48 +0100	[thread overview]
Message-ID: <20211014011948.1ad7c07f@slackpad.fritz.box> (raw)
In-Reply-To: <20211013003542.44358-1-samuel@sholland.org>

On Tue, 12 Oct 2021 19:35:41 -0500
Samuel Holland <samuel@sholland.org> wrote:

> When adding eGON support to mkimage, the struct boot_file_head
> definition was moved to its own header. This is the only thing
> mksunxiboot needed out of asm/arch/spl.h. Clean up the relative
> include by switching to new header.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

> ---
> We switched from using mksunxiboot to mkimage in January, so maybe
> it is about time to consider dropping this tool?

Well, is there a reason to remove it? Otherwise I don't see a problem
to keep it around for a while, 9 months is not a terribly long time for
some people.

Cheers,
Andre.

> 
>  tools/mksunxiboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mksunxiboot.c b/tools/mksunxiboot.c
> index a18c9d98bc..becc36565b 100644
> --- a/tools/mksunxiboot.c
> +++ b/tools/mksunxiboot.c
> @@ -12,10 +12,10 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
> +#include <sunxi_image.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
>  #include "imagetool.h"
> -#include "../arch/arm/include/asm/arch-sunxi/spl.h"
>  
>  #define STAMP_VALUE                     0x5F0A6C39
>  


  reply	other threads:[~2021-10-14  0:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  0:35 [PATCH] tools: mksunxiboot: Use sunxi_image header directly Samuel Holland
2021-10-14  0:19 ` Andre Przywara [this message]
2021-10-15  4:21   ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014011948.1ad7c07f@slackpad.fritz.box \
    --to=andre.przywara@arm.com \
    --cc=jagan@amarulasolutions.com \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.