All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: James Buren <braewoods+lkml@braewoods.net>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541
Date: Wed, 13 Oct 2021 22:20:49 -0400	[thread overview]
Message-ID: <20211014022049.GB910341@rowland.harvard.edu> (raw)
In-Reply-To: <20211014015504.2695089-1-braewoods+lkml@braewoods.net>

On Wed, Oct 13, 2021 at 08:55:04PM -0500, James Buren wrote:
> These drive enclosures have firmware bugs that make it impossible to mount
> a new virtual ISO image after Linux ejects the old one if the device is
> locked by Linux. Windows bypasses this problem by the fact that they do
> not lock the device. Add a quirk to disable device locking for these
> drive enclosures.
> 
> Signed-off-by: James Buren <braewoods+lkml@braewoods.net>
> ---

In the future, you should always include a version number in the email 
Subject: line (for example, "[PATCH v2]") so that readers will know 
which patch is which.  And you should include, here just below the "---" 
line, a description of how this version differs from the previous 
version.  See the email archives for examples of multi-version patches.

Nevertheless, this looks okay.

Acked-by: Alan Stern <stern@rowland.harvard.edu>

>  drivers/usb/storage/unusual_devs.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index c6b3fcf90180..29191d33c0e3 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -406,6 +406,16 @@ UNUSUAL_DEV(  0x04b8, 0x0602, 0x0110, 0x0110,
>  		"785EPX Storage",
>  		USB_SC_SCSI, USB_PR_BULK, NULL, US_FL_SINGLE_LUN),
>  
> +/*
> + * Reported by James Buren <braewoods+lkml@braewoods.net>
> + * Virtual ISOs cannot be remounted if ejected while the device is locked
> + * Disable locking to mimic Windows behavior that bypasses the issue
> + */
> +UNUSUAL_DEV(  0x04c5, 0x2028, 0x0001, 0x0001,
> +		"iODD",
> +		"2531/2541",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE),
> +
>  /*
>   * Not sure who reported this originally but
>   * Pavel Machek <pavel@ucw.cz> reported that the extra US_FL_SINGLE_LUN
> -- 
> 2.25.1

  reply	other threads:[~2021-10-14  2:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  1:55 [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541 James Buren
2021-10-14  2:20 ` Alan Stern [this message]
2021-10-15  6:29   ` braewoods
2021-10-15  7:54     ` Greg KH
2021-10-15 13:38       ` Alan Stern
  -- strict thread matches above, loose matches on Subject: below --
2021-10-14  1:50 James Buren
2021-10-14  2:01 ` braewoods

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014022049.GB910341@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=braewoods+lkml@braewoods.net \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.