All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hoyes <peter.hoyes@arm.com>
To: u-boot@lists.denx.de
Cc: bmeng.cn@gmail.com, sjg@chromium.org, kory.maincent@bootlin.com,
	andre.przywara@arm.com, diego.sueiro@arm.com,
	Peter Hoyes <Peter.Hoyes@arm.com>
Subject: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot
Date: Thu, 14 Oct 2021 09:40:04 +0100	[thread overview]
Message-ID: <20211014084004.3173835-1-peter.hoyes@arm.com> (raw)

From: Peter Hoyes <Peter.Hoyes@arm.com>

If using OF_CONTROL, fdtcontroladdr is set to the fdt used to configure
U-Boot. When using PXE, if no fdt is defined in the menu file, and
there is no fdt at fdt_addr, add fall back on fdtcontroladdr too.

We are developing board support for the Armv8r64 FVP using
config_distro_bootcmd. We are also using OF_BOARD and would like the
PXE boot option to default to the fdt provided by board_fdt_blob_setup.

Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
---
 cmd/pxe_utils.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/cmd/pxe_utils.c b/cmd/pxe_utils.c
index 067c24e5ff..8f8e69ca97 100644
--- a/cmd/pxe_utils.c
+++ b/cmd/pxe_utils.c
@@ -556,7 +556,10 @@ static int label_boot(struct cmd_tbl *cmdtp, struct pxe_label *label)
 	 * Scenario 2: If there is an fdt_addr specified, pass it along to
 	 * bootm, and adjust argc appropriately.
 	 *
-	 * Scenario 3: fdt blob is not available.
+	 * Scenario 3: If there is an fdtcontroladdr specified, pass it along to
+	 * bootm, and adjust argc appropriately.
+	 *
+	 * Scenario 4: fdt blob is not available.
 	 */
 	bootm_argv[3] = env_get("fdt_addr_r");
 
@@ -646,6 +649,9 @@ static int label_boot(struct cmd_tbl *cmdtp, struct pxe_label *label)
 	if (!bootm_argv[3])
 		bootm_argv[3] = env_get("fdt_addr");
 
+	if (!bootm_argv[3])
+		bootm_argv[3] = env_get("fdtcontroladdr");
+
 	if (bootm_argv[3]) {
 		if (!bootm_argv[2])
 			bootm_argv[2] = "-";
-- 
2.25.1


             reply	other threads:[~2021-10-14  8:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  8:40 Peter Hoyes [this message]
2021-10-14 18:24 ` [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot Simon Glass
2021-10-15 11:20   ` Andre Przywara
2021-10-24 19:53     ` Simon Glass
2021-10-28 18:55       ` Ramon Fried
2021-11-08 16:52         ` Peter Hoyes
2021-11-09  6:26           ` Ramon Fried
2022-05-18  8:40 ` Neil Armstrong
2022-05-18 15:52   ` Tom Rini
2022-05-18 18:15     ` Neil Armstrong
2022-05-19 12:58       ` Peter Hoyes
2022-05-23  7:25         ` Neil Armstrong
2022-05-23 13:23           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014084004.3173835-1-peter.hoyes@arm.com \
    --to=peter.hoyes@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=bmeng.cn@gmail.com \
    --cc=diego.sueiro@arm.com \
    --cc=kory.maincent@bootlin.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.