All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Huacai Chen <chenhuacai@kernel.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Date: Thu, 14 Oct 2021 11:12:40 +0200	[thread overview]
Message-ID: <20211014091240.vif3nqeveddc6ru2@sirius.home.kraxel.org> (raw)
In-Reply-To: <189eeccd-36fd-d033-7900-30e89fc662df@amsat.org>

  Hi,

> >      if (s->masterbus) {
> >          USBPort *ports[NB_PORTS];
> 
> usb_uhci_common_realize() should be refactored making it PCI-agnostic.

Not sure this is needed here.  This seems to be more a platform-specific
oddity in IRQ routing than a non-pci UHCI device.

take care,
  Gerd



  parent reply	other threads:[~2021-10-14  9:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 12:13 [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts BALATON Zoltan
2021-10-13 14:14 ` Philippe Mathieu-Daudé
2021-10-13 15:21   ` BALATON Zoltan
2021-10-13 15:39     ` BALATON Zoltan
2021-10-13 15:26   ` BALATON Zoltan
2021-10-14  9:12   ` Gerd Hoffmann [this message]
2021-10-14 13:28     ` Philippe Mathieu-Daudé
2021-10-14  9:10 ` Gerd Hoffmann
2021-10-14 10:22   ` BALATON Zoltan
2021-10-14 13:01     ` Gerd Hoffmann
2021-10-14 13:08       ` BALATON Zoltan
2021-10-14 17:48         ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014091240.vif3nqeveddc6ru2@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=chenhuacai@kernel.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.