From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B6DC433FE for ; Thu, 14 Oct 2021 16:06:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77DF061056 for ; Thu, 14 Oct 2021 16:06:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 77DF061056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 15F458367C; Thu, 14 Oct 2021 18:06:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="McpwlBRg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2E774837A0; Thu, 14 Oct 2021 18:06:25 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DAD7883625 for ; Thu, 14 Oct 2021 18:06:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 7411F61130; Thu, 14 Oct 2021 16:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634227580; bh=4LhP+d7hm/LZFQkOPMwY0DQ3K35+jKjKjUK0UEJrh7M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=McpwlBRgkdm3DWlvvGAooKgAmebEG22xolKFuvKauu9WGIpouUmff9QA6f66f1s2R Uw1w2WL6ySDEBUXSjB6b0qUZaswsla2quJwH1QtaeOHTGvZ/Wtqq4JbckVfV453twc a5m/hvTBnD6G1dZyO0c0/bbGhu7bAIlaZ7osivqYEcJrT6SXFg+4xCNnR0LQyP/Ll0 mLc5hTwJiV7Cos4SyZH5BQqQ5v/rxU890nCFocKEK5pj0Y5WPvUqsBZxTknq6m4Xg6 Js80XiZ28dti2UiasmKTVXpOphcj6R9NJqgSatjE/c4ZH3xdpswO5j2SYLufZUbn31 HEYqfd4oirRmA== Date: Thu, 14 Oct 2021 18:06:15 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Simon Glass Cc: Tom Rini , U-Boot Mailing List , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH v2 04/13] env: Change env_match() to static and remove from header Message-ID: <20211014180615.0fe06083@dellmb> In-Reply-To: References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-5-kabel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 14 Oct 2021 09:11:08 -0600 Simon Glass wrote: > Hi Marek, >=20 > On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > > > From: Marek Beh=C3=BAn > > > > This function was used by other parts of U-Boot in the past when > > environment was read from underlying device one character at a time. > > > > This is not the case anymore. > > > > Signed-off-by: Marek Beh=C3=BAn > > --- > > cmd/nvedit.c | 30 +++++++++++++++--------------- > > include/env.h | 11 ----------- > > 2 files changed, 15 insertions(+), 26 deletions(-) > > > > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > > index ddc715b4f9..742e0924af 100644 > > --- a/cmd/nvedit.c > > +++ b/cmd/nvedit.c > > @@ -706,6 +706,21 @@ char *from_env(const char *envvar) > > return ret; > > } > > =20 >=20 > Please can you add the function comment here? We don't want to lose > it. Simon, the comment is invalid (the function does something different from what the comment says) and the function is only used as a helper by env_get_f(), which comes right after it. The function is refactored and renamend in subsequent patches, and its purpose seems obvious to me. Should I really leave the comment there? Marek