Re: [PATCH v10] drm/bridge: add it6505 driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3782 bytes --]

Hi allen,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/allen/drm-bridge-add-it6505-driver/20211014-113315
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 348949d9a4440abdab3b1dc99a9bb660e8c7da7c
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b7059f22f5a66e301596957d9c6321d64358d6f0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review allen/drm-bridge-add-it6505-driver/20211014-113315
        git checkout b7059f22f5a66e301596957d9c6321d64358d6f0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/ite-it6505.c: In function 'it6505_bridge_atomic_enable':
>> drivers/gpu/drm/bridge/ite-it6505.c:2919:22: error: implicit declaration of function 'drm_bridge_new_crtc_state'; did you mean 'drm_atomic_get_new_crtc_state'? [-Werror=implicit-function-declaration]
    2919 |         crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                      drm_atomic_get_new_crtc_state
>> drivers/gpu/drm/bridge/ite-it6505.c:2919:20: error: assignment to 'const struct drm_crtc_state *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
    2919 |         crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
         |                    ^
   cc1: all warnings being treated as errors


vim +2919 drivers/gpu/drm/bridge/ite-it6505.c

  2901	
  2902	static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
  2903						struct drm_bridge_state *old_state)
  2904	{
  2905		struct it6505 *it6505 = bridge_to_it6505(bridge);
  2906		struct device *dev = &it6505->client->dev;
  2907		struct drm_atomic_state *state = old_state->base.state;
  2908		struct hdmi_avi_infoframe frame;
  2909		const struct drm_crtc_state *crtc_state;
  2910		const struct drm_display_mode *mode;
  2911		struct drm_connector *connector;
  2912		int ret;
  2913	
  2914		DRM_DEV_DEBUG_DRIVER(dev, "start");
  2915	
  2916		connector = drm_atomic_get_new_connector_for_encoder(state,
  2917								     bridge->encoder);
  2918	
> 2919		crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
  2920		mode = &crtc_state->mode;
  2921		ret = drm_hdmi_avi_infoframe_from_display_mode(&frame,
  2922							       connector,
  2923							       mode);
  2924		if (ret)
  2925			dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
  2926	
  2927		it6505_update_video_parameter(it6505, mode);
  2928	
  2929		ret = it6505_send_video_infoframe(it6505, &frame);
  2930	
  2931		if (ret)
  2932			dev_err(dev, "Failed to send AVI infoframe: %d", ret);
  2933	
  2934		it6505_int_mask_enable(it6505);
  2935		it6505_video_reset(it6505);
  2936	}
  2937	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61053 bytes --]