From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD610C433EF for ; Fri, 15 Oct 2021 12:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95D3961090 for ; Fri, 15 Oct 2021 12:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239139AbhJOMvt (ORCPT ); Fri, 15 Oct 2021 08:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239135AbhJOMvm (ORCPT ); Fri, 15 Oct 2021 08:51:42 -0400 Received: from mail.fris.de (mail.fris.de [IPv6:2a01:4f8:c2c:390b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B1A6C061769; Fri, 15 Oct 2021 05:49:36 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 487F4BFBCC; Fri, 15 Oct 2021 14:49:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1634302174; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=8lm9gsabnoEYqTgKZqukYHlfOlUcDx4Taw7hbxvkE1k=; b=w25PoQ4x0Y24OkCpbgSjF3j1j5aK06mr9VRzWv/9oF4l7gwyZnsnZb4/pPuUBP8QViLjJz TmfqSukyj5mVgAvFVEWGb7nc49edLWlzIE6kJfb9fSnUnVCsSWPpqbYFGoo/xsh+2UyM9u S3egVukF1ECdl3szDwe1PD5S8u6HEA6Cl3cg+Ewf3TJZoEvUYNv9d6vc9RgEzh5SjgtfhA EBBqF/idvQesqjP7gVKhaIhC0VzolWkGEBoxn27Ya4xQYMcwL9r2a3tQQkb4aoKnA7nHUp Q35r0jZKy9DdakVHQQMaTDEKIZkGlkrsNFjd8hzf2Nyl1tm8rf2+gum5ZsK0Pw== From: Frieder Schrempf To: devicetree@vger.kernel.org, Frieder Schrempf , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Shawn Guo Cc: stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: [PATCH v2 6/6] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Date: Fri, 15 Oct 2021 14:48:40 +0200 Message-Id: <20211015124841.28226-7-frieder@fris.de> In-Reply-To: <20211015124841.28226-1-frieder@fris.de> References: <20211015124841.28226-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf Previously we falsely relied on the PHY driver to unconditionally enable the internal RX delay. Since the following fix for the PHY driver this is not the case anymore: commit 7b005a1742be ("net: phy: mscc: configure both RX and TX internal delays for RGMII") In order to enable the delay we need to set the connection type to "rgmii-rxid". Without the RX delay the ethernet is not functional at all. Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Cc: stable@vger.kernel.org Signed-off-by: Frieder Schrempf --- Changes in v2: * Fix the commit ref in the Fixes tag * Extend the commit message to make clear that ethernet is not working without this fix. --- arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts index 14263cd40daf..41ddaf980e14 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts @@ -113,7 +113,7 @@ &ecspi3 { &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-connection-type = "rgmii"; + phy-connection-type = "rgmii-rxid"; phy-handle = <ðphy>; status = "okay"; -- 2.33.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA76C433EF for ; Fri, 15 Oct 2021 12:52:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEEAA60ED4 for ; Fri, 15 Oct 2021 12:52:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BEEAA60ED4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=fris.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=idExwyDnswR804FWoogYUr6Ul0q9aZyaGpBJOfl+/Po=; b=dVDMUIOyOQMBCX Z9t7Fz8cGE8FBOO0wWx9OP44gQPCzOJTi/VTOlcoZP5dfiQCKZyU8LOC34ByCQ1Gi3Cg1+awfI9BY TszhJMgWDVbz+Vm7EpCcOmcES8yGOa1tBrWjfSdRtouefQOOUPbN6kc8Wzn17+jzjxFc/Uz1Vt+m2 SuNb4Q0RqWx+VCzf6Uc0PU1RxmaP1MEVI9BdIo6j90qLfb6RqvPjDJdBib4zS920QUn7q82abk34t f8NfMKO3sJFGhexByHOni5wTu0weOTxG3c5x94PMM7SyMmiM9oj4D4lDlIXvUUGMlDJ6h57ImcMqf y+X31as6eAaV1VQYA6BQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbMgF-00719e-DD; Fri, 15 Oct 2021 12:51:23 +0000 Received: from mail.fris.de ([2a01:4f8:c2c:390b::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbMeW-0070Fs-ES for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 12:49:37 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 487F4BFBCC; Fri, 15 Oct 2021 14:49:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1634302174; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=8lm9gsabnoEYqTgKZqukYHlfOlUcDx4Taw7hbxvkE1k=; b=w25PoQ4x0Y24OkCpbgSjF3j1j5aK06mr9VRzWv/9oF4l7gwyZnsnZb4/pPuUBP8QViLjJz TmfqSukyj5mVgAvFVEWGb7nc49edLWlzIE6kJfb9fSnUnVCsSWPpqbYFGoo/xsh+2UyM9u S3egVukF1ECdl3szDwe1PD5S8u6HEA6Cl3cg+Ewf3TJZoEvUYNv9d6vc9RgEzh5SjgtfhA EBBqF/idvQesqjP7gVKhaIhC0VzolWkGEBoxn27Ya4xQYMcwL9r2a3tQQkb4aoKnA7nHUp Q35r0jZKy9DdakVHQQMaTDEKIZkGlkrsNFjd8hzf2Nyl1tm8rf2+gum5ZsK0Pw== From: Frieder Schrempf To: devicetree@vger.kernel.org, Frieder Schrempf , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Shawn Guo Cc: stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: [PATCH v2 6/6] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Date: Fri, 15 Oct 2021 14:48:40 +0200 Message-Id: <20211015124841.28226-7-frieder@fris.de> In-Reply-To: <20211015124841.28226-1-frieder@fris.de> References: <20211015124841.28226-1-frieder@fris.de> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_054936_679809_5584C2B6 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Frieder Schrempf Previously we falsely relied on the PHY driver to unconditionally enable the internal RX delay. Since the following fix for the PHY driver this is not the case anymore: commit 7b005a1742be ("net: phy: mscc: configure both RX and TX internal delays for RGMII") In order to enable the delay we need to set the connection type to "rgmii-rxid". Without the RX delay the ethernet is not functional at all. Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Cc: stable@vger.kernel.org Signed-off-by: Frieder Schrempf --- Changes in v2: * Fix the commit ref in the Fixes tag * Extend the commit message to make clear that ethernet is not working without this fix. --- arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts index 14263cd40daf..41ddaf980e14 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts @@ -113,7 +113,7 @@ &ecspi3 { &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-connection-type = "rgmii"; + phy-connection-type = "rgmii-rxid"; phy-handle = <ðphy>; status = "okay"; -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel