From: Daniel Borkmann <daniel@iogearbox.net>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH iproute2 -next 2/4] ip, neigh: Fix up spacing in netlink dump
Date: Sat, 16 Oct 2021 00:53:17 +0200 [thread overview]
Message-ID: <20211015225319.2284-3-daniel@iogearbox.net> (raw)
In-Reply-To: <20211015225319.2284-1-daniel@iogearbox.net>
Fix up spacing to consistently add a single ' ' after an attribute has
been printed. Currently, it is a bit of a mix of before and after which
can lead to double spacing to be printed.
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
ip/ipneigh.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index b778de00..564e787c 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -235,7 +235,7 @@ static void print_neigh_state(unsigned int nud)
#define PRINT_FLAG(f) \
if (nud & NUD_##f) { \
nud &= ~NUD_##f; \
- print_string(PRINT_ANY, NULL, " %s", #f); \
+ print_string(PRINT_ANY, NULL, "%s ", #f); \
}
PRINT_FLAG(INCOMPLETE);
@@ -423,27 +423,27 @@ int print_neigh(struct nlmsghdr *n, void *arg)
fprintf(fp, "lladdr ");
print_color_string(PRINT_ANY, COLOR_MAC,
- "lladdr", "%s", lladdr);
+ "lladdr", "%s ", lladdr);
}
if (r->ndm_flags & NTF_ROUTER)
- print_null(PRINT_ANY, "router", " %s", "router");
+ print_null(PRINT_ANY, "router", "%s ", "router");
if (r->ndm_flags & NTF_PROXY)
- print_null(PRINT_ANY, "proxy", " %s", "proxy");
+ print_null(PRINT_ANY, "proxy", "%s ", "proxy");
if (r->ndm_flags & NTF_EXT_LEARNED)
- print_null(PRINT_ANY, "extern_learn", " %s ", "extern_learn");
+ print_null(PRINT_ANY, "extern_learn", "%s ", "extern_learn");
if (r->ndm_flags & NTF_OFFLOADED)
- print_null(PRINT_ANY, "offload", " %s", "offload");
+ print_null(PRINT_ANY, "offload", "%s ", "offload");
if (show_stats) {
if (tb[NDA_CACHEINFO])
print_cacheinfo(RTA_DATA(tb[NDA_CACHEINFO]));
if (tb[NDA_PROBES])
- print_uint(PRINT_ANY, "probes", " probes %u",
+ print_uint(PRINT_ANY, "probes", "probes %u ",
rta_getattr_u32(tb[NDA_PROBES]));
}
@@ -453,7 +453,7 @@ int print_neigh(struct nlmsghdr *n, void *arg)
if (protocol) {
SPRINT_BUF(b1);
- print_string(PRINT_ANY, "protocol", " proto %s ",
+ print_string(PRINT_ANY, "protocol", "proto %s ",
rtnl_rtprot_n2a(protocol, b1, sizeof(b1)));
}
--
2.27.0
next prev parent reply other threads:[~2021-10-15 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 22:53 [PATCH iproute2 -next 0/4] ip, neigh: Add managed neighbor support Daniel Borkmann
2021-10-15 22:53 ` [PATCH iproute2 -next 1/4] Update kernel headers Daniel Borkmann
2021-10-15 22:53 ` Daniel Borkmann [this message]
2021-10-15 22:53 ` [PATCH iproute2 -next 3/4] ip, neigh: Add missing NTF_USE support Daniel Borkmann
2021-10-16 0:18 ` David Ahern
2021-10-25 11:43 ` Daniel Borkmann
2021-10-15 22:53 ` [PATCH iproute2 -next 4/4] ip, neigh: Add NTF_EXT_MANAGED support Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015225319.2284-3-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.