From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84698C433FE for ; Sat, 16 Oct 2021 18:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A2F76115C for ; Sat, 16 Oct 2021 18:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244496AbhJPSHo (ORCPT ); Sat, 16 Oct 2021 14:07:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:42182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234167AbhJPSHm (ORCPT ); Sat, 16 Oct 2021 14:07:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C319D61152; Sat, 16 Oct 2021 18:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634407534; bh=pXmvpGnGkvZz3jdjF87zxFDCLAD5XPBvBSOagxWkGlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3bDKKx1Az+STi+APpA16lxxIDZL/bZnRM3bS2QupWWTlXAf8jYOjGboy6rT3n1mN FTWXJUvamV3FgxHwiAQJ23Rt/mgkTPX7lfuHv5o3nwMjK/jpbtXpFgT2OCUPwMtWYR W8uDxEebZpFEy3lEe85aPcBV+jzw8Qe0SkZO4RVEURCDCGTrgW+1rhCaD5PqV1cKjd x3OCllujqhmusolMkvyAKG6m/vBUETElNim+yUQ2IdPLIHYBCS7LdvyFEEK0js9P1T ZlIVAMMzCb19yvCQGNcZDVHseQKXI3KwPXHWvYwZYtv3o9UWjVcgD7G1aZsN1sQ2ew 2cPCea0Ovj+5g== Date: Sat, 16 Oct 2021 13:10:03 -0500 From: "Gustavo A. R. Silva" To: Mark Rutland Cc: jing yangyang , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot , linux-hardening@vger.kernel.org Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer Message-ID: <20211016181003.GA1193402@embeddedor> References: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> <20210824105824.GC96738@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824105824.GC96738@C02TD0UTHF1T.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote: > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote: > > sizeof when applied to a pointer typed expression gives the size of > > the pointer. > > > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer > > > > This issue was detected with the help of Coccinelle. > > > > Reported-by: Zeal Robot > > Signed-off-by: jing yangyang > > >From looking at the git history, we should add: > > Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" > > With that: > > Acked-by: Mark Rutland > > Lorenzo, how do we normally direct these patches? It seems that these patches are consistently being ignored[1][2][3]. So, I'll take this in my -next tree[4] before it gets lost again. Thanks -- Gustavo [1] https://lore.kernel.org/lkml/20200917081353.2083241-1-liushixin2@huawei.com/ [2] https://lore.kernel.org/lkml/1606179525-63938-1-git-send-email-tiantao6@hisilicon.com/ [3] https://lore.kernel.org/lkml/20211012024229.180058-1-davidcomponentone@gmail.com/ [4] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp-misc-fixes > > > > --- > > drivers/firmware/psci/psci_checker.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c > > index 9a369a2..116eb46 100644 > > --- a/drivers/firmware/psci/psci_checker.c > > +++ b/drivers/firmware/psci/psci_checker.c > > @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) > > if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) > > return -ENOMEM; > > > > - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups), > > + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups), > > GFP_KERNEL); > > if (!cpu_groups) { > > free_cpumask_var(tmp); > > -- > > 1.8.3.1 > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1B0C433F5 for ; Sat, 16 Oct 2021 18:07:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2075A60F46 for ; Sat, 16 Oct 2021 18:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2075A60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPOgf3GaP3KLrafIEVjcTu8Kr5mE9Nrq35rIw5PjPCM=; b=xn+zlfySHwQ0GX djA8i9MhSnhwUMHr5vCWpDH/ZsAzoRyTUVkAQUNrRQr4w5L6+5+4jDz1FplOuPZ9qKrhcY+7UX2fR TTLm6N0ZBoJYFEP6S9SVDy98qk/TqwyisE97wT6XXAZes2pOC+0Bbvp6XEbmnJOf2hstMxCkFgnS/ N/hewuH4pFBkAR3GWARkPbgbj4dvD0Qs3o6wRsKYfQglVGCwgCvJpEMi2SkNszkIOSvp+nFWdsxto 3giqxlDvC3TzPAEZ/nPnIkEhOFMOlTxOUFTGNysXWK0kaKf4rzu8OwFSQhV7DzD/kJuq7KZDweXS+ AztkK3fD/nAio48ujl4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbo3w-00B5Ou-1P; Sat, 16 Oct 2021 18:05:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbo3r-00B5OA-Us for linux-arm-kernel@lists.infradead.org; Sat, 16 Oct 2021 18:05:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C319D61152; Sat, 16 Oct 2021 18:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634407534; bh=pXmvpGnGkvZz3jdjF87zxFDCLAD5XPBvBSOagxWkGlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3bDKKx1Az+STi+APpA16lxxIDZL/bZnRM3bS2QupWWTlXAf8jYOjGboy6rT3n1mN FTWXJUvamV3FgxHwiAQJ23Rt/mgkTPX7lfuHv5o3nwMjK/jpbtXpFgT2OCUPwMtWYR W8uDxEebZpFEy3lEe85aPcBV+jzw8Qe0SkZO4RVEURCDCGTrgW+1rhCaD5PqV1cKjd x3OCllujqhmusolMkvyAKG6m/vBUETElNim+yUQ2IdPLIHYBCS7LdvyFEEK0js9P1T ZlIVAMMzCb19yvCQGNcZDVHseQKXI3KwPXHWvYwZYtv3o9UWjVcgD7G1aZsN1sQ2ew 2cPCea0Ovj+5g== Date: Sat, 16 Oct 2021 13:10:03 -0500 From: "Gustavo A. R. Silva" To: Mark Rutland Cc: jing yangyang , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot , linux-hardening@vger.kernel.org Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer Message-ID: <20211016181003.GA1193402@embeddedor> References: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> <20210824105824.GC96738@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210824105824.GC96738@C02TD0UTHF1T.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211016_110536_044843_F177E251 X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote: > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote: > > sizeof when applied to a pointer typed expression gives the size of > > the pointer. > > > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer > > > > This issue was detected with the help of Coccinelle. > > > > Reported-by: Zeal Robot > > Signed-off-by: jing yangyang > > >From looking at the git history, we should add: > > Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" > > With that: > > Acked-by: Mark Rutland > > Lorenzo, how do we normally direct these patches? It seems that these patches are consistently being ignored[1][2][3]. So, I'll take this in my -next tree[4] before it gets lost again. Thanks -- Gustavo [1] https://lore.kernel.org/lkml/20200917081353.2083241-1-liushixin2@huawei.com/ [2] https://lore.kernel.org/lkml/1606179525-63938-1-git-send-email-tiantao6@hisilicon.com/ [3] https://lore.kernel.org/lkml/20211012024229.180058-1-davidcomponentone@gmail.com/ [4] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp-misc-fixes > > > > --- > > drivers/firmware/psci/psci_checker.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c > > index 9a369a2..116eb46 100644 > > --- a/drivers/firmware/psci/psci_checker.c > > +++ b/drivers/firmware/psci/psci_checker.c > > @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) > > if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) > > return -ENOMEM; > > > > - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups), > > + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups), > > GFP_KERNEL); > > if (!cpu_groups) { > > free_cpumask_var(tmp); > > -- > > 1.8.3.1 > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel