From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDC7C433EF for ; Mon, 18 Oct 2021 13:37:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2925A61372 for ; Mon, 18 Oct 2021 13:37:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2925A61372 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7477807D7; Mon, 18 Oct 2021 15:37:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kcghOwA4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D25180691; Mon, 18 Oct 2021 15:37:35 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E3334807D7 for ; Mon, 18 Oct 2021 15:37:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id 77so15312302qkh.6 for ; Mon, 18 Oct 2021 06:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iE+ybdXoJTvi+3Ecw0/nkfwNoezwOtI/HgCOFKD+0pw=; b=kcghOwA4F4B0iVL2hnPn/FDlWaud97VOO+MQyrIZZPTM8rPgCYSJD9RvYf9qDJ8XCo ZONp6KlIU4xXWIJlCQCIr9NDqIcX836vxqkB7PZlNty3tnjhYgTZx2fufqf7AhX2jJ3e 1TCsHB+LyY+AKYfMFlH7aVgFvaisQAegluqvg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iE+ybdXoJTvi+3Ecw0/nkfwNoezwOtI/HgCOFKD+0pw=; b=UdsZIChJe/h0lmD0paOT35qEH+aM8ihXxToCTi95RtrEu2sw8EuhwiUVnl+YLftzY2 CmchE99p+0fueCl7TpswW21NFAa8/PK6KFwUMkIBOM0jKVb8Eu0GzjERRCbm88qUyMWv pKbzgJKAxmnSi1qeoefgN/gwAtPG9njjtExFpYrbSrRPabcyaPn6WIU77jVMJXaQI9oX Bgc5l2dE+60Y9Y2j1ILa9kxYspSWotvg6WYURiRf2c3J+8Rz9o0cU6bqf+YYDWHi5SD3 UBBEz025ZePqYl4Ws2dw4yDxG3XQc9GWtrqVBtbndOnFhZYYXN3R3CAhO9naatsfLf0Z dXLQ== X-Gm-Message-State: AOAM533sXM4JBH72/7HxYCgE8BwwLyqjoBkMkIEPlz2w5kOt5kVnyVBk /7HLNiPC3nXpZxzGmXgt8uoHMg== X-Google-Smtp-Source: ABdhPJw+Ldwnj7P/bTwV26rRLKJ65DAGMKQ5lNPKs8LmeDb0yvfG6l10hsruVH3Qvasntpar527nTw== X-Received: by 2002:a05:620a:424f:: with SMTP id w15mr22683323qko.258.1634564250618; Mon, 18 Oct 2021 06:37:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-69f2-e962-b8f3-4396.res6.spectrum.com. [2603:6081:7b01:cbda:69f2:e962:b8f3:4396]) by smtp.gmail.com with ESMTPSA id s12sm34438qki.12.2021.10.18.06.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 06:37:29 -0700 (PDT) Date: Mon, 18 Oct 2021 09:37:28 -0400 From: Tom Rini To: Wolfgang Denk Cc: Simon Glass , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211018133728.GQ7964@bill-the-cat> References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ltaNo38lfiiImPbJ" Content-Disposition: inline In-Reply-To: <3496103.1634558337@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ltaNo38lfiiImPbJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2021 at 01:58:57PM +0200, Wolfgang Denk wrote: > Dear Simon, >=20 > In message you wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html > > > > Yes I saw that but I forgot to look at it. I think it makes sense - we > > do that with devicetree, for example. > > > > Is that the only thing holding you back? >=20 > Basically yes - the only other concerns I have is about this +=3D > construct which makes the '+' character an illegal character for > environment variable names, but only when used at the end of the > variable. This is anything but nice or consistent. Iwonder what > happens with notations like these: >=20 > foo+=3Dbar -> "bar" gets appended to current value of "foo" > But what for: > foo\+=3Dbar > or > foo+ =3D bar >=20 > ? >=20 > And please see also my comments about changing the autostart > functionality for the user. Perhaps we should just make "+" an illegal character in the variable name, for consistency? > > I haven't seen any positive comments to this series yet... >=20 > Maybe many long-term users of U-Boot don't see the current situation > as such a big problem? I have no idea. Considering the number of external to U-Boot projects for dealing with the environment in U-Boot, I don't think that's the case. Simon, perhaps it's worth poking some of those people off-list with a pointer to your series? Something like this should make integration much easier, for most of the existing OTA solutions that support U-Boot. It should also make it easier for OE/buildroot/etc to explain to users how to modify the environment as well. --=20 Tom --ltaNo38lfiiImPbJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFteEoACgkQFHw5/5Y0 tyxqiQwAqlxavLpybiEOnTfgGvjWWpyzmjXXU5y8t9Lqh+DPIRcKkNWMEzJjryfx CKe9Gw0XwW6GoYLwinU/zdqb7UADrq20+oRmtaEZH9OYRkO2y7676f6MOqR83eCD 83YMuKCTw0roNq2piUwTXP0wuFTv8hRS2r1qG9z/aH/VS1+UhUck2xQOzmGSBsmj Kl1QZF4+BEyMGrDZ7sG7/h324JsYdG5q6v8fCZ8DQ2RMw/SWS1+CalDI4cA1ZePP oJ37wAT/vtwHSeBTeAuQQPO8t5nh45osPutS52G43ahvzoLQJRCkJbuSAGnQkiVT bdqWu0vV20kiC2a6k6t5zN98CEQOpCHARwE0W4O/gGlmo8srmMX//6/7PbmL3elR VTdvzXtc2P1pcsP2zTSzKoN125rQHuFWJIwwit3j3GeVqcpaHPH2Vr6l+HVCxkOv oo7uCJU/ucGoLmhScGVufRlpiuiWaHieENIFwaQNg5/VXauxgQInN+y0246yfTrt mdoUUzh6 =qikF -----END PGP SIGNATURE----- --ltaNo38lfiiImPbJ--