All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	jing yangyang <cgel.zte@gmail.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	jing yangyang <jing.yangyang@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
Date: Mon, 18 Oct 2021 14:54:21 +0100	[thread overview]
Message-ID: <20211018135421.gnjbkuvrmjep2odz@bogus> (raw)
In-Reply-To: <20211016181003.GA1193402@embeddedor>

On Sat, Oct 16, 2021 at 01:10:03PM -0500, Gustavo A. R. Silva wrote:
> On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote:
> > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> > > sizeof when applied to a pointer typed expression gives the size of
> > > the pointer.
> > > 
> > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
> > > 
> > > This issue was detected with the help of Coccinelle.
> > > 
> > > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> > 
> > >From looking at the git history, we should add:
> > 
> >   Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
> > 
> > With that:
> > 
> >   Acked-by: Mark Rutland <mark.rutland@arm.com>
> > 
> > Lorenzo, how do we normally direct these patches?
> 
> It seems that these patches are consistently being ignored[1][2][3]. So,

Sorry for that. Sometime it does happen. Anyways thanks for reminding about
it.

> I'll take this in my -next tree[4] before it gets lost again.

Mark has already acked it, so you can take it via your tree if you are OK.

We generally ask the author to post to soc@kernel.org for one of patches
like this when we don't have any plans to send PR to SoC team so that they
can apply the patch directly.

So it should be fine if you prefer to pick up and send to SoC team or we
can resend the patch to them and ask to apply. Let us know.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	jing yangyang <cgel.zte@gmail.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	jing yangyang <jing.yangyang@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
Date: Mon, 18 Oct 2021 14:54:21 +0100	[thread overview]
Message-ID: <20211018135421.gnjbkuvrmjep2odz@bogus> (raw)
In-Reply-To: <20211016181003.GA1193402@embeddedor>

On Sat, Oct 16, 2021 at 01:10:03PM -0500, Gustavo A. R. Silva wrote:
> On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote:
> > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> > > sizeof when applied to a pointer typed expression gives the size of
> > > the pointer.
> > > 
> > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
> > > 
> > > This issue was detected with the help of Coccinelle.
> > > 
> > > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> > 
> > >From looking at the git history, we should add:
> > 
> >   Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
> > 
> > With that:
> > 
> >   Acked-by: Mark Rutland <mark.rutland@arm.com>
> > 
> > Lorenzo, how do we normally direct these patches?
> 
> It seems that these patches are consistently being ignored[1][2][3]. So,

Sorry for that. Sometime it does happen. Anyways thanks for reminding about
it.

> I'll take this in my -next tree[4] before it gets lost again.

Mark has already acked it, so you can take it via your tree if you are OK.

We generally ask the author to post to soc@kernel.org for one of patches
like this when we don't have any plans to send PR to SoC team so that they
can apply the patch directly.

So it should be fine if you prefer to pick up and send to SoC team or we
can resend the patch to them and ask to apply. Let us know.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-18 13:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  2:30 [PATCH linux-next] firmware/psci: fix application of sizeof to pointer jing yangyang
2021-08-20  2:30 ` jing yangyang
2021-08-24 10:58 ` Mark Rutland
2021-08-24 10:58   ` Mark Rutland
2021-10-16 18:10   ` Gustavo A. R. Silva
2021-10-16 18:10     ` Gustavo A. R. Silva
2021-10-18 13:54     ` Sudeep Holla [this message]
2021-10-18 13:54       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211018135421.gnjbkuvrmjep2odz@bogus \
    --to=sudeep.holla@arm.com \
    --cc=cgel.zte@gmail.com \
    --cc=gustavoars@kernel.org \
    --cc=jing.yangyang@zte.com.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.