From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E626C433EF for ; Mon, 18 Oct 2021 13:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 282C860EFE for ; Mon, 18 Oct 2021 13:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233600AbhJRN7D (ORCPT ); Mon, 18 Oct 2021 09:59:03 -0400 Received: from foss.arm.com ([217.140.110.172]:38522 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232380AbhJRN4h (ORCPT ); Mon, 18 Oct 2021 09:56:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD8A1101E; Mon, 18 Oct 2021 06:54:25 -0700 (PDT) Received: from bogus (unknown [10.57.25.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E356D3F73D; Mon, 18 Oct 2021 06:54:23 -0700 (PDT) Date: Mon, 18 Oct 2021 14:54:21 +0100 From: Sudeep Holla To: "Gustavo A. R. Silva" Cc: Mark Rutland , jing yangyang , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot , linux-hardening@vger.kernel.org Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer Message-ID: <20211018135421.gnjbkuvrmjep2odz@bogus> References: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> <20210824105824.GC96738@C02TD0UTHF1T.local> <20211016181003.GA1193402@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211016181003.GA1193402@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 16, 2021 at 01:10:03PM -0500, Gustavo A. R. Silva wrote: > On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote: > > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote: > > > sizeof when applied to a pointer typed expression gives the size of > > > the pointer. > > > > > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer > > > > > > This issue was detected with the help of Coccinelle. > > > > > > Reported-by: Zeal Robot > > > Signed-off-by: jing yangyang > > > > >From looking at the git history, we should add: > > > > Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" > > > > With that: > > > > Acked-by: Mark Rutland > > > > Lorenzo, how do we normally direct these patches? > > It seems that these patches are consistently being ignored[1][2][3]. So, Sorry for that. Sometime it does happen. Anyways thanks for reminding about it. > I'll take this in my -next tree[4] before it gets lost again. Mark has already acked it, so you can take it via your tree if you are OK. We generally ask the author to post to soc@kernel.org for one of patches like this when we don't have any plans to send PR to SoC team so that they can apply the patch directly. So it should be fine if you prefer to pick up and send to SoC team or we can resend the patch to them and ask to apply. Let us know. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFFBC433EF for ; Mon, 18 Oct 2021 13:56:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00EB860EE3 for ; Mon, 18 Oct 2021 13:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00EB860EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NaNs42K/DmOXKDsxogIaXtQNJdoTKSw/Moyg98k+XbE=; b=jEA4bbv5GTuEBt suOQgmUd12oTUVpLvNCSjOq4AA4lDsJ6bQe+L/e3otmGSOrotV5/7aOs6Pcw2cxNFdpLeD7QKKqvx dfTZ8oR3X0mH9yN8KGA/rafme0pfPI/rXHGpjdqYZbfORf8TC6BeVI+nrYLqdZ0cocJV2UnYa45CR ubZCXhJpyStk1UZFOVK1TJGXWOulplhWZwKca3X8XJl1QOm2BDMnRYnezAPXrPEYYrlP6xFaT85ZP 4UoGiHu/ooLt0IDIXXPqtNw/TfAC0GtpgTC76r7W5YHuF8YnCw5PWnUa/SMzPO7iIOjJZ4LqZbrWW 0aICSc6FoVycPenRco3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcT6P-00Fve7-TV; Mon, 18 Oct 2021 13:54:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcT5x-00FvVA-1q for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 13:54:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD8A1101E; Mon, 18 Oct 2021 06:54:25 -0700 (PDT) Received: from bogus (unknown [10.57.25.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E356D3F73D; Mon, 18 Oct 2021 06:54:23 -0700 (PDT) Date: Mon, 18 Oct 2021 14:54:21 +0100 From: Sudeep Holla To: "Gustavo A. R. Silva" Cc: Mark Rutland , jing yangyang , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot , linux-hardening@vger.kernel.org Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer Message-ID: <20211018135421.gnjbkuvrmjep2odz@bogus> References: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> <20210824105824.GC96738@C02TD0UTHF1T.local> <20211016181003.GA1193402@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211016181003.GA1193402@embeddedor> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_065429_181254_8E1E4FAE X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 16, 2021 at 01:10:03PM -0500, Gustavo A. R. Silva wrote: > On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote: > > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote: > > > sizeof when applied to a pointer typed expression gives the size of > > > the pointer. > > > > > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer > > > > > > This issue was detected with the help of Coccinelle. > > > > > > Reported-by: Zeal Robot > > > Signed-off-by: jing yangyang > > > > >From looking at the git history, we should add: > > > > Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" > > > > With that: > > > > Acked-by: Mark Rutland > > > > Lorenzo, how do we normally direct these patches? > > It seems that these patches are consistently being ignored[1][2][3]. So, Sorry for that. Sometime it does happen. Anyways thanks for reminding about it. > I'll take this in my -next tree[4] before it gets lost again. Mark has already acked it, so you can take it via your tree if you are OK. We generally ask the author to post to soc@kernel.org for one of patches like this when we don't have any plans to send PR to SoC team so that they can apply the patch directly. So it should be fine if you prefer to pick up and send to SoC team or we can resend the patch to them and ask to apply. Let us know. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel