From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B78AC433F5 for ; Mon, 18 Oct 2021 14:24:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEE960F46 for ; Mon, 18 Oct 2021 14:24:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BEE960F46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3CDB782C45; Mon, 18 Oct 2021 16:24:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hvhpOtuM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3D03829FC; Mon, 18 Oct 2021 16:24:12 +0200 (CEST) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C590B82C45 for ; Mon, 18 Oct 2021 16:24:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id o12so15376389qtq.7 for ; Mon, 18 Oct 2021 07:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XMzmcGrACHReazmPssSAo9QS70Y3vSL6oh4hqA2jwmM=; b=hvhpOtuMB7R9xIoIz/YjBRbaBGyJuserc9oOZpdkMViLdfuy3iemfb0ySiPq9mSfYj aVF0NsJGo7xfkvAzRfS6alBgZ69tMJ+gWhnjM3onW/ME/+Mvg8ljdoS8mwTzRe9zS+BI fFrZLX+LBY+P0RQ2HwWjXjkNU80eQlEGIej2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XMzmcGrACHReazmPssSAo9QS70Y3vSL6oh4hqA2jwmM=; b=RMrVbiqlCjTySd8UNYBafuOhb3WP2mTnkjZhKGBgh3jTZ/sZ661D74UyVUyesUI26g RwLrSFXDdsewpSVPZPHz4il1NCnS4vde+HppJX/E/96UdpUVUNyZxh8qnPNDU8mkGtJa jSwVMo5lns0uFkdNZ9nslT6298zQf08eRwGy4xYpot9DK/fmctl0p0eJC+omcHGWsXSI qsOfhOV5LEVltY8fgLETRCMHH5qJPGlE5gXxp7r5O2D6VvnyHC5Re4k69maXjIWkp7OR Zos4PK0T1Om0WmDfHxwANWEmh5bCuQ6aR5BtBTe2Pi3IeaQYonusczzXBx2U0pJ4lhg2 p9GA== X-Gm-Message-State: AOAM532JhwLityt87hCuDxklAL4adOW9qZE0jBW5lh31KgQPW5W4nAc2 teOcYyeZAzFj4lBbpBH+EcnCFw== X-Google-Smtp-Source: ABdhPJzGXNOB/CndVE1ygT0sdKCF+liBgsgp5/qq4KhhOtUbjCWzthh9ctKuH1CkwmkdatMrixfRiA== X-Received: by 2002:ac8:7f4a:: with SMTP id g10mr30519613qtk.150.1634567046498; Mon, 18 Oct 2021 07:24:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-69f2-e962-b8f3-4396.res6.spectrum.com. [2603:6081:7b01:cbda:69f2:e962:b8f3:4396]) by smtp.gmail.com with ESMTPSA id e3sm133539qte.81.2021.10.18.07.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 07:24:05 -0700 (PDT) Date: Mon, 18 Oct 2021 10:24:04 -0400 From: Tom Rini To: Wolfgang Denk Cc: Simon Glass , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211018142404.GR7964@bill-the-cat> References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <20211018133728.GQ7964@bill-the-cat> <3502270.1634566234@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="43jPyo9iAuplmNDj" Content-Disposition: inline In-Reply-To: <3502270.1634566234@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --43jPyo9iAuplmNDj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2021 at 04:10:34PM +0200, Wolfgang Denk wrote: > Dear Tom, >=20 > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > >=20 > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal character in the variable > > name, for consistency? >=20 > And break backward compatibility? I'd rather see a better > definition of the syntax of the environment files, plus maybe a more > powerful parser. Are there examples today of scripts that use "+" in the variable names? That maybe someone wrote a custom an private thing that uses + in the name isn't the best argument. Someone saying that did would be better. > I mean, there is no technical reason to forbid the '+' character - > and then it's only at the end of the variable name. Of course yes, if we can just make the parser handle it, without it also being a tricky nightmare, that's the better solution. > Hm... I can't find it right now but did I not also read about other > restrictions to variable names, like they must noch begin with '_' > when using this new tool? Any invalid characters need to be clearly documented, if they aren't, yes. > I feel it is wrong to place new restrictions on something that was > constant for 21 years, just because our parser cannot parse it... Sure. But if it's also the case that for 21 years no one has been using foo+bar, baz+, etc, in their variable names, maybe we just document that's not valid and move on? --=20 Tom --43jPyo9iAuplmNDj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFtg4AACgkQFHw5/5Y0 tyxjfAv9Hsgc2aF/1ZPDuWVrjZWGZFGs90TZ5vdeDO7fvwCEReIGyT5B/3Vj4Fnw XYzNykSrROZYbbqXo9eBmhGoi2Uu/QMWNed/aqntXa+upYq2ke5Kj6cn/DLff3d1 lYcPf2JM1eRb8K8MV8U8A2IzSyBazXQc2ICMR02SK4FyRURQq9RxvBiXU0YAX737 uG5n2fsYDCaNnOb7A2KtCUSTsf1LaP3r7nW/+rPdq7/p1FJUqftqPRKvhU7fcH3D fahFuJFPlfLbQG/e6FGVYb4rY8FnE67zXYSn7kEMwnunafPmIktWCOcvefCI11sO KWpd8O+O45kMP3p/nPm7ckU0R7WjxZJ6Z4G6e7nkc8AETwcKoXRPa9KJAwkgmZfi JOCLT1VXY9vMhwlMI9rdZSFLFuR/7JcCFXdbK6TQxTREPI++DlMfhhbJzlngkT3M zCIycFWzmouiS+Ays49/bZBa3v0xbLKZ5WRyTakGdl6C/Z/vXV1bEYeadsnhRvWi alFs5Sak =1UaH -----END PGP SIGNATURE----- --43jPyo9iAuplmNDj--