All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build
@ 2021-10-17 20:05 Fabrice Fontaine
  2021-10-18 19:52 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-10-17 20:05 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni, Asaf Kahlon

Fix the following build failure raised since commit
21a56f9edbca8dd8b19567be6be2b32e44ebb860 which wrongly removed
the select on BR2_PACKAGE_BZIP2 from BR2_PACKAGE_PYTHON3_BZIP2:

Makefile:587: *** bzip2 is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/041a2f9c536fce1a1acf6da0464855e4f1e1604f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/python3/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python3/Config.in b/package/python3/Config.in
index 18b6d6367b..efc4dbb3d4 100644
--- a/package/python3/Config.in
+++ b/package/python3/Config.in
@@ -54,6 +54,7 @@ config BR2_PACKAGE_PYTHON3_BERKELEYDB
 
 config BR2_PACKAGE_PYTHON3_BZIP2
 	bool "bz2 module"
+	select BR2_PACKAGE_BZIP2
 	help
 	  bzip2 module for Python3
 
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build
  2021-10-17 20:05 [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build Fabrice Fontaine
@ 2021-10-18 19:52 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-10-18 19:52 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Adam Duskett, Asaf Kahlon, buildroot

On Sun, 17 Oct 2021 22:05:58 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since commit
> 21a56f9edbca8dd8b19567be6be2b32e44ebb860 which wrongly removed
> the select on BR2_PACKAGE_BZIP2 from BR2_PACKAGE_PYTHON3_BZIP2:
> 
> Makefile:587: *** bzip2 is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/041a2f9c536fce1a1acf6da0464855e4f1e1604f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/python3/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Indeed, there's been a misunderstanding. Arnout asked to drop the
"select BR2_PACKAGE_HOST_BZIP2" from package/python3/Config.in.host,
but Adam removed the "select BR2_PACKAGE_BZIP2" from
package/python3/Config.in instead, and Arnout didn't spot the mistake
when applying.

Anyway, I've applied your patch, and did another to drop the bogus
select BR2_PACKAGE_HOST_BZIP2. Thanks for fixing this!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-18 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-17 20:05 [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build Fabrice Fontaine
2021-10-18 19:52 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.