All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT_CALL support
Date: Mon, 18 Oct 2021 22:06:52 -0400	[thread overview]
Message-ID: <20211018220652.014c12a0@gandalf.local.home> (raw)
In-Reply-To: <YWadVEtwt8+mWsWo@osiris>

On Wed, 13 Oct 2021 10:48:20 +0200
Heiko Carstens <hca@linux.ibm.com> wrote:

> On Tue, Oct 12, 2021 at 08:25:14PM +0200, Heiko Carstens wrote:
> > On Tue, Oct 12, 2021 at 07:04:53PM +0200, Jiri Olsa wrote:  
> > > > > See here:
> > > > > 
> > > > >   https://lore.kernel.org/all/20211008091336.33616-1-jolsa@kernel.org/  
> > > > 
> > > > I applied Jiri's patch set and the newly added selftest passes.  
> > > 
> > > nice, could I have your Tested-by? ;-)  
> > 
> > Well, now I added also the missing pieces to ftrace-direct-multi
> > sample module and when loading that and looking into
> > /sys/kernel/debug/tracing/trace it looks like "my_direct_func" gets
> > some random junk as parameter and nothing that could count as "ip".
> > 
> > Will look into that, probably tomorrow.  
> 
> Ok, if I load the correct module, it even works. I had a bug in the
> first version, fixed it, but still loaded the broken module to test
> my changes. Clever me ;)
> 
> So it all works for me.

BTW, in case you need my ack:

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

for the series.

-- Steve

      reply	other threads:[~2021-10-19  2:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 13:37 [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT_CALL support Heiko Carstens
2021-10-12 13:37 ` [PATCH 1/4] s390/ftrace: add HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALL support Heiko Carstens
2021-10-12 13:38 ` [PATCH 2/4] s390: make STACK_FRAME_OVERHEAD available via asm-offsets.h Heiko Carstens
2021-10-12 13:38 ` [PATCH 3/4] samples: add HAVE_SAMPLE_FTRACE_DIRECT config option Heiko Carstens
2021-10-12 13:38 ` [PATCH 4/4] samples: add s390 support for ftrace direct call samples Heiko Carstens
2021-10-12 13:48 ` [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT_CALL support Steven Rostedt
2021-10-12 14:59   ` Heiko Carstens
2021-10-12 15:34     ` Steven Rostedt
2021-10-12 17:18       ` Heiko Carstens
2021-10-12 17:04     ` Jiri Olsa
2021-10-12 18:25       ` Heiko Carstens
2021-10-13  8:48         ` Heiko Carstens
2021-10-19  2:06           ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211018220652.014c12a0@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bp@alien8.de \
    --cc=hca@linux.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.