Re: [PATCH v2 1/2] virtio_ring: fix style of virtqueue_add_indirect_packed

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Oct 19, 2021 at 04:15:41PM +0800, Xuan Zhuo wrote:
> On Tue, 28 Sep 2021 11:14:47 +0800, Jason Wang <jasowang@redhat.com> wrote:
> > On Mon, Sep 27, 2021 at 6:54 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > >
> > > Fix the style problem of virtqueue_add_indirect_packed(). The next patch
> > > involves the modification of this function.
> > >
> > > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > > ---
> > >  drivers/virtio/virtio_ring.c | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Acked-by: Jason Wang <jasowang@redhat.com>
> 
> Hi, this patch set seems to have not been merged, is there something wrong with me?
> 
> Thanks.

there's no problem as such. something like

"align arguments to the open ( to make it look prettier"
would be more correct.


> >
> > >
> > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> > > index dd95dfd85e98..91a46c4da87d 100644
> > > --- a/drivers/virtio/virtio_ring.c
> > > +++ b/drivers/virtio/virtio_ring.c
> > > @@ -1050,12 +1050,12 @@ static struct vring_packed_desc *alloc_indirect_packed(unsigned int total_sg,
> > >  }
> > >
> > >  static int virtqueue_add_indirect_packed(struct vring_virtqueue *vq,
> > > -                                      struct scatterlist *sgs[],
> > > -                                      unsigned int total_sg,
> > > -                                      unsigned int out_sgs,
> > > -                                      unsigned int in_sgs,
> > > -                                      void *data,
> > > -                                      gfp_t gfp)
> > > +                                        struct scatterlist *sgs[],
> > > +                                        unsigned int total_sg,
> > > +                                        unsigned int out_sgs,
> > > +                                        unsigned int in_sgs,
> > > +                                        void *data,
> > > +                                        gfp_t gfp)
> > >  {
> > >         struct vring_packed_desc *desc;
> > >         struct scatterlist *sg;
> > > --
> > > 2.31.0
> > >
> >

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization