From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C567C433EF for ; Tue, 19 Oct 2021 07:23:38 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5525611EF for ; Tue, 19 Oct 2021 07:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A5525611EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6237860A69; Tue, 19 Oct 2021 07:23:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CoMwxm7rA0Qo; Tue, 19 Oct 2021 07:23:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1EF90606EA; Tue, 19 Oct 2021 07:23:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E7164C000F; Tue, 19 Oct 2021 07:23:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8D3F7C000D for ; Tue, 19 Oct 2021 07:23:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6D617402DD for ; Tue, 19 Oct 2021 07:23:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BZ8gvcsGJxK0 for ; Tue, 19 Oct 2021 07:23:32 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4AB0F40233 for ; Tue, 19 Oct 2021 07:23:32 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: , linux-xfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, To-header@lst.de, Mike Snitzer , nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, no@lst.de, on@lst.de, virtualization@lists.linux-foundation.org, "input <"@lst.de, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 181F772 for ; Tue, 19 Oct 2021 07:23:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , no@lst.de, To-header@lst.de, on@lst.de, "input <"@lst.de;, Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA80C433EF for ; Tue, 19 Oct 2021 07:28:13 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADEDC61378 for ; Tue, 19 Oct 2021 07:28:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADEDC61378 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-v30h-F8CNcOwyertlQKivQ-1; Tue, 19 Oct 2021 03:28:07 -0400 X-MC-Unique: v30h-F8CNcOwyertlQKivQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 549B28066EF; Tue, 19 Oct 2021 07:28:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C24910027C4; Tue, 19 Oct 2021 07:28:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 149DB1801241; Tue, 19 Oct 2021 07:28:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19J7Ndu5021548 for ; Tue, 19 Oct 2021 03:23:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 80719100913A; Tue, 19 Oct 2021 07:23:39 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7ABC9100CA53 for ; Tue, 19 Oct 2021 07:23:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54642811E76 for ; Tue, 19 Oct 2021 07:23:35 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-BivOMHq2NNenB1OObfnigA-1; Tue, 19 Oct 2021 03:23:31 -0400 X-MC-Unique: BivOMHq2NNenB1OObfnigA-1 Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> MIME-Version: 1.0 In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: , linux-xfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, To-header@lst.de, Mike Snitzer , nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, no@lst.de, on@lst.de, virtualization@lists.linux-foundation.org, "input <"@lst.de, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 06/11] xfs: factor out a xfs_setup_dax helper X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776F9C433F5 for ; Tue, 19 Oct 2021 07:39:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A24C60FD9 for ; Tue, 19 Oct 2021 07:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A24C60FD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HYQcr6C7Fz3g69 for ; Tue, 19 Oct 2021 18:39:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) X-Greylist: delayed 577 seconds by postgrey-1.36 at boromir; Tue, 19 Oct 2021 18:33:14 AEDT Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HYQT640l0z3f32 for ; Tue, 19 Oct 2021 18:33:14 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , linux-xfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, To-header@lst.de, Mike Snitzer , nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, no@lst.de, on@lst.de, virtualization@lists.linux-foundation.org, "input <"@lst.de, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series.