From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FDCC433F5 for ; Tue, 19 Oct 2021 15:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD7CA61175 for ; Tue, 19 Oct 2021 15:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233497AbhJSPxX (ORCPT ); Tue, 19 Oct 2021 11:53:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:51828 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233335AbhJSPxL (ORCPT ); Tue, 19 Oct 2021 11:53:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634658658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GbRnMysgz6O7UnaXr5MK4VpcJplugKks3BSf1ebt1U=; b=Jx4E0zUqaJ0oon9pP9k9ysGbp8EnqagtL9cq4RTIV2dff1xgwWt6gNlJLtd9aqHV6bAhAn r26ad+0q9VyR5jafmk2N6oN26ZpaZvrzivxKAZdxzeCKNwixy4To2p9lV+w/Jau9ArT53s EOsiZESwBYPxPcdW5v/8WJif4/MiMgc= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-fqbpNh0eN4C91Hnbb2anlg-1; Tue, 19 Oct 2021 11:50:57 -0400 X-MC-Unique: fqbpNh0eN4C91Hnbb2anlg-1 Received: by mail-ot1-f70.google.com with SMTP id r3-20020a056830236300b0054d43b72ba5so1997700oth.17 for ; Tue, 19 Oct 2021 08:50:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+GbRnMysgz6O7UnaXr5MK4VpcJplugKks3BSf1ebt1U=; b=3MHNfdyrH8nniEJ38XnbzKgHr8SQoOjD9ILoDqlpGwif6MTgAwEpDtJZg98zBIkYI7 ifiReKum9C1Obmk1XIeEtx+NjiGnOw95U6Rrwkg2DB+p00OUMkkDkQNgckjwg3isC7Fh H/hYqHwO8z0/B84ZtbiMqI1XgfdAt33IsQF+g9RMAJNh04EVolU/SsCT1E1jhJNbDkAM i6hkWZXFsFqUAYltexuz4+0FSO6jlNJq9fwz04Pp5MJb3fF0O9mVRP4xJefXDSg+Cyln YhbC0pAPcq18++i/w+Zpm7LSpFPg4dj7xYLnDlLSuxkcx2PXzEeOD5AXD7JBWMP5aM39 cQEA== X-Gm-Message-State: AOAM532X11fksKAiZxaa6ip2X4jIt00kU81zERFM/orKAF85WCKj+4Jv B76Ew3fBBtRWleZ8f01N0DEoaRKZ+dP0t8gHeDTYAncx3JPKQ+03WbSE06dBI+YqxGGCuI+3pel PbAnfXEP/j8WMSB+I X-Received: by 2002:aca:3741:: with SMTP id e62mr4868390oia.107.1634658656393; Tue, 19 Oct 2021 08:50:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuZk7ybu4ZG0GrP92X3+qNn8wg+fCyQDne+8sf1A9W2vT/rGeO2zS+cII8ncS8Dh0Ll18EuQ== X-Received: by 2002:aca:3741:: with SMTP id e62mr4868375oia.107.1634658656212; Tue, 19 Oct 2021 08:50:56 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id r23sm3738636otg.71.2021.10.19.08.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 08:50:56 -0700 (PDT) Date: Tue, 19 Oct 2021 09:50:54 -0600 From: Alex Williamson To: Yishai Hadas Cc: , , , , , , , , , , Subject: Re: [PATCH V2 mlx5-next 08/14] vfio: Add a macro for VFIO_DEVICE_STATE_ERROR Message-ID: <20211019095054.396b4f57.alex.williamson@redhat.com> In-Reply-To: <20211019094820.2e9bfc01.alex.williamson@redhat.com> References: <20211019105838.227569-1-yishaih@nvidia.com> <20211019105838.227569-9-yishaih@nvidia.com> <20211019094820.2e9bfc01.alex.williamson@redhat.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Oct 2021 09:48:20 -0600 Alex Williamson wrote: > On Tue, 19 Oct 2021 13:58:32 +0300 > Yishai Hadas wrote: > > > Add a macro for VFIO_DEVICE_STATE_ERROR to be used to set/check an error > > state. > > > > Signed-off-by: Yishai Hadas > > --- > > include/uapi/linux/vfio.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > > index 114ffcefe437..6d41a0f011db 100644 > > --- a/include/uapi/linux/vfio.h > > +++ b/include/uapi/linux/vfio.h > > @@ -631,6 +631,8 @@ struct vfio_device_migration_info { > > __u64 data_size; > > }; > > > > +#define VFIO_DEVICE_STATE_ERROR (VFIO_DEVICE_STATE_SAVING | \ > > + VFIO_DEVICE_STATE_RESUMING) > > This should be with the other VFIO_DEVICE_STATE_foo #defines. I'd > probably put it between _RESUMING and _MASK. Thanks, This should also update the existing macros that include _SAVING | _RESUMING. Thanks, Alex