All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	romieu@fr.zoreil.com
Subject: [PATCH net-next 6/6] ethernet: via-velocity: use eth_hw_addr_set()
Date: Tue, 19 Oct 2021 08:00:11 -0700	[thread overview]
Message-ID: <20211019150011.1355755-7-kuba@kernel.org> (raw)
In-Reply-To: <20211019150011.1355755-1-kuba@kernel.org>

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Read the address into an array on the stack, then call
eth_hw_addr_set().

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: romieu@fr.zoreil.com
---
 drivers/net/ethernet/via/via-velocity.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index 4b9c30f735b5..be2b992f24d9 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -2767,6 +2767,7 @@ static int velocity_probe(struct device *dev, int irq,
 	struct velocity_info *vptr;
 	struct mac_regs __iomem *regs;
 	int ret = -ENOMEM;
+	u8 addr[ETH_ALEN];
 
 	/* FIXME: this driver, like almost all other ethernet drivers,
 	 * can support more than MAX_UNITS.
@@ -2820,7 +2821,8 @@ static int velocity_probe(struct device *dev, int irq,
 	mac_wol_reset(regs);
 
 	for (i = 0; i < 6; i++)
-		netdev->dev_addr[i] = readb(&regs->PAR[i]);
+		addr[i] = readb(&regs->PAR[i]);
+	eth_hw_addr_set(netdev, addr);
 
 
 	velocity_get_options(&vptr->options, velocity_nics);
-- 
2.31.1


  parent reply	other threads:[~2021-10-19 15:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 15:00 [PATCH net-next 0/6] ethernet: manual netdev->dev_addr conversions (part 3) Jakub Kicinski
2021-10-19 15:00 ` [PATCH net-next 1/6] ethernet: netsec: use eth_hw_addr_set() Jakub Kicinski
2021-10-20  7:20   ` Ilias Apalodimas
2021-10-19 15:00 ` [PATCH net-next 2/6] ethernet: stmmac: " Jakub Kicinski
2021-10-19 15:00   ` Jakub Kicinski
2021-10-19 15:00 ` [PATCH net-next 3/6] ethernet: tehuti: " Jakub Kicinski
2021-10-19 15:00 ` [PATCH net-next 4/6] ethernet: tlan: " Jakub Kicinski
2021-10-19 15:00 ` [PATCH net-next 5/6] ethernet: via-rhine: " Jakub Kicinski
2021-10-19 15:00 ` Jakub Kicinski [this message]
2021-10-20 11:10 ` [PATCH net-next 0/6] ethernet: manual netdev->dev_addr conversions (part 3) patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019150011.1355755-7-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.