All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Xin Hao <xhao@linux.alibaba.com>
Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm/damon: Remove unnecessary variable initialization
Date: Wed, 20 Oct 2021 07:01:13 +0000	[thread overview]
Message-ID: <20211020070113.18392-1-sj@kernel.org> (raw)
In-Reply-To: <a2ddd67548879fe8f386f8daf522b47fdf99f581.1634693911.git.xhao@linux.alibaba.com>

On Wed, 20 Oct 2021 09:42:32 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:

> In 'damon_va_apply_three_regions', There is no
> need to set variable 'i' as 0
> 
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>

I gave you my 'Reviewed-by:' for the last version of this patch, but seems you
missed putting it here.  So, I'm giving it here again ;)

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  mm/damon/vaddr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index b8ba44f69db6..90be463efff7 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -305,7 +305,7 @@ static void damon_va_apply_three_regions(struct damon_target *t,
>  		struct damon_addr_range bregions[3])
>  {
>  	struct damon_region *r, *next;
> -	unsigned int i = 0;
> +	unsigned int i;
>  
>  	/* Remove regions which are not in the three big regions now */
>  	damon_for_each_region_safe(r, next, t) {
> -- 
> 2.31.0

  reply	other threads:[~2021-10-20  7:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  1:42 [PATCH v3 0/2] mm/damon: Fix some small bugs Xin Hao
2021-10-20  1:42 ` [PATCH v3 1/2] mm/damon: Remove unnecessary variable initialization Xin Hao
2021-10-20  7:01   ` SeongJae Park [this message]
2021-10-20  1:42 ` [PATCH v3 2/2] mm/damon/dbgfs: Add adaptive_targets list check before enable monitor_on Xin Hao
2021-10-20  7:21   ` SeongJae Park
2021-10-20  8:12     ` SeongJae Park
2021-10-20  8:15       ` Xin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020070113.18392-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sjpark@amazon.de \
    --cc=xhao@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.