From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0574C433F5 for ; Wed, 20 Oct 2021 08:55:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EE2561004 for ; Wed, 20 Oct 2021 08:55:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1EE2561004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md7NN-000816-0i for qemu-devel@archiver.kernel.org; Wed, 20 Oct 2021 04:55:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md7MD-0006yp-08 for qemu-devel@nongnu.org; Wed, 20 Oct 2021 04:53:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md7MA-0008LQ-Co for qemu-devel@nongnu.org; Wed, 20 Oct 2021 04:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634720032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W6ESm9thjrXyLdcfgtomJx0PHaWjrzV9u8nGAxeKMn4=; b=ANpUE3ZeJLhQ4361ApahDdrqg9q3/ro6/+VL8XAmV+XPeSsr15VMLOgJXkY7Lp6rh0dB+Z 1oO/e8k7itr+2Vbtlx3sspJjpOifwKbF+fakXzvRrzSZK/QAILN7v/Muxn+zSoC/UmMyBy RYYD1ds9wVhitc1XhdJ5VOCRgBYLVd0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-NjTwDWP7MaSZ_i98O431vg-1; Wed, 20 Oct 2021 04:53:51 -0400 X-MC-Unique: NjTwDWP7MaSZ_i98O431vg-1 Received: by mail-wm1-f70.google.com with SMTP id p3-20020a05600c204300b0030daa138dfeso3832511wmg.9 for ; Wed, 20 Oct 2021 01:53:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W6ESm9thjrXyLdcfgtomJx0PHaWjrzV9u8nGAxeKMn4=; b=zvniO6oK8MSnRj2aEYHHVB31Or5njJqizkujTYA6ZAsnRJ4nL7rexLlg/cDsaw2jOo Cl+MBKOXi7fDA/Fy3zVLLbLKqGXeuboM1tKurY1bzkGUT/QYmCvnfGDOVqIJW6iXIqyt 88SshFrDo6xttje/1sXVa6RjiCiSJlYWk7MyK6EAS1mxvPvasHUCB2QxQPXvfsH9DHTE IwdCF5rvQRqo6o3uJ/vyxwknZirXY+vACoSy5oM8qBzNJIrzyRaYEY4dBZpXN7L0mrIX jB7mex1D9hwMpmsrotxlcRNbTGHHPsS/ZdsUSId71cvoD5Ld+4/c2TTC4cmH/3obRiN5 UT8w== X-Gm-Message-State: AOAM532BSbgGAaur2nVnmlycfeTjHiZZoJtWOPspGQeAOVOf0RVsV8iz Qmmj6j9bw+eiPdSIEI2iYnzu760EfsVCpmLOru1eBG4ru0vOl3izdwtODLqdvM+Cl4ACj4GvbKq SYucmWOI05JXgK9E= X-Received: by 2002:a1c:80c8:: with SMTP id b191mr12127021wmd.36.1634720029908; Wed, 20 Oct 2021 01:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyum+vUm4ycckaIOh2Ia17rvQZZZkwfIncIdlAVaSJrNR85a1qsSl/5mVUJDsktbdXYrpZcfw== X-Received: by 2002:a1c:80c8:: with SMTP id b191mr12127005wmd.36.1634720029690; Wed, 20 Oct 2021 01:53:49 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id q12sm1447574wrp.13.2021.10.20.01.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 01:53:49 -0700 (PDT) Date: Wed, 20 Oct 2021 10:53:48 +0200 From: Igor Mammedov To: "Michael S. Tsirkin" Subject: Re: [PATCH v2 04/15] tests: acpi: q35: test for x2APIC entries in SRAT Message-ID: <20211020105348.7ef7cdd5@redhat.com> In-Reply-To: <20211020041734-mutt-send-email-mst@kernel.org> References: <20210902113551.461632-1-imammedo@redhat.com> <20210902113551.461632-5-imammedo@redhat.com> <20211018173052-mutt-send-email-mst@kernel.org> <20211019114825.1464da19@redhat.com> <20211019061656-mutt-send-email-mst@kernel.org> <20211019133624.5cd5ae3d@redhat.com> <20211019074422-mutt-send-email-mst@kernel.org> <20211020101607.5181e69d@redhat.com> <20211020041734-mutt-send-email-mst@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, pbonzini@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 20 Oct 2021 04:18:07 -0400 "Michael S. Tsirkin" wrote: > On Wed, Oct 20, 2021 at 10:16:07AM +0200, Igor Mammedov wrote: > > On Tue, 19 Oct 2021 07:44:38 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Oct 19, 2021 at 01:36:24PM +0200, Igor Mammedov wrote: > > > > On Tue, 19 Oct 2021 06:23:40 -0400 > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > On Tue, Oct 19, 2021 at 11:48:25AM +0200, Igor Mammedov wrote: > > > > > > On Mon, 18 Oct 2021 17:31:33 -0400 > > > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > > > > > On Thu, Sep 02, 2021 at 07:35:40AM -0400, Igor Mammedov wrote: > > > > > > > > Set -smp 1,maxcpus=288 to test for ACPI code that > > > > > > > > deal with CPUs with large APIC ID (>255). > > > > > > > > > > > > > > > > PS: > > > > > > > > Test requires KVM and in-kernel irqchip support, > > > > > > > > so skip test if KVM is not available. > > > > > > > > > > > > > > > > Signed-off-by: Igor Mammedov > > > > > > > > --- > > > > > > > > v3: > > > > > > > > - add dedicated test instead of abusing 'numamem' one > > > > > > > > - add 'kvm' prefix to the test name > > > > > > > > ("Michael S. Tsirkin" ) > > > > > > > > v2: > > > > > > > > - switch to qtest_has_accel() API > > > > > > > > > > > > > > > > CC: thuth@redhat.com > > > > > > > > CC: lvivier@redhat.com > > > > > > > > --- > > > > > > > > tests/qtest/bios-tables-test.c | 17 +++++++++++++++++ > > > > > > > > 1 file changed, 17 insertions(+) > > > > > > > > > > > > > > > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > > > > > > > > index 51d3a4e239..1f6779da87 100644 > > > > > > > > --- a/tests/qtest/bios-tables-test.c > > > > > > > > +++ b/tests/qtest/bios-tables-test.c > > > > > > > > @@ -1033,6 +1033,19 @@ static void test_acpi_q35_tcg_numamem(void) > > > > > > > > free_test_data(&data); > > > > > > > > } > > > > > > > > > > > > > > > > +static void test_acpi_q35_kvm_xapic(void) > > > > > > > > +{ > > > > > > > > + test_data data; > > > > > > > > + > > > > > > > > + memset(&data, 0, sizeof(data)); > > > > > > > > + data.machine = MACHINE_Q35; > > > > > > > > + data.variant = ".xapic"; > > > > > > > > + test_acpi_one(" -object memory-backend-ram,id=ram0,size=128M" > > > > > > > > + " -numa node -numa node,memdev=ram0" > > > > > > > > + " -machine kernel-irqchip=on -smp 1,maxcpus=288", &data); > > > > > > > > + free_test_data(&data); > > > > > > > > +} > > > > > > > > + > > > > > > > > static void test_acpi_q35_tcg_nosmm(void) > > > > > > > > { > > > > > > > > test_data data; > > > > > > > > > > > > > > > > > > > > > This causes an annoying message each time I run it: > > > > > > > > > > > > > > qemu-system-x86_64: -accel kvm: warning: Number of hotpluggable cpus requested (288) exceeds the recommended cpus supported by KVM (240) > > > > > > > > > > > > > > what gives? > > > > > > > > > > > > it depends on kernel, see kvm_recommended_vcpus(). > > > > > > > > > > > > We probably should bump it on upstream kernel side > > > > > > (it's much more than that in RHEL8). > > > > > > > > > > > > Is there anything that prevents bumping upstream kernel limits? > > > > > > > > > > what should we do with the annoying warning though? > > > > > > > > I'd leave it alone. > > > > What do you suggest? > > > > > > > > > > reduce the value so a typical system does not trigger it? > > > > it won't work, test needs as minimum 255 vcpus to trigger X2APIC logic > > and 288 value additionally tests max limits > > Add a flag to disable the warning while running this specific test? if it were qtest accel, it would be trivial but I'm not aware of something similar for tcg/kvm mode. Do you suggest to add to QEMU a CLI option for that? > > > > > > > > > > > > @@ -1506,6 +1519,7 @@ static void test_acpi_oem_fields_virt(void) > > > > > > > > int main(int argc, char *argv[]) > > > > > > > > { > > > > > > > > const char *arch = qtest_get_arch(); > > > > > > > > + const bool has_kvm = qtest_has_accel("kvm"); > > > > > > > > int ret; > > > > > > > > > > > > > > > > g_test_init(&argc, &argv, NULL); > > > > > > > > @@ -1561,6 +1575,9 @@ int main(int argc, char *argv[]) > > > > > > > > if (strcmp(arch, "x86_64") == 0) { > > > > > > > > qtest_add_func("acpi/microvm/pcie", test_acpi_microvm_pcie_tcg); > > > > > > > > } > > > > > > > > + if (has_kvm) { > > > > > > > > + qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic); > > > > > > > > + } > > > > > > > > } else if (strcmp(arch, "aarch64") == 0) { > > > > > > > > qtest_add_func("acpi/virt", test_acpi_virt_tcg); > > > > > > > > qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem); > > > > > > > > -- > > > > > > > > 2.27.0 > > > > > > > > > > > > > > > >