From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9013FC433EF for ; Wed, 20 Oct 2021 13:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B93660E96 for ; Wed, 20 Oct 2021 13:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbhJTNQF (ORCPT ); Wed, 20 Oct 2021 09:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbhJTNQE (ORCPT ); Wed, 20 Oct 2021 09:16:04 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A6F2C061746 for ; Wed, 20 Oct 2021 06:13:50 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id y7so2928529pfg.8 for ; Wed, 20 Oct 2021 06:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RtJrSfwgtT8YF0UzABCy/bW/wKJYVo6+C+buqqv0qRM=; b=q7xCqZuSLOyHPh4DSD5C5WeP2XY0+IKO9FUpBIuzlnqs/Pdrhi2E5FKTyNmLc0muw4 1f2tqi5sf9lEpGeSx3vNDXHHltXGj2W3/m8DWQf7SFV9OZmWTf/3+TKZ6BZqAbH/0OyC xv067LrngqQ7LsK67NOCGqWimMdmcKIV7hS3WX+cIARG5Af1aD+ZwhYON1DC7de3XnYL ZWArvmYmCj/Lpn0b4tWHCyR7U0lsdwTH8Dgksa+60rCZ8l5AO8uoH8oFjpjjDWViewiI 2dEiFaW7VXvniIU5hQnPZpVcx5NyRS6ZjetLVVAmz+jMIHMcstF1MThV6ZqC/whMjOW+ D6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RtJrSfwgtT8YF0UzABCy/bW/wKJYVo6+C+buqqv0qRM=; b=nECHbyXVMj3J8lXM9ZH/gGmzKLjLGzIcXe0wbAu2ew04K5rSA0wzRfRN2QyDcXvzzh Gjpy92OHuTls+TejafIQ28PnH94n8VXQl4+QBKe76ENt9N124Bi26EqZ4qOsPu+v369C bVEJ1fzrcp0ai+630ehb+aERXHsilkfPu9mkIVOMMi9cs4cN62djTLTUhfELgyZlNzAN a0p8eRwHRMQko0fyiC2+uFbrCOw/bNrsGy6CbravqCF4NwsYiGr7aK+uS/Fppff51FWw mFatME+BNA4bM6XY9LzdQXm/JJnxg+w0d7sGkhPFFg92rWERfde+TgALd/ihetzRznsD rt4g== X-Gm-Message-State: AOAM533T9ZEl1yEzFtDT5ljw+2QnW2EORI10TNl+esZdNekSSt6rdf/b l7Al8V22e35RHgBNsTlI3MWgNw== X-Google-Smtp-Source: ABdhPJxM5HvKzicLfYl4WLcVTSmueL+mPJWwOC7F+YSKiR/HLNlWXOat5ZyZDw6U8uxZm+oLIPbG0g== X-Received: by 2002:a63:1266:: with SMTP id 38mr33378184pgs.219.1634735629999; Wed, 20 Oct 2021 06:13:49 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id x27sm2486978pfr.181.2021.10.20.06.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 06:13:49 -0700 (PDT) Date: Wed, 20 Oct 2021 21:13:39 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 5/5] perf arm-spe: Snapshot mode test Message-ID: <20211020131339.GG49614@leoy-ThinkPad-X240s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-5-german.gomez@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916154635.1525-5-german.gomez@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 04:46:35PM +0100, German Gomez wrote: > Shell script test_arm_spe.sh has been added to test the recording of SPE > tracing events in snapshot mode. > > Reviewed-by: James Clark > Signed-off-by: German Gomez > --- > tools/perf/tests/shell/test_arm_spe.sh | 91 ++++++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100755 tools/perf/tests/shell/test_arm_spe.sh > > diff --git a/tools/perf/tests/shell/test_arm_spe.sh b/tools/perf/tests/shell/test_arm_spe.sh > new file mode 100755 > index 000000000000..9ed817e76f95 > --- /dev/null > +++ b/tools/perf/tests/shell/test_arm_spe.sh > @@ -0,0 +1,91 @@ > +#!/bin/sh > +# Check Arm SPE trace data recording and synthesized samples > + > +# Uses the 'perf record' to record trace data of Arm SPE events; > +# then verify if any SPE event samples are generated by SPE with > +# 'perf script' and 'perf report' commands. > + > +# SPDX-License-Identifier: GPL-2.0 > +# German Gomez , 2021 > + > +skip_if_no_arm_spe_event() { > + perf list | egrep -q 'arm_spe_[0-9]+//' && return 0 > + > + # arm_spe event doesn't exist > + return 2 > +} > + > +skip_if_no_arm_spe_event || exit 2 > + > +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > +glb_err=0 > + > +cleanup_files() > +{ > + rm -f ${perfdata} > + trap - exit term int > + kill -2 $$ # Forward sigint to parent I understand you copy this code from Arm cs-etm testing, but I found the sentence 'kill -2 $$' will cause a failure at my side with the command: root@ubuntu:/home/leoy/linux/tools/perf# ./perf test 85 -v 85: Check Arm SPE trace data recording and synthesized samples : --- start --- test child forked, pid 29053 Recording trace with snapshot mode /tmp/__perf_test.perf.data.uughb Looking at perf.data file for dumping samples: Looking at perf.data file for reporting samples: SPE snapshot testing: PASS test child finished with -1 ---- end ---- Check Arm SPE trace data recording and synthesized samples: FAILED! I changed to use below code and looks it works for me: if [[ "$1" == "int" ]]; then kill -SIGINT $$ fi if [[ "$1" == "term" ]]; then kill -SIGTERM $$ fi Thanks, Leo > + exit $glb_err > +} > + > +trap cleanup_files exit term int > + > +arm_spe_report() { > + if [ $2 != 0 ]; then > + echo "$1: FAIL" > + glb_err=$2 > + else > + echo "$1: PASS" > + fi > +} > + > +perf_script_samples() { > + echo "Looking at perf.data file for dumping samples:" > + > + # from arm-spe.c/arm_spe_synth_events() > + events="(ld1-miss|ld1-access|llc-miss|lld-access|tlb-miss|tlb-access|branch-miss|remote-access|memory)" > + > + # Below is an example of the samples dumping: > + # dd 3048 [002] 1 l1d-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + # dd 3048 [002] 1 tlb-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + # dd 3048 [002] 1 memory: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + perf script -F,-time -i ${perfdata} 2>&1 | \ > + egrep " +$1 +[0-9]+ .* +${events}:(.*:)? +" > /dev/null 2>&1 > +} > + > +perf_report_samples() { > + echo "Looking at perf.data file for reporting samples:" > + > + # Below is an example of the samples reporting: > + # 73.04% 73.04% dd libc-2.27.so [.] _dl_addr > + # 7.71% 7.71% dd libc-2.27.so [.] getenv > + # 2.59% 2.59% dd ld-2.27.so [.] strcmp > + perf report --stdio -i ${perfdata} 2>&1 | \ > + egrep " +[0-9]+\.[0-9]+% +[0-9]+\.[0-9]+% +$1 " > /dev/null 2>&1 > +} > + > +arm_spe_snapshot_test() { > + echo "Recording trace with snapshot mode $perfdata" > + perf record -o ${perfdata} -e arm_spe// -S \ > + -- dd if=/dev/zero of=/dev/null > /dev/null 2>&1 & > + PERFPID=$! > + > + # Wait for perf program > + sleep 1 > + > + # Send signal to snapshot trace data > + kill -USR2 $PERFPID > + > + # Stop perf program > + kill $PERFPID > + wait $PERFPID > + > + perf_script_samples dd && > + perf_report_samples dd > + > + err=$? > + arm_spe_report "SPE snapshot testing" $err > +} > + > +arm_spe_snapshot_test > +exit $glb_err > \ No newline at end of file > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8569C433EF for ; Wed, 20 Oct 2021 13:15:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DB760E96 for ; Wed, 20 Oct 2021 13:15:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A2DB760E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Efi6d7sS5WCuXanbxemyQdZrwVvww4xPpOstHYXasmE=; b=3I3JTxR//oqyI/ hV1yRSw53qrcjKlClAhnH6tB1ulnAMfByNrdDD2UhKrzGyDVsXuiLGOtMF5hwkulLFbQoPWYXmMKN SzdUsdz/7HQwPyioyuUE4ABg9rPQKJICy0CXcLCcNHZyu8Op21XHOUZS47yLZid3qJeOJTa/CGi/l 3oc8tQuOBKKhlEaLmnyTe+t9BJz0XHZzHy/dL6LkvZwRnznARMkx6x1E+HtNlHDec6+6puUbU+5ka +gblaDGkGgNWQd4BFuVYznQHx+EgX5jzTA2QrhqpEJkqNdlHeJmEg/jcOdpHsX2ULOAq4La1jIZ47 zRnOr6FRqQCWm8ymRILg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdBPu-004acY-Fg; Wed, 20 Oct 2021 13:14:02 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdBPp-004abW-SI for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 13:14:00 +0000 Received: by mail-pg1-x532.google.com with SMTP id m21so22450626pgu.13 for ; Wed, 20 Oct 2021 06:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RtJrSfwgtT8YF0UzABCy/bW/wKJYVo6+C+buqqv0qRM=; b=q7xCqZuSLOyHPh4DSD5C5WeP2XY0+IKO9FUpBIuzlnqs/Pdrhi2E5FKTyNmLc0muw4 1f2tqi5sf9lEpGeSx3vNDXHHltXGj2W3/m8DWQf7SFV9OZmWTf/3+TKZ6BZqAbH/0OyC xv067LrngqQ7LsK67NOCGqWimMdmcKIV7hS3WX+cIARG5Af1aD+ZwhYON1DC7de3XnYL ZWArvmYmCj/Lpn0b4tWHCyR7U0lsdwTH8Dgksa+60rCZ8l5AO8uoH8oFjpjjDWViewiI 2dEiFaW7VXvniIU5hQnPZpVcx5NyRS6ZjetLVVAmz+jMIHMcstF1MThV6ZqC/whMjOW+ D6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RtJrSfwgtT8YF0UzABCy/bW/wKJYVo6+C+buqqv0qRM=; b=tw52Fk5qxdGwNZMvB3dWeIZZzCE0lOhPt2vaQFBP/TTOx8GXeXFmobW5MvUHyUY1kt 6jfwoh1b8MI5CNVZ8z1dhVDWQIpV5z8WkPtg2yhaYkCxbVOpA2fZtwuzFDZHjltiGb3v MoAQPHFlS8gX4HCC/Bn9xgHyFGOpCwfhAb9c4HTCm1034GF57WCpeowNruPYSxTu0CbY BIca+acBW/nu9iEezYXdEXEQykpMwICX/HX5E6afqhH5BUHn4V11pGQHtCCWB23ppxlE Zuy72C418IwD9NkdidFjyYvG/3+QSe7q+c7WvwD8oStbZybLM7D9/RySLH38d7AyMoi+ zzxA== X-Gm-Message-State: AOAM532ev1yvuOZQSityL6/q9MsZ270GwV1uNwNY8s8/TbcLRWxYs+5X CGFmBu1sf9eFM5vYT/8rqjrJmw== X-Google-Smtp-Source: ABdhPJxM5HvKzicLfYl4WLcVTSmueL+mPJWwOC7F+YSKiR/HLNlWXOat5ZyZDw6U8uxZm+oLIPbG0g== X-Received: by 2002:a63:1266:: with SMTP id 38mr33378184pgs.219.1634735629999; Wed, 20 Oct 2021 06:13:49 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id x27sm2486978pfr.181.2021.10.20.06.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 06:13:49 -0700 (PDT) Date: Wed, 20 Oct 2021 21:13:39 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 5/5] perf arm-spe: Snapshot mode test Message-ID: <20211020131339.GG49614@leoy-ThinkPad-X240s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-5-german.gomez@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916154635.1525-5-german.gomez@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_061357_947687_170B607F X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 04:46:35PM +0100, German Gomez wrote: > Shell script test_arm_spe.sh has been added to test the recording of SPE > tracing events in snapshot mode. > > Reviewed-by: James Clark > Signed-off-by: German Gomez > --- > tools/perf/tests/shell/test_arm_spe.sh | 91 ++++++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100755 tools/perf/tests/shell/test_arm_spe.sh > > diff --git a/tools/perf/tests/shell/test_arm_spe.sh b/tools/perf/tests/shell/test_arm_spe.sh > new file mode 100755 > index 000000000000..9ed817e76f95 > --- /dev/null > +++ b/tools/perf/tests/shell/test_arm_spe.sh > @@ -0,0 +1,91 @@ > +#!/bin/sh > +# Check Arm SPE trace data recording and synthesized samples > + > +# Uses the 'perf record' to record trace data of Arm SPE events; > +# then verify if any SPE event samples are generated by SPE with > +# 'perf script' and 'perf report' commands. > + > +# SPDX-License-Identifier: GPL-2.0 > +# German Gomez , 2021 > + > +skip_if_no_arm_spe_event() { > + perf list | egrep -q 'arm_spe_[0-9]+//' && return 0 > + > + # arm_spe event doesn't exist > + return 2 > +} > + > +skip_if_no_arm_spe_event || exit 2 > + > +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > +glb_err=0 > + > +cleanup_files() > +{ > + rm -f ${perfdata} > + trap - exit term int > + kill -2 $$ # Forward sigint to parent I understand you copy this code from Arm cs-etm testing, but I found the sentence 'kill -2 $$' will cause a failure at my side with the command: root@ubuntu:/home/leoy/linux/tools/perf# ./perf test 85 -v 85: Check Arm SPE trace data recording and synthesized samples : --- start --- test child forked, pid 29053 Recording trace with snapshot mode /tmp/__perf_test.perf.data.uughb Looking at perf.data file for dumping samples: Looking at perf.data file for reporting samples: SPE snapshot testing: PASS test child finished with -1 ---- end ---- Check Arm SPE trace data recording and synthesized samples: FAILED! I changed to use below code and looks it works for me: if [[ "$1" == "int" ]]; then kill -SIGINT $$ fi if [[ "$1" == "term" ]]; then kill -SIGTERM $$ fi Thanks, Leo > + exit $glb_err > +} > + > +trap cleanup_files exit term int > + > +arm_spe_report() { > + if [ $2 != 0 ]; then > + echo "$1: FAIL" > + glb_err=$2 > + else > + echo "$1: PASS" > + fi > +} > + > +perf_script_samples() { > + echo "Looking at perf.data file for dumping samples:" > + > + # from arm-spe.c/arm_spe_synth_events() > + events="(ld1-miss|ld1-access|llc-miss|lld-access|tlb-miss|tlb-access|branch-miss|remote-access|memory)" > + > + # Below is an example of the samples dumping: > + # dd 3048 [002] 1 l1d-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + # dd 3048 [002] 1 tlb-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + # dd 3048 [002] 1 memory: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) > + perf script -F,-time -i ${perfdata} 2>&1 | \ > + egrep " +$1 +[0-9]+ .* +${events}:(.*:)? +" > /dev/null 2>&1 > +} > + > +perf_report_samples() { > + echo "Looking at perf.data file for reporting samples:" > + > + # Below is an example of the samples reporting: > + # 73.04% 73.04% dd libc-2.27.so [.] _dl_addr > + # 7.71% 7.71% dd libc-2.27.so [.] getenv > + # 2.59% 2.59% dd ld-2.27.so [.] strcmp > + perf report --stdio -i ${perfdata} 2>&1 | \ > + egrep " +[0-9]+\.[0-9]+% +[0-9]+\.[0-9]+% +$1 " > /dev/null 2>&1 > +} > + > +arm_spe_snapshot_test() { > + echo "Recording trace with snapshot mode $perfdata" > + perf record -o ${perfdata} -e arm_spe// -S \ > + -- dd if=/dev/zero of=/dev/null > /dev/null 2>&1 & > + PERFPID=$! > + > + # Wait for perf program > + sleep 1 > + > + # Send signal to snapshot trace data > + kill -USR2 $PERFPID > + > + # Stop perf program > + kill $PERFPID > + wait $PERFPID > + > + perf_script_samples dd && > + perf_report_samples dd > + > + err=$? > + arm_spe_report "SPE snapshot testing" $err > +} > + > +arm_spe_snapshot_test > +exit $glb_err > \ No newline at end of file > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel