All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: "Štěpán Němec" <snemec@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nft] tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")
Date: Wed, 20 Oct 2021 15:13:54 +0200	[thread overview]
Message-ID: <20211020131354.GH1668@orbyte.nwl.cc> (raw)
In-Reply-To: <20211020124220.489260-1-snemec@redhat.com>

Hi Stepan,

On Wed, Oct 20, 2021 at 02:42:20PM +0200, Štěpán Němec wrote:
> Test inspired by [1] with both the set and stack size reduced by the
> same power of 2, to preserve the (pre-baecd1cf2685) segfault on one
> hand, and make the test successfully complete (post-baecd1cf2685) in a
> few seconds even on weaker hardware on the other.
> 
> (The reason I stopped at 128kB stack size is that with 64kB I was
> getting segfaults even with baecd1cf2685 applied.)
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1908127
> 
> Signed-off-by: Štěpán Němec <snemec@redhat.com>
> Helped-by: Phil Sutter <phil@nwl.cc>

Thanks for the patch, just one remark:

[...]
> +cat >>"$ruleset_file" <<\EOF
                          ~~~
Is this backslash a typo or intentional?

Cheers, Phil

  reply	other threads:[~2021-10-20 13:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:42 [PATCH nft] tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set") Štěpán Němec
2021-10-20 13:13 ` Phil Sutter [this message]
2021-10-20 13:38   ` Štěpán Němec
2021-10-20 13:53     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020131354.GH1668@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=snemec@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.