From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000D4C433EF for ; Wed, 20 Oct 2021 15:04:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F7376103D for ; Wed, 20 Oct 2021 15:04:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F7376103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdD8p-0000zK-JZ for qemu-devel@archiver.kernel.org; Wed, 20 Oct 2021 11:04:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdD6J-0007ei-6a for qemu-devel@nongnu.org; Wed, 20 Oct 2021 11:01:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdD6E-0001wz-Ca for qemu-devel@nongnu.org; Wed, 20 Oct 2021 11:01:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634742109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sup9P9dHxcVB+5mayzA+CbhrYkOMazffPlyr8KJ8Qow=; b=ffBoQxz26NTmrILtc2qBkq3kL0FWmaRpNdEYZnvjWYoZL3tjNQKPt0CtWEHSq9xxWDAOLL x7ySpV6cd9Bq+Qxmpojldvs04UvATzpj1gYe9uMVs1nNKFj2NwA9riwy4dDPPQoUf5cF+y YyKaAe9e9oVFdAOo4aQtpKMuBVUGPfg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-yD80iFxdNIGluE3QPyoCCg-1; Wed, 20 Oct 2021 11:01:45 -0400 X-MC-Unique: yD80iFxdNIGluE3QPyoCCg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E02E80198A; Wed, 20 Oct 2021 15:01:44 +0000 (UTC) Received: from localhost (unknown [10.22.17.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id E80C05F4E1; Wed, 20 Oct 2021 15:01:43 +0000 (UTC) Date: Wed, 20 Oct 2021 11:01:43 -0400 From: Eduardo Habkost To: "Michael S. Tsirkin" Subject: Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs Message-ID: <20211020150143.kocjozzcuz3f35b2@habkost.net> References: <20211012082428.16222-1-jean-louis@dupond.be> <20211019065850-mutt-send-email-mst@kernel.org> <20211019152913.wjipmv6trjx6k7xa@habkost.net> <20211019120619-mutt-send-email-mst@kernel.org> <20211019165611.scfagcp4ikhigx5k@habkost.net> <20211020034005-mutt-send-email-mst@kernel.org> <20211020135737.3wubfa4c6ijflolp@habkost.net> <20211020105521-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20211020105521-mutt-send-email-mst@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, Stefan Hajnoczi , jasowang@redhat.com, qemu-devel@nongnu.org, Jean-Louis Dupond , pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 20, 2021 at 10:55:59AM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 20, 2021 at 09:57:37AM -0400, Eduardo Habkost wrote: > > On Wed, Oct 20, 2021 at 03:41:38AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > > > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > > > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > > > > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > > > > > > On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > > > > > > > > On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > > > > > > > > > Forgot to CC maintainers. > > > > > > > > > > > > > > > > Also CCing Jason Wang and Michael Tsirkin for VIRTIO. > > > > > > > > > > > > > > > > Stefan > > > > > > > > > > > > > > OMG > > > > > > > where all compat properties broken all the time? > > > > > > > > > > > > Compat properties that existed when commit f6e501a28ef9 ("virtio: > > > > > > Provide version-specific variants of virtio PCI devices") was > > > > > > merged are not broken, because virtio-*-transitional and > > > > > > virtio-*-non-transitional were brand new QOM types (so there's no > > > > > > compatibility to be kept with old QEMU versions). > > > > > > > > > > > > Compat properties referencing "virtio-*-pci" instead of > > > > > > "virtio-*-pci-base" added after commit f6e501a28ef9 are probably > > > > > > broken, yes. > > > > > > > > > > > > -- > > > > > > Eduardo > > > > > > > > > > Oh. So just this one: > > > > > { "virtio-net-pci", "vectors", "3"}, > > > > > > > > > > right? > > > > > > > > I think so. That's the only post-4.0 virtio-*-pci compat property I see in > > > > hw/core/machine.c. > > > > > > > > pc.c doesn't have any post-4.0 virtio-*-pci compat props. I didn't see any > > > > virtio compat props on spapr.c and s390-virtio-ccw.c. > > > > > > > > > > > > > > about the patch: how do people feel about virtio specific > > > > > stuff in qdev core? Ok by everyone? > > > > > > > > Not OK, if we have a mechanism to avoid that, already (the > > > > "virtio-net-pci-base" type name). I wonder what we can do to > > > > make this kind of mistake less likely, though. > > > > > > > > Jean-Louis, Jason, does the following fix work? > > > > > > > > Signed-off-by: Eduardo Habkost > > > > --- > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > > > index b8d95eec32d..bd9c6156c1a 100644 > > > > --- a/hw/core/machine.c > > > > +++ b/hw/core/machine.c > > > > @@ -56,7 +56,7 @@ GlobalProperty hw_compat_5_2[] = { > > > > { "ICH9-LPC", "smm-compat", "on"}, > > > > { "PIIX4_PM", "smm-compat", "on"}, > > > > { "virtio-blk-device", "report-discard-granularity", "off" }, > > > > - { "virtio-net-pci", "vectors", "3"}, > > > > + { "virtio-net-pci-base", "vectors", "3"}, > > > > }; > > > > const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2); > > > > > > Hmm I'm a bit confused at this point, as to why does > > > specifying properties for virtio-net-pci on command > > > line with -global work, but in compat list doesn't. Do others > > > understand? > > > > I don't think that's the case. -global behaves similarly to compat_props. > > > > Running an unpatched QEMU 6.1.0 binary: > > > > $ echo -e 'info qtree\nquit' | qemu-system-x86_64 -device virtio-net-pci -machine pc-q35-5.2 -monitor stdio | grep vectors > > vectors = 3 (0x3) > > $ echo -e 'info qtree\nquit' | qemu-system-x86_64 -device virtio-net-pci-non-transitional -machine pc-q35-5.2 -monitor stdio | grep vectors > > vectors = 4 (0x4) > > $ echo -e 'info qtree\nquit' | qemu-system-x86_64 -device virtio-net-pci-non-transitional -global virtio-net-pci.vectors=3 -monitor stdio | grep vectors > > vectors = 4 (0x4) > > $ echo -e 'info qtree\nquit' | qemu-system-x86_64 -device virtio-net-pci-non-transitional -global virtio-net-pci-base.vectors=3 -monitor stdio | grep vectors > > vectors = 3 (0x3) > > OK so ... that's another breakage then. Suggestions how to fix? What exactly is another breakage? virtio-net-pci, virtio-net-pci-non-transitional, and virtio-net-pci-transitional are three distinct device types. -- Eduardo