From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C64C433F5 for ; Wed, 20 Oct 2021 19:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D45D9604DB for ; Wed, 20 Oct 2021 19:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbhJTTgZ (ORCPT ); Wed, 20 Oct 2021 15:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230268AbhJTTgY (ORCPT ); Wed, 20 Oct 2021 15:36:24 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2548C06161C for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso746003wmd.3 for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=g9C4Q+FGe3RhcO39LAR/2C5riQT1MS5idA1Uc0WW9dHdFwfMJt+c8S5Pv0riiYuF0v oF4yMSjmw/c9rRlFKJHX4k7cDyVCYhbux98pyMOlpt4NGGGmRk3uXPr2IWDXEG1mDXQ1 Nmj/f1MCO+cIPu0+w/5TYk8pYgncEcnXaSllD4fhgIKkr2JHPVyVCRStqNanIfizGFnS J8Rpis0dSyVJm3XykDBu6PJFasTpxI/TW7uS9OWvvR2J69YLuVLA29Y0AGHU1Ub4j4eM hPZ21LJ90PznprSNpDxa0atqZV/ZYPfMu715MFGAH8X8v1GnnneYd/6BRQMB6iwsPyQN HgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=3wpotearublopRFKFb6mF1k59o26iIJ2lGuXKbZqgxZzwHX1bcK41Y3NYixiJ8GZPp VrSq27Oc4Ew0+niKtp5IVzjrzor+oCQbigc7udPKjcUqrWGATUGTsfw9PmnQdWWtBKOL 79JFjUMvA01Tvz51GgDUvvs9l0vZW1CjlADL1HEACjKCC1X5FQ9634HRlEidBlPixHam ZQcihbttnirNExGkwGtnggacwYvo/n/t/i/oenmdIqTmr64wi9Pz0uZGsUgahILjBz7W nrtl9I0T2dnawgGKWKD3UxftRVrMWvQTdg9sDa/yxErHGW4z1LUyyeFQr1lX+oLXRKfM HXRw== X-Gm-Message-State: AOAM531RS3PLl2wGL6S277xcAjhpim86AYsbpWNEwSCgvWhC+oRcnHcN TdVwTnHiOYfhI16WTdjA272Hvw== X-Google-Smtp-Source: ABdhPJxhXGVW++4V0sz2hvab4LJBAF8DPOIn0OjMGV74GJEYevwnJeXR6UCwTqgf0uxJqVNxHNIGWw== X-Received: by 2002:a05:600c:2905:: with SMTP id i5mr1313497wmd.159.1634758448562; Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Received: from blmsp ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id t1sm3655328wre.32.2021.10.20.12.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Date: Wed, 20 Oct 2021 21:34:07 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Chun-Kuang Hu , Philipp Zabel , Vinod Koul , Sam Ravnborg , dri-devel , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mediatek,dp: Add Display Port binding Message-ID: <20211020193407.meektqms4psltg34@blmsp> References: <20211011094624.3416029-1-msp@baylibre.com> <20211011094624.3416029-3-msp@baylibre.com> <20211018141908.fuevv2m66fw3xg36@blmsp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Mon, Oct 18, 2021 at 02:38:33PM -0500, Rob Herring wrote: > On Mon, Oct 18, 2021 at 9:19 AM Markus Schneider-Pargmann > wrote: > > > > Hi Rob, > > > > On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > > > This controller is present on several mediatek hardware. Currently > > > > mt8195 and mt8395 have this controller without a functional difference, > > > > so only one compatible field is added. > > > > > > > > The controller can have two forms, as a normal display port and as an > > > > embedded display port. > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > --- > > > > .../display/mediatek/mediatek,dp.yaml | 89 +++++++++++++++++++ > > > > 1 file changed, 89 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > new file mode 100644 > > > > index 000000000000..f7a35962c23b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > @@ -0,0 +1,89 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mediatek Display Port Controller > > > > + > > > > +maintainers: > > > > + - CK Hu > > > > + - Jitao shi > > > > + > > > > +description: | > > > > + Device tree bindings for the Mediatek (embedded) Display Port controller > > > > + present on some Mediatek SoCs. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mediatek,mt8195-edp_tx > > > > + - mediatek,mt8195-dp_tx > > > > > > Are these blocks different? > > > > Good point, the registers of these blocks are described in its own > > chapter each. Also I do need to distinguish between both in the driver. > > Would you suggest making this distinction differently or keep it as two > > compatibles? > > If the registers are all the same, then it should be the same > compatible. If you still need to distinguish, then you should have a > panel or connector node that will let you do that. Thank you. Good idea to check with the connector node, I have changed it as you suggested. > > Also, s/_/-/ in the compatible string. Done. Thanks, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3DFC433EF for ; Wed, 20 Oct 2021 19:34:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E9AE60FDA for ; Wed, 20 Oct 2021 19:34:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E9AE60FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8B2C6E372; Wed, 20 Oct 2021 19:34:11 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19F2B6E342 for ; Wed, 20 Oct 2021 19:34:10 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id o24so13308965wms.0 for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=g9C4Q+FGe3RhcO39LAR/2C5riQT1MS5idA1Uc0WW9dHdFwfMJt+c8S5Pv0riiYuF0v oF4yMSjmw/c9rRlFKJHX4k7cDyVCYhbux98pyMOlpt4NGGGmRk3uXPr2IWDXEG1mDXQ1 Nmj/f1MCO+cIPu0+w/5TYk8pYgncEcnXaSllD4fhgIKkr2JHPVyVCRStqNanIfizGFnS J8Rpis0dSyVJm3XykDBu6PJFasTpxI/TW7uS9OWvvR2J69YLuVLA29Y0AGHU1Ub4j4eM hPZ21LJ90PznprSNpDxa0atqZV/ZYPfMu715MFGAH8X8v1GnnneYd/6BRQMB6iwsPyQN HgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=emdP+zVzvuOMq6vEq89sA5Xk1a/akwpSjCQ3PqpCVkYkDqdsjGzTc+APrY7fJYi3D5 x9ee7x2QnCvFLLg1lTcg+Q6kV2HKiZ6mSta62HTnVIudOFUzGMbsnKOtUIS68+MogYi/ 4kyyZo/RcitG/iefC+IgTC/Bj/5GG495kk/0zJtua9jHKFRVwRS//T4663sNIgYKdA6e ebSI2srH2hYixDKlKFpodzW7HkppHVcwmPZRTup7eMgPSb080YAn6iMP2L3epjbFY/Kk Qu+gKYyfGo3EQm6fKL62+8g60ONURgUVO5CGHCD1UtTDe1IIE0hXZ8HRqh4uzT9D8ZRe zzJQ== X-Gm-Message-State: AOAM532s/A6OZhU0mTT5SodxSk4tY2etE9Dkc761ykR+el8QKWqFdLxi mj0/1iqG1lGs2SyxlaIIygR1Dw== X-Google-Smtp-Source: ABdhPJxhXGVW++4V0sz2hvab4LJBAF8DPOIn0OjMGV74GJEYevwnJeXR6UCwTqgf0uxJqVNxHNIGWw== X-Received: by 2002:a05:600c:2905:: with SMTP id i5mr1313497wmd.159.1634758448562; Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Received: from blmsp ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id t1sm3655328wre.32.2021.10.20.12.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Date: Wed, 20 Oct 2021 21:34:07 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Chun-Kuang Hu , Philipp Zabel , Vinod Koul , Sam Ravnborg , dri-devel , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding Message-ID: <20211020193407.meektqms4psltg34@blmsp> References: <20211011094624.3416029-1-msp@baylibre.com> <20211011094624.3416029-3-msp@baylibre.com> <20211018141908.fuevv2m66fw3xg36@blmsp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, On Mon, Oct 18, 2021 at 02:38:33PM -0500, Rob Herring wrote: > On Mon, Oct 18, 2021 at 9:19 AM Markus Schneider-Pargmann > wrote: > > > > Hi Rob, > > > > On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > > > This controller is present on several mediatek hardware. Currently > > > > mt8195 and mt8395 have this controller without a functional difference, > > > > so only one compatible field is added. > > > > > > > > The controller can have two forms, as a normal display port and as an > > > > embedded display port. > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > --- > > > > .../display/mediatek/mediatek,dp.yaml | 89 +++++++++++++++++++ > > > > 1 file changed, 89 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > new file mode 100644 > > > > index 000000000000..f7a35962c23b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > @@ -0,0 +1,89 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mediatek Display Port Controller > > > > + > > > > +maintainers: > > > > + - CK Hu > > > > + - Jitao shi > > > > + > > > > +description: | > > > > + Device tree bindings for the Mediatek (embedded) Display Port controller > > > > + present on some Mediatek SoCs. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mediatek,mt8195-edp_tx > > > > + - mediatek,mt8195-dp_tx > > > > > > Are these blocks different? > > > > Good point, the registers of these blocks are described in its own > > chapter each. Also I do need to distinguish between both in the driver. > > Would you suggest making this distinction differently or keep it as two > > compatibles? > > If the registers are all the same, then it should be the same > compatible. If you still need to distinguish, then you should have a > panel or connector node that will let you do that. Thank you. Good idea to check with the connector node, I have changed it as you suggested. > > Also, s/_/-/ in the compatible string. Done. Thanks, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EBECC433EF for ; Wed, 20 Oct 2021 19:34:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C3ED60FDA for ; Wed, 20 Oct 2021 19:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C3ED60FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FXZyb+E2eWrWrXgRSsVBYPKwcuqr/5HVx1i34XkaT2E=; b=q2DWl605DKGMZu nxn9WkUryem3sfonzhmscIy9xvZk+YmSNpeXQgqZlSMj6SiIABR/OlpbPo3QbBv1U3OsYznmeq1sd OVeWzcMcpgRIvGeIHdkF1nUykxMQcz59ptK/FyGU5xara6I1zIQQP7UiVAIPFiI0i2WMIit3hXogy v412FxGaLpKUa5xUZkPxLOdzi1tpM8toztqlq39hRswLOoXo3CyGjCT2O7WSmDbpSrBzLCLUwWqHm +IbQo3y2lGJR5213hyekT6NkLYo57JaDLqDHXFM3Y4AZnqhvJGx5c4whxwAmzpz1jmrnMmcr0vG1L 4IdcS974Kdw6ihzMAZrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLr-005fbz-T8; Wed, 20 Oct 2021 19:34:15 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLn-005fZz-1F for linux-phy@lists.infradead.org; Wed, 20 Oct 2021 19:34:13 +0000 Received: by mail-wm1-x32a.google.com with SMTP id g79-20020a1c2052000000b00323023159e1so3804169wmg.2 for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=g9C4Q+FGe3RhcO39LAR/2C5riQT1MS5idA1Uc0WW9dHdFwfMJt+c8S5Pv0riiYuF0v oF4yMSjmw/c9rRlFKJHX4k7cDyVCYhbux98pyMOlpt4NGGGmRk3uXPr2IWDXEG1mDXQ1 Nmj/f1MCO+cIPu0+w/5TYk8pYgncEcnXaSllD4fhgIKkr2JHPVyVCRStqNanIfizGFnS J8Rpis0dSyVJm3XykDBu6PJFasTpxI/TW7uS9OWvvR2J69YLuVLA29Y0AGHU1Ub4j4eM hPZ21LJ90PznprSNpDxa0atqZV/ZYPfMu715MFGAH8X8v1GnnneYd/6BRQMB6iwsPyQN HgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=31jURA0l9yY911X4AAuH9sMKMruMzeubUi26Z1D8SJq6G02VS7ghE/9m5PL5hLWCR7 t4Q1y3CEE3x4zq5N3/bA/3majRSgiQeZ40XQ25C96nGBkEq+KzLIL6w2r7Q2ifPFEnJ2 MRqdwp6ztBMm1KmuKjqGwIv1G8hYAZKrVhmyBt+JRw5pGrZPqNc2c7wVEmpygjyAE7h8 kujGiJJ7OVtHAzxHCbH5SDvBrE/gYXEYYbWEOHn/Ep2g4lLU6piEhNj/m4+UM7myQUmq wWMTeO7GdfjfouTTMXiUAzfuV+R4mKWixANCyOjvoDWtvuq6PAbUBlhEaOZDE6B3/BrX kUVA== X-Gm-Message-State: AOAM533MlICKMLs/PbMYLvnGQMq3jzqfsT+EqxfKV7AGL/G9Yqnxk7Yz wSzaL02TsNHMO7dtXIu3QjIWPw== X-Google-Smtp-Source: ABdhPJxhXGVW++4V0sz2hvab4LJBAF8DPOIn0OjMGV74GJEYevwnJeXR6UCwTqgf0uxJqVNxHNIGWw== X-Received: by 2002:a05:600c:2905:: with SMTP id i5mr1313497wmd.159.1634758448562; Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Received: from blmsp ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id t1sm3655328wre.32.2021.10.20.12.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Date: Wed, 20 Oct 2021 21:34:07 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Chun-Kuang Hu , Philipp Zabel , Vinod Koul , Sam Ravnborg , dri-devel , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding Message-ID: <20211020193407.meektqms4psltg34@blmsp> References: <20211011094624.3416029-1-msp@baylibre.com> <20211011094624.3416029-3-msp@baylibre.com> <20211018141908.fuevv2m66fw3xg36@blmsp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_123411_111105_6C95F5D4 X-CRM114-Status: GOOD ( 27.49 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Rob, On Mon, Oct 18, 2021 at 02:38:33PM -0500, Rob Herring wrote: > On Mon, Oct 18, 2021 at 9:19 AM Markus Schneider-Pargmann > wrote: > > > > Hi Rob, > > > > On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > > > This controller is present on several mediatek hardware. Currently > > > > mt8195 and mt8395 have this controller without a functional difference, > > > > so only one compatible field is added. > > > > > > > > The controller can have two forms, as a normal display port and as an > > > > embedded display port. > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > --- > > > > .../display/mediatek/mediatek,dp.yaml | 89 +++++++++++++++++++ > > > > 1 file changed, 89 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > new file mode 100644 > > > > index 000000000000..f7a35962c23b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > @@ -0,0 +1,89 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mediatek Display Port Controller > > > > + > > > > +maintainers: > > > > + - CK Hu > > > > + - Jitao shi > > > > + > > > > +description: | > > > > + Device tree bindings for the Mediatek (embedded) Display Port controller > > > > + present on some Mediatek SoCs. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mediatek,mt8195-edp_tx > > > > + - mediatek,mt8195-dp_tx > > > > > > Are these blocks different? > > > > Good point, the registers of these blocks are described in its own > > chapter each. Also I do need to distinguish between both in the driver. > > Would you suggest making this distinction differently or keep it as two > > compatibles? > > If the registers are all the same, then it should be the same > compatible. If you still need to distinguish, then you should have a > panel or connector node that will let you do that. Thank you. Good idea to check with the connector node, I have changed it as you suggested. > > Also, s/_/-/ in the compatible string. Done. Thanks, Markus -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7725C433EF for ; Wed, 20 Oct 2021 19:34:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75AFA604DB for ; Wed, 20 Oct 2021 19:34:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75AFA604DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U8C3hR+ysgTMUyKew93EAlkQOBYBdldi4JWpPKI6F+I=; b=t7/Ke7vRNLePLJ iVvqX1KTayzBhOVPZIJRYIUl97sPHPYNhksk11NQyHMu0LiwKG/9TeJdsRPcwVwH9olRZUmTLfD/H TNJ/mu27yg7zP5hcAMCmbHxhqx8q/Q+4bC2am21iDBjz6GBEwWCqolgj7U5rHkLyyflrDtuhPVqie McwdPxV7/ffkXseXYMKV44vK9ozTz65t/At/SiepIoQZdr9NFRQKlz7QmR9ee2igPQZUi7kk7KYUG qytoJRbcCCcOH5j0k2HEUKWc8m63HUBX66e7w7V/sBogViRSRFq59dwyUAEnyNvwZeetwyO1IOhkW jq+zK82MnUTjpOAcf5tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLq-005fbi-Tn; Wed, 20 Oct 2021 19:34:14 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLn-005fa0-26 for linux-mediatek@lists.infradead.org; Wed, 20 Oct 2021 19:34:12 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 77-20020a1c0450000000b0030da2439b21so3852523wme.0 for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=g9C4Q+FGe3RhcO39LAR/2C5riQT1MS5idA1Uc0WW9dHdFwfMJt+c8S5Pv0riiYuF0v oF4yMSjmw/c9rRlFKJHX4k7cDyVCYhbux98pyMOlpt4NGGGmRk3uXPr2IWDXEG1mDXQ1 Nmj/f1MCO+cIPu0+w/5TYk8pYgncEcnXaSllD4fhgIKkr2JHPVyVCRStqNanIfizGFnS J8Rpis0dSyVJm3XykDBu6PJFasTpxI/TW7uS9OWvvR2J69YLuVLA29Y0AGHU1Ub4j4eM hPZ21LJ90PznprSNpDxa0atqZV/ZYPfMu715MFGAH8X8v1GnnneYd/6BRQMB6iwsPyQN HgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=vXCmQoslq7xl4u4M+oJiAGPXlkCAp8G4IGBjwts6Y0FvYfSZsDUJtetNlocX0Nq/5W JHZRqU5ASaKLqgT6Uiz66ZxK93P/TcZBhR5On3UzGS4UswMOlJL/Gjv4VtYlwrNqojTc AigzzowV+sKapA9W3KqjPJK+wJ5quLp5yMWWtkUgQdJCdwlUstDRmgGkMLhpj8crWjPx 7526Jx/Bh8fN1AGFLHkuT57bYhyi9hEFRglZTWG1eGUCuc8yReFFoUwwZuGhyKUO/94e cE0UQQbRWCnb3r1BLlKhjniN5LVPW4MFuxSALyNpr7vl7TSDFRVHCi8tWLMgJYTC9rPU yeWg== X-Gm-Message-State: AOAM531yDqOiFihFkVDPyHNnLnT54gmNNsHjmVckIC/xpmwg+a4upTel faHFajSKQL0oms02FORehgh7gg== X-Google-Smtp-Source: ABdhPJxhXGVW++4V0sz2hvab4LJBAF8DPOIn0OjMGV74GJEYevwnJeXR6UCwTqgf0uxJqVNxHNIGWw== X-Received: by 2002:a05:600c:2905:: with SMTP id i5mr1313497wmd.159.1634758448562; Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Received: from blmsp ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id t1sm3655328wre.32.2021.10.20.12.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Date: Wed, 20 Oct 2021 21:34:07 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Chun-Kuang Hu , Philipp Zabel , Vinod Koul , Sam Ravnborg , dri-devel , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding Message-ID: <20211020193407.meektqms4psltg34@blmsp> References: <20211011094624.3416029-1-msp@baylibre.com> <20211011094624.3416029-3-msp@baylibre.com> <20211018141908.fuevv2m66fw3xg36@blmsp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_123411_119539_BB4E2BC8 X-CRM114-Status: GOOD ( 27.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Rob, On Mon, Oct 18, 2021 at 02:38:33PM -0500, Rob Herring wrote: > On Mon, Oct 18, 2021 at 9:19 AM Markus Schneider-Pargmann > wrote: > > > > Hi Rob, > > > > On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > > > This controller is present on several mediatek hardware. Currently > > > > mt8195 and mt8395 have this controller without a functional difference, > > > > so only one compatible field is added. > > > > > > > > The controller can have two forms, as a normal display port and as an > > > > embedded display port. > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > --- > > > > .../display/mediatek/mediatek,dp.yaml | 89 +++++++++++++++++++ > > > > 1 file changed, 89 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > new file mode 100644 > > > > index 000000000000..f7a35962c23b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > @@ -0,0 +1,89 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mediatek Display Port Controller > > > > + > > > > +maintainers: > > > > + - CK Hu > > > > + - Jitao shi > > > > + > > > > +description: | > > > > + Device tree bindings for the Mediatek (embedded) Display Port controller > > > > + present on some Mediatek SoCs. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mediatek,mt8195-edp_tx > > > > + - mediatek,mt8195-dp_tx > > > > > > Are these blocks different? > > > > Good point, the registers of these blocks are described in its own > > chapter each. Also I do need to distinguish between both in the driver. > > Would you suggest making this distinction differently or keep it as two > > compatibles? > > If the registers are all the same, then it should be the same > compatible. If you still need to distinguish, then you should have a > panel or connector node that will let you do that. Thank you. Good idea to check with the connector node, I have changed it as you suggested. > > Also, s/_/-/ in the compatible string. Done. Thanks, Markus _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB39C433EF for ; Wed, 20 Oct 2021 19:35:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D66C604DB for ; Wed, 20 Oct 2021 19:35:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D66C604DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRFzwpQzBaR2JUOQnQeXInF5q8Hj9ZKrnV3tW7zqnrQ=; b=p/1xa1fL/YBIoG QrZfKzAO8hKNL70cS+ue3sabBKAeMUKsYSYYKzDN0JcxNzTpZluxB0LhkuHIn9viNBqDak55QvGjh 46L0BkbB5La0Ktvx95H08kYB92q0qXs9KPl01PEtEwNScRte4oewUZtCGynCzp3wlC9QLy9KtYkv1 B8mp+90Bk8AZlvBGPkYqOa7MZ8HAkO37LYB0QB7J27yDvLisa1T7n4l5Ed29a3WQJ99M74X5/ubUH A5YNNuhXLGLq+a+Sd6QxQ360RUESlKhqCZck8msXm0mnMPBf0FkJLyko5Hbu4QIVdohVph4Rp2l1W LsxE/JGrhZ+87cL9jg+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLu-005fcI-4R; Wed, 20 Oct 2021 19:34:18 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdHLn-005fa1-5T for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 19:34:14 +0000 Received: by mail-wm1-x32c.google.com with SMTP id g2so20742665wme.4 for ; Wed, 20 Oct 2021 12:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=g9C4Q+FGe3RhcO39LAR/2C5riQT1MS5idA1Uc0WW9dHdFwfMJt+c8S5Pv0riiYuF0v oF4yMSjmw/c9rRlFKJHX4k7cDyVCYhbux98pyMOlpt4NGGGmRk3uXPr2IWDXEG1mDXQ1 Nmj/f1MCO+cIPu0+w/5TYk8pYgncEcnXaSllD4fhgIKkr2JHPVyVCRStqNanIfizGFnS J8Rpis0dSyVJm3XykDBu6PJFasTpxI/TW7uS9OWvvR2J69YLuVLA29Y0AGHU1Ub4j4eM hPZ21LJ90PznprSNpDxa0atqZV/ZYPfMu715MFGAH8X8v1GnnneYd/6BRQMB6iwsPyQN HgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NvPAjwt7fyzI4iyzhah+QCTodceAQRPvH3A75BnZsTo=; b=TMQglWk9AHzNswAijhyRrxBbcG5IqeVKN3Db87H2S3wFRuwtR0cxWj6H7WYSiODfw3 T/TXxyngzVoT7SProxQicHOUeA8qlDfiyMbFOWm+5jbBgqwNbWbR6XvT3pymOM+a86d2 uE7VnoUWqA56jA2/BhDoBz+roN0d8U1lrwKxiNms8/7vKV4VA3bR0+5iaRVPO5q25Neh zDH5rs9xhhbpu0ieG75prjtFi1Y4S+SAvYqCk0IrIRz6psZLPO0i9Iv94mJUqxNqmwFv xJVR6GizeN+t76qMSe7D/8ukPVdt7oDwU3NMetosByIiKgwEEPGoWeSEUK9jP+J+ZAlc O+UA== X-Gm-Message-State: AOAM532stEMN55krprysTgDAwaOPRgrBnGJVI+zwdihA/6KMABQG3J9U zVXxtPFZdRW7+snz8kdlJ5zBjA== X-Google-Smtp-Source: ABdhPJxhXGVW++4V0sz2hvab4LJBAF8DPOIn0OjMGV74GJEYevwnJeXR6UCwTqgf0uxJqVNxHNIGWw== X-Received: by 2002:a05:600c:2905:: with SMTP id i5mr1313497wmd.159.1634758448562; Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Received: from blmsp ([2a02:2454:3e6:c900:5142:5fbb:5821:5dc3]) by smtp.gmail.com with ESMTPSA id t1sm3655328wre.32.2021.10.20.12.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:34:08 -0700 (PDT) Date: Wed, 20 Oct 2021 21:34:07 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Chun-Kuang Hu , Philipp Zabel , Vinod Koul , Sam Ravnborg , dri-devel , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding Message-ID: <20211020193407.meektqms4psltg34@blmsp> References: <20211011094624.3416029-1-msp@baylibre.com> <20211011094624.3416029-3-msp@baylibre.com> <20211018141908.fuevv2m66fw3xg36@blmsp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_123411_235594_812EBCD1 X-CRM114-Status: GOOD ( 29.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Mon, Oct 18, 2021 at 02:38:33PM -0500, Rob Herring wrote: > On Mon, Oct 18, 2021 at 9:19 AM Markus Schneider-Pargmann > wrote: > > > > Hi Rob, > > > > On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > > > This controller is present on several mediatek hardware. Currently > > > > mt8195 and mt8395 have this controller without a functional difference, > > > > so only one compatible field is added. > > > > > > > > The controller can have two forms, as a normal display port and as an > > > > embedded display port. > > > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > > --- > > > > .../display/mediatek/mediatek,dp.yaml | 89 +++++++++++++++++++ > > > > 1 file changed, 89 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > new file mode 100644 > > > > index 000000000000..f7a35962c23b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > > > @@ -0,0 +1,89 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mediatek Display Port Controller > > > > + > > > > +maintainers: > > > > + - CK Hu > > > > + - Jitao shi > > > > + > > > > +description: | > > > > + Device tree bindings for the Mediatek (embedded) Display Port controller > > > > + present on some Mediatek SoCs. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mediatek,mt8195-edp_tx > > > > + - mediatek,mt8195-dp_tx > > > > > > Are these blocks different? > > > > Good point, the registers of these blocks are described in its own > > chapter each. Also I do need to distinguish between both in the driver. > > Would you suggest making this distinction differently or keep it as two > > compatibles? > > If the registers are all the same, then it should be the same > compatible. If you still need to distinguish, then you should have a > panel or connector node that will let you do that. Thank you. Good idea to check with the connector node, I have changed it as you suggested. > > Also, s/_/-/ in the compatible string. Done. Thanks, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel