All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: sesankm <sesank.mallikarjuna@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	sesankm <26676400+sesankm@users.noreply.github.com>
Subject: Re: [PATCH] Staging: iio: adc: ad7280a: fixed coding style
Date: Wed, 20 Oct 2021 21:31:12 +0100	[thread overview]
Message-ID: <20211020213112.6084a04c@jic23-huawei> (raw)
In-Reply-To: <20211020061027.34148-1-26676400+sesankm@users.noreply.github.com>

On Wed, 20 Oct 2021 01:10:27 -0500
sesankm <sesank.mallikarjuna@gmail.com> wrote:

> fixed issue with coding style
> 
> Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>

Ah. Our 'favourite' false positive.  Take a look at what that macro
is doing..

There is a series waiting for review that removes this code anyway...
https://patchwork.kernel.org/project/linux-iio/list/?series=499867

> ---
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index fef0055b8990..473f95118214 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>   * The function argument is stringified and doesn't need a fix
>   */
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> -			     in_voltage-voltage_thresh_low_value,
> +			     in_voltage - voltage_thresh_low_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,
>  			     AD7280A_CELL_UNDERVOLTAGE);
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> -			     in_voltage-voltage_thresh_high_value,
> +			     in_voltage - voltage_thresh_high_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,


      parent reply	other threads:[~2021-10-20 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  6:10 [PATCH] Staging: iio: adc: ad7280a: fixed coding style sesankm
2021-10-20  6:33 ` Greg KH
2021-10-20 20:31 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020213112.6084a04c@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=26676400+sesankm@users.noreply.github.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sesank.mallikarjuna@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.