From: Florian Bezdeka <florian.bezdeka@siemens.com>
To: xenomai@xenomai.org
Subject: [PATCH] testsuite/xeno-test: Restore timesyncd running state on smokey failure
Date: Thu, 21 Oct 2021 13:55:08 +0200 [thread overview]
Message-ID: <20211021115508.36110-1-florian.bezdeka@siemens.com> (raw)
We stop systemd-timesyncd before running the smokey testsuite and start
it again once the smokey tests are complete. As xeno-test has a "set -e"
we will stop the execution on the first error. So if smokey reports an
error systemd-timesyncd is not started again. We don't properly restore
the system state in this case.
Install a bash trap to make sure that we restart the service in all
cases if it was running on script entry.
Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
testsuite/xeno-test/xeno-test.in | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/testsuite/xeno-test/xeno-test.in b/testsuite/xeno-test/xeno-test.in
index 95bf59606..cfa28df18 100644
--- a/testsuite/xeno-test/xeno-test.in
+++ b/testsuite/xeno-test/xeno-test.in
@@ -39,9 +39,19 @@ timer irq latency.
EOF
}
+start_timesyncd()
+{
+ if $timesyncd_was_running; then
+ systemctl start systemd-timesyncd
+ timesyncd_was_running=false
+ fi
+}
+trap start_timesyncd EXIT
+
keep_going=
run_on_vm=
rt_load=false
+timesyncd_was_running=false
while :; do
case "$1" in
@@ -82,17 +92,14 @@ echo 0 > /proc/xenomai/latency || :
testdir=@testdir@
-timesyncd_running=false
if which systemctl > /dev/null && systemctl is-active --quiet systemd-timesyncd; then
- timesyncd_running=true
+ timesyncd_was_running=true
systemctl stop systemd-timesyncd
fi
$testdir/smokey --run $run_on_vm $keep_going random_alloc_rounds=64 pattern_check_rounds=64
-if $timesyncd_running; then
- systemctl start systemd-timesyncd
-fi
+start_timesyncd
$testdir/clocktest -D -T 30 -C CLOCK_HOST_REALTIME || $testdir/clocktest -T 30
$testdir/switchtest -T 30
--
2.31.1
next reply other threads:[~2021-10-21 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:55 Florian Bezdeka [this message]
2021-10-21 12:15 ` [PATCH] testsuite/xeno-test: Restore timesyncd running state on smokey failure Jan Kiszka
2021-10-21 12:18 ` Bezdeka, Florian
2021-10-21 16:38 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021115508.36110-1-florian.bezdeka@siemens.com \
--to=florian.bezdeka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.