From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE2BC433F5 for ; Thu, 21 Oct 2021 12:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1AC6610A2 for ; Thu, 21 Oct 2021 12:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231560AbhJUMTJ (ORCPT ); Thu, 21 Oct 2021 08:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231598AbhJUMTC (ORCPT ); Thu, 21 Oct 2021 08:19:02 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78BA9C061760 for ; Thu, 21 Oct 2021 05:16:46 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdWzz-0000Xm-Ks; Thu, 21 Oct 2021 14:16:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mdWzz-0008My-3o; Thu, 21 Oct 2021 14:16:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mdWzz-0001jZ-2x; Thu, 21 Oct 2021 14:16:43 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Riku Voipio , Pavel Machek Cc: linux-leds@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2] leds: pca9532: Make pca9532_destroy_devices() return void Date: Thu, 21 Oct 2021 14:16:39 +0200 Message-Id: <20211021121639.79179-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211021121147.77774-1-u.kleine-koenig@pengutronix.de> References: <20211021121147.77774-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Patch-Hashes: v=1; h=sha256; i=wteD60WHq2yuUQat+xq4gnGGLoUEF/GMIKNrrYOrulk=; m=fDoW2rGKeu4Cy2vtRiYQMdewsLY6HlTaygCrBnmumGo=; p=GjT/fuIsaEQQ8QKX6ta1+Qlq9ZdAONqcDdciAvcSjKM=; g=05173cdc0522f55da1841aa84fc2d38a754605e1 X-Patch-Sig: m=pgp; i=u.kleine-koenig@pengutronix.de; s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6; b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFxWhwACgkQwfwUeK3K7AkmPQgAg3M LtTTxdQK1Byu0+JoaNnVENaVFe6ibPW5oBOCszme6P08+x0hnHFz7td74ltWWzivX8kKQ2qi/VfQ4 nMHSvwUHaDa0LLTFhm7wZnG0x0gpeKAjTnFkyKSWMRcd2WodVA2I1SKKJ4Yh8u7GMptg+OpZ0DoKm HOAQxuL2sN77n1kPE8kDWqSLx5/blpHBECxCN9SE/o7SWUfuSk81piO3khAQ5Cx0Rs2c/9jIC4vFn gIUdEB/uB3zS0rJb0LbC1gJPX7OjBLPnwkWv7MKaurgFoQ4G+Qm1f/UjJcrJ3uAG9LSr7yMCcg5uU CNW74rqIY3+x6zPYsM5AVGppoSISTLg== Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Up to now pca9532_destroy_devices() returns always zero. Remove the never-taken error path and make it return void which makes it easier to see in the callers that there is no error to handle. Also the return value of i2c remove callbacks is ignored anyway. Signed-off-by: Uwe Kleine-König --- drivers/leds/leds-pca9532.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 017794bb87ae..674590576b0a 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -318,7 +318,7 @@ static int pca9532_gpio_direction_output(struct gpio_chip *gc, unsigned offset, } #endif /* CONFIG_LEDS_PCA9532_GPIO */ -static int pca9532_destroy_devices(struct pca9532_data *data, int n_devs) +static void pca9532_destroy_devices(struct pca9532_data *data, int n_devs) { int i = n_devs; @@ -555,7 +555,9 @@ static int pca9532_remove(struct i2c_client *client) { struct pca9532_data *data = i2c_get_clientdata(client); - return pca9532_destroy_devices(data, data->chip_info->num_leds); + pca9532_destroy_devices(data, data->chip_info->num_leds); + + return 0; } module_i2c_driver(pca9532_driver); -- 2.30.2