From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F6BC433FE for ; Thu, 21 Oct 2021 15:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B7C56108E for ; Thu, 21 Oct 2021 15:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231872AbhJUQAf (ORCPT ); Thu, 21 Oct 2021 12:00:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:59818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbhJUQAb (ORCPT ); Thu, 21 Oct 2021 12:00:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7965B611F2; Thu, 21 Oct 2021 15:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634831895; bh=L8SsVdAZqmcgc/l54J3ELRGN7EmFDhRqTkhV3QJ2iKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g68FH0cq70aXjdoLx1elPMm198APq1afbrCj255hNtE16R57d8oXEDmN7iTTXrpTW b9j+sr38KKZXJI8hErEfOfBkZPSwM8wXM+XVw9Ans7H1LmqDGws8Bt061fGGwjpKr5 yY9n9zmu1e5y2pboT41A4tSMKzkRUNymNPE6ftIrcIpAvU3vm2pmgwtlEFfgjJxoQO DBWNCZFk3Wo6qxHitCTMYnAUlXtiQ9ceUqtvEAQPjO9jx/20veksxxDjZ8NrxEsq5h NtwIwY2i9gGtMiQQrZFGkXwUnTo51SirTAeX5kW80tDOcCXgxQWlpwVHGfdXNMfXkS MytNmg154KS0A== Received: by pali.im (Postfix) id 20E5C85E; Thu, 21 Oct 2021 17:58:13 +0200 (CEST) Date: Thu, 21 Oct 2021 17:58:12 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Naveen Naidu Cc: bhelgaas@google.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:PCI DRIVER FOR AARDVARK (Marvell Armada 3700)" Subject: Re: [PATCH v3 11/25] PCI: aardvark: Remove redundant error fabrication when device read fails Message-ID: <20211021155812.qwihgqo6dk73433w@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 October 2021 20:37:36 Naveen Naidu wrote: > An MMIO read from a PCI device that doesn't exist or doesn't respond > causes a PCI error. There's no real data to return to satisfy the > CPU read, so most hardware fabricates ~0 data. > > The host controller drivers sets the error response values (~0) and > returns an error when faulty hardware read occurs. But the error > response value (~0) is already being set in PCI_OP_READ and > PCI_USER_READ_CONFIG whenever a read by host controller driver fails. > > Thus, it's no longer necessary for the host controller drivers to > fabricate any error response. > > This helps unify PCI error response checking and make error check > consistent and easier to find. > > Signed-off-by: Naveen Naidu Reviewed-by: Pali Rohár > --- > drivers/pci/controller/pci-aardvark.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index 596ebcfcc82d..1af772c76d06 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -893,10 +893,8 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > u32 reg; > int ret; > > - if (!advk_pcie_valid_device(pcie, bus, devfn)) { > - *val = 0xffffffff; > + if (!advk_pcie_valid_device(pcie, bus, devfn)) > return PCIBIOS_DEVICE_NOT_FOUND; > - } > > if (pci_is_root_bus(bus)) > return pci_bridge_emul_conf_read(&pcie->bridge, where, > @@ -920,7 +918,6 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > *val = CFG_RD_CRS_VAL; > return PCIBIOS_SUCCESSFUL; > } > - *val = 0xffffffff; > return PCIBIOS_SET_FAILED; > } > > @@ -955,16 +952,13 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > *val = CFG_RD_CRS_VAL; > return PCIBIOS_SUCCESSFUL; > } > - *val = 0xffffffff; > return PCIBIOS_SET_FAILED; > } > > /* Check PIO status and get the read result */ > ret = advk_pcie_check_pio_status(pcie, allow_crs, val); > - if (ret < 0) { > - *val = 0xffffffff; > + if (ret < 0) > return PCIBIOS_SET_FAILED; > - } > > if (size == 1) > *val = (*val >> (8 * (where & 3))) & 0xff; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDADC433F5 for ; Thu, 21 Oct 2021 15:58:19 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C4326108E for ; Thu, 21 Oct 2021 15:58:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C4326108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1808A4087A; Thu, 21 Oct 2021 15:58:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ckuSijZy1QGi; Thu, 21 Oct 2021 15:58:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2CCA640874; Thu, 21 Oct 2021 15:58:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 12E3EC001C; Thu, 21 Oct 2021 15:58:18 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C19B0C0011 for ; Thu, 21 Oct 2021 15:58:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9D03040875 for ; Thu, 21 Oct 2021 15:58:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XOXRLpRccjKk for ; Thu, 21 Oct 2021 15:58:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp4.osuosl.org (Postfix) with ESMTPS id 10F0D40874 for ; Thu, 21 Oct 2021 15:58:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7965B611F2; Thu, 21 Oct 2021 15:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634831895; bh=L8SsVdAZqmcgc/l54J3ELRGN7EmFDhRqTkhV3QJ2iKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g68FH0cq70aXjdoLx1elPMm198APq1afbrCj255hNtE16R57d8oXEDmN7iTTXrpTW b9j+sr38KKZXJI8hErEfOfBkZPSwM8wXM+XVw9Ans7H1LmqDGws8Bt061fGGwjpKr5 yY9n9zmu1e5y2pboT41A4tSMKzkRUNymNPE6ftIrcIpAvU3vm2pmgwtlEFfgjJxoQO DBWNCZFk3Wo6qxHitCTMYnAUlXtiQ9ceUqtvEAQPjO9jx/20veksxxDjZ8NrxEsq5h NtwIwY2i9gGtMiQQrZFGkXwUnTo51SirTAeX5kW80tDOcCXgxQWlpwVHGfdXNMfXkS MytNmg154KS0A== Received: by pali.im (Postfix) id 20E5C85E; Thu, 21 Oct 2021 17:58:13 +0200 (CEST) Date: Thu, 21 Oct 2021 17:58:12 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Naveen Naidu Subject: Re: [PATCH v3 11/25] PCI: aardvark: Remove redundant error fabrication when device read fails Message-ID: <20211021155812.qwihgqo6dk73433w@pali> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Cc: Rob Herring , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , bhelgaas@google.com, linux-kernel-mentees@lists.linuxfoundation.org, "moderated list:PCI DRIVER FOR AARDVARK \(Marvell Armada 3700\)" X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" T24gVGh1cnNkYXkgMjEgT2N0b2JlciAyMDIxIDIwOjM3OjM2IE5hdmVlbiBOYWlkdSB3cm90ZToK PiBBbiBNTUlPIHJlYWQgZnJvbSBhIFBDSSBkZXZpY2UgdGhhdCBkb2Vzbid0IGV4aXN0IG9yIGRv ZXNuJ3QgcmVzcG9uZAo+IGNhdXNlcyBhIFBDSSBlcnJvci4gVGhlcmUncyBubyByZWFsIGRhdGEg dG8gcmV0dXJuIHRvIHNhdGlzZnkgdGhlCj4gQ1BVIHJlYWQsIHNvIG1vc3QgaGFyZHdhcmUgZmFi cmljYXRlcyB+MCBkYXRhLgo+IAo+IFRoZSBob3N0IGNvbnRyb2xsZXIgZHJpdmVycyBzZXRzIHRo ZSBlcnJvciByZXNwb25zZSB2YWx1ZXMgKH4wKSBhbmQKPiByZXR1cm5zIGFuIGVycm9yIHdoZW4g ZmF1bHR5IGhhcmR3YXJlIHJlYWQgb2NjdXJzLiBCdXQgdGhlIGVycm9yCj4gcmVzcG9uc2UgdmFs dWUgKH4wKSBpcyBhbHJlYWR5IGJlaW5nIHNldCBpbiBQQ0lfT1BfUkVBRCBhbmQKPiBQQ0lfVVNF Ul9SRUFEX0NPTkZJRyB3aGVuZXZlciBhIHJlYWQgYnkgaG9zdCBjb250cm9sbGVyIGRyaXZlciBm YWlscy4KPiAKPiBUaHVzLCBpdCdzIG5vIGxvbmdlciBuZWNlc3NhcnkgZm9yIHRoZSBob3N0IGNv bnRyb2xsZXIgZHJpdmVycyB0bwo+IGZhYnJpY2F0ZSBhbnkgZXJyb3IgcmVzcG9uc2UuCj4gCj4g VGhpcyBoZWxwcyB1bmlmeSBQQ0kgZXJyb3IgcmVzcG9uc2UgY2hlY2tpbmcgYW5kIG1ha2UgZXJy b3IgY2hlY2sKPiBjb25zaXN0ZW50IGFuZCBlYXNpZXIgdG8gZmluZC4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBOYXZlZW4gTmFpZHUgPG5hdmVlbm5haWR1NDc5QGdtYWlsLmNvbT4KClJldmlld2VkLWJ5 OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgoKPiAtLS0KPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9wY2ktYWFyZHZhcmsuYyB8IDEwICsrLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv cGNpLWFhcmR2YXJrLmMKPiBpbmRleCA1OTZlYmNmY2M4MmQuLjFhZjc3MmM3NmQwNiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4gKysrIGIvZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+IEBAIC04OTMsMTAgKzg5Myw4IEBA IHN0YXRpYyBpbnQgYWR2a19wY2llX3JkX2NvbmYoc3RydWN0IHBjaV9idXMgKmJ1cywgdTMyIGRl dmZuLAo+ICAJdTMyIHJlZzsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKCFhZHZrX3BjaWVfdmFs aWRfZGV2aWNlKHBjaWUsIGJ1cywgZGV2Zm4pKSB7Cj4gLQkJKnZhbCA9IDB4ZmZmZmZmZmY7Cj4g KwlpZiAoIWFkdmtfcGNpZV92YWxpZF9kZXZpY2UocGNpZSwgYnVzLCBkZXZmbikpCj4gIAkJcmV0 dXJuIFBDSUJJT1NfREVWSUNFX05PVF9GT1VORDsKPiAtCX0KPiAgCj4gIAlpZiAocGNpX2lzX3Jv b3RfYnVzKGJ1cykpCj4gIAkJcmV0dXJuIHBjaV9icmlkZ2VfZW11bF9jb25mX3JlYWQoJnBjaWUt PmJyaWRnZSwgd2hlcmUsCj4gQEAgLTkyMCw3ICs5MTgsNiBAQCBzdGF0aWMgaW50IGFkdmtfcGNp ZV9yZF9jb25mKHN0cnVjdCBwY2lfYnVzICpidXMsIHUzMiBkZXZmbiwKPiAgCQkJKnZhbCA9IENG R19SRF9DUlNfVkFMOwo+ICAJCQlyZXR1cm4gUENJQklPU19TVUNDRVNTRlVMOwo+ICAJCX0KPiAt CQkqdmFsID0gMHhmZmZmZmZmZjsKPiAgCQlyZXR1cm4gUENJQklPU19TRVRfRkFJTEVEOwo+ICAJ fQo+ICAKPiBAQCAtOTU1LDE2ICs5NTIsMTMgQEAgc3RhdGljIGludCBhZHZrX3BjaWVfcmRfY29u ZihzdHJ1Y3QgcGNpX2J1cyAqYnVzLCB1MzIgZGV2Zm4sCj4gIAkJCSp2YWwgPSBDRkdfUkRfQ1JT X1ZBTDsKPiAgCQkJcmV0dXJuIFBDSUJJT1NfU1VDQ0VTU0ZVTDsKPiAgCQl9Cj4gLQkJKnZhbCA9 IDB4ZmZmZmZmZmY7Cj4gIAkJcmV0dXJuIFBDSUJJT1NfU0VUX0ZBSUxFRDsKPiAgCX0KPiAgCj4g IAkvKiBDaGVjayBQSU8gc3RhdHVzIGFuZCBnZXQgdGhlIHJlYWQgcmVzdWx0ICovCj4gIAlyZXQg PSBhZHZrX3BjaWVfY2hlY2tfcGlvX3N0YXR1cyhwY2llLCBhbGxvd19jcnMsIHZhbCk7Cj4gLQlp ZiAocmV0IDwgMCkgewo+IC0JCSp2YWwgPSAweGZmZmZmZmZmOwo+ICsJaWYgKHJldCA8IDApCj4g IAkJcmV0dXJuIFBDSUJJT1NfU0VUX0ZBSUxFRDsKPiAtCX0KPiAgCj4gIAlpZiAoc2l6ZSA9PSAx KQo+ICAJCSp2YWwgPSAoKnZhbCA+PiAoOCAqICh3aGVyZSAmIDMpKSkgJiAweGZmOwo+IC0tIAo+ IDIuMjUuMQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eC1rZXJuZWwtbWVudGVlcyBtYWlsaW5nIGxpc3QKTGludXgta2VybmVsLW1lbnRlZXNA bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1rZXJuZWwtbWVudGVlcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F121C433EF for ; Thu, 21 Oct 2021 15:59:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7CFC611CB for ; Thu, 21 Oct 2021 15:59:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D7CFC611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hPHKtZ/ldCXcn9catqLYeXnUOHx1+6Mlh4Bl2DSTSZk=; b=DlQHfWiMno1ZsQ HkRsetykjlNmIKd+S72y6XJ8VF7qPWqaTRCv8Ff6zYoRdFGKhozG+UcRni9xbt6E5kVpZTN45zjBi XbyeP1Uhl5W7rMmbV6lAtCdIyaghprW76/laXFCGcaVEH8nFaSodL+EOf1OUCyRdTjMuuKLrMBIQT DLyz+KDdkZfUJqK4KMppvFYCHE6cLZ0+3wi8JOq2ZFiIKDR7iLwTgFfdEbMVGQV3AHHERiFkY93xV ybhuBCp5t+p5i23UyTNjQkXsHy3yGaa763N8K2ttP0yhctdxh7YR2aZ2yyo0idlur2J8V6GVO5V5W pTSXxoGV9Y/4vo7y6EsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdaSS-008GAG-7c; Thu, 21 Oct 2021 15:58:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdaSO-008G8S-Ef for linux-arm-kernel@lists.infradead.org; Thu, 21 Oct 2021 15:58:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7965B611F2; Thu, 21 Oct 2021 15:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634831895; bh=L8SsVdAZqmcgc/l54J3ELRGN7EmFDhRqTkhV3QJ2iKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g68FH0cq70aXjdoLx1elPMm198APq1afbrCj255hNtE16R57d8oXEDmN7iTTXrpTW b9j+sr38KKZXJI8hErEfOfBkZPSwM8wXM+XVw9Ans7H1LmqDGws8Bt061fGGwjpKr5 yY9n9zmu1e5y2pboT41A4tSMKzkRUNymNPE6ftIrcIpAvU3vm2pmgwtlEFfgjJxoQO DBWNCZFk3Wo6qxHitCTMYnAUlXtiQ9ceUqtvEAQPjO9jx/20veksxxDjZ8NrxEsq5h NtwIwY2i9gGtMiQQrZFGkXwUnTo51SirTAeX5kW80tDOcCXgxQWlpwVHGfdXNMfXkS MytNmg154KS0A== Received: by pali.im (Postfix) id 20E5C85E; Thu, 21 Oct 2021 17:58:13 +0200 (CEST) Date: Thu, 21 Oct 2021 17:58:12 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Naveen Naidu Cc: bhelgaas@google.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:PCI DRIVER FOR AARDVARK (Marvell Armada 3700)" Subject: Re: [PATCH v3 11/25] PCI: aardvark: Remove redundant error fabrication when device read fails Message-ID: <20211021155812.qwihgqo6dk73433w@pali> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_085816_576579_6C357FE4 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1cnNkYXkgMjEgT2N0b2JlciAyMDIxIDIwOjM3OjM2IE5hdmVlbiBOYWlkdSB3cm90ZToK PiBBbiBNTUlPIHJlYWQgZnJvbSBhIFBDSSBkZXZpY2UgdGhhdCBkb2Vzbid0IGV4aXN0IG9yIGRv ZXNuJ3QgcmVzcG9uZAo+IGNhdXNlcyBhIFBDSSBlcnJvci4gVGhlcmUncyBubyByZWFsIGRhdGEg dG8gcmV0dXJuIHRvIHNhdGlzZnkgdGhlCj4gQ1BVIHJlYWQsIHNvIG1vc3QgaGFyZHdhcmUgZmFi cmljYXRlcyB+MCBkYXRhLgo+IAo+IFRoZSBob3N0IGNvbnRyb2xsZXIgZHJpdmVycyBzZXRzIHRo ZSBlcnJvciByZXNwb25zZSB2YWx1ZXMgKH4wKSBhbmQKPiByZXR1cm5zIGFuIGVycm9yIHdoZW4g ZmF1bHR5IGhhcmR3YXJlIHJlYWQgb2NjdXJzLiBCdXQgdGhlIGVycm9yCj4gcmVzcG9uc2UgdmFs dWUgKH4wKSBpcyBhbHJlYWR5IGJlaW5nIHNldCBpbiBQQ0lfT1BfUkVBRCBhbmQKPiBQQ0lfVVNF Ul9SRUFEX0NPTkZJRyB3aGVuZXZlciBhIHJlYWQgYnkgaG9zdCBjb250cm9sbGVyIGRyaXZlciBm YWlscy4KPiAKPiBUaHVzLCBpdCdzIG5vIGxvbmdlciBuZWNlc3NhcnkgZm9yIHRoZSBob3N0IGNv bnRyb2xsZXIgZHJpdmVycyB0bwo+IGZhYnJpY2F0ZSBhbnkgZXJyb3IgcmVzcG9uc2UuCj4gCj4g VGhpcyBoZWxwcyB1bmlmeSBQQ0kgZXJyb3IgcmVzcG9uc2UgY2hlY2tpbmcgYW5kIG1ha2UgZXJy b3IgY2hlY2sKPiBjb25zaXN0ZW50IGFuZCBlYXNpZXIgdG8gZmluZC4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBOYXZlZW4gTmFpZHUgPG5hdmVlbm5haWR1NDc5QGdtYWlsLmNvbT4KClJldmlld2VkLWJ5 OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgoKPiAtLS0KPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9wY2ktYWFyZHZhcmsuYyB8IDEwICsrLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv cGNpLWFhcmR2YXJrLmMKPiBpbmRleCA1OTZlYmNmY2M4MmQuLjFhZjc3MmM3NmQwNiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4gKysrIGIvZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+IEBAIC04OTMsMTAgKzg5Myw4IEBA IHN0YXRpYyBpbnQgYWR2a19wY2llX3JkX2NvbmYoc3RydWN0IHBjaV9idXMgKmJ1cywgdTMyIGRl dmZuLAo+ICAJdTMyIHJlZzsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKCFhZHZrX3BjaWVfdmFs aWRfZGV2aWNlKHBjaWUsIGJ1cywgZGV2Zm4pKSB7Cj4gLQkJKnZhbCA9IDB4ZmZmZmZmZmY7Cj4g KwlpZiAoIWFkdmtfcGNpZV92YWxpZF9kZXZpY2UocGNpZSwgYnVzLCBkZXZmbikpCj4gIAkJcmV0 dXJuIFBDSUJJT1NfREVWSUNFX05PVF9GT1VORDsKPiAtCX0KPiAgCj4gIAlpZiAocGNpX2lzX3Jv b3RfYnVzKGJ1cykpCj4gIAkJcmV0dXJuIHBjaV9icmlkZ2VfZW11bF9jb25mX3JlYWQoJnBjaWUt PmJyaWRnZSwgd2hlcmUsCj4gQEAgLTkyMCw3ICs5MTgsNiBAQCBzdGF0aWMgaW50IGFkdmtfcGNp ZV9yZF9jb25mKHN0cnVjdCBwY2lfYnVzICpidXMsIHUzMiBkZXZmbiwKPiAgCQkJKnZhbCA9IENG R19SRF9DUlNfVkFMOwo+ICAJCQlyZXR1cm4gUENJQklPU19TVUNDRVNTRlVMOwo+ICAJCX0KPiAt CQkqdmFsID0gMHhmZmZmZmZmZjsKPiAgCQlyZXR1cm4gUENJQklPU19TRVRfRkFJTEVEOwo+ICAJ fQo+ICAKPiBAQCAtOTU1LDE2ICs5NTIsMTMgQEAgc3RhdGljIGludCBhZHZrX3BjaWVfcmRfY29u ZihzdHJ1Y3QgcGNpX2J1cyAqYnVzLCB1MzIgZGV2Zm4sCj4gIAkJCSp2YWwgPSBDRkdfUkRfQ1JT X1ZBTDsKPiAgCQkJcmV0dXJuIFBDSUJJT1NfU1VDQ0VTU0ZVTDsKPiAgCQl9Cj4gLQkJKnZhbCA9 IDB4ZmZmZmZmZmY7Cj4gIAkJcmV0dXJuIFBDSUJJT1NfU0VUX0ZBSUxFRDsKPiAgCX0KPiAgCj4g IAkvKiBDaGVjayBQSU8gc3RhdHVzIGFuZCBnZXQgdGhlIHJlYWQgcmVzdWx0ICovCj4gIAlyZXQg PSBhZHZrX3BjaWVfY2hlY2tfcGlvX3N0YXR1cyhwY2llLCBhbGxvd19jcnMsIHZhbCk7Cj4gLQlp ZiAocmV0IDwgMCkgewo+IC0JCSp2YWwgPSAweGZmZmZmZmZmOwo+ICsJaWYgKHJldCA8IDApCj4g IAkJcmV0dXJuIFBDSUJJT1NfU0VUX0ZBSUxFRDsKPiAtCX0KPiAgCj4gIAlpZiAoc2l6ZSA9PSAx KQo+ICAJCSp2YWwgPSAoKnZhbCA+PiAoOCAqICh3aGVyZSAmIDMpKSkgJiAweGZmOwo+IC0tIAo+ IDIuMjUuMQo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=