From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD104C433EF for ; Thu, 21 Oct 2021 17:05:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82AA861037 for ; Thu, 21 Oct 2021 17:05:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232221AbhJURHk (ORCPT ); Thu, 21 Oct 2021 13:07:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:37136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232209AbhJURHZ (ORCPT ); Thu, 21 Oct 2021 13:07:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 32DF2613B3; Thu, 21 Oct 2021 17:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634835909; bh=Mtct3V9y7jFFGgbR+ibjjD7+N+gDCqWxEZbjvas13mE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LGWfVvzcHqc8yQRJdodC7oDOcxJa32yTi9zRNrtDJvhOqGMa33dLI9a+bTB6H7xVF 3NIyDQY/V5AjyMn0KbJ6Y3vzJ4/3zT0mNXb7IUaA6ac7bA/biJYzZ8WisOIonkmIW2 pcIkW73ffcBFKh571ioLdytq1cKNVR50zmV2lqNVxI3bnDA57aHYZE4UxJxVHH+M0U Qgrp2YS3GjymAg2qWmq0xbWuyG4XvQVqlD36Xcx/4r6WIc45uQ9u+woEonta5J+uKD 40EcCk+7QaQXGDAg9yysbvDvVBEavfT+E5Zd0kdII6HLOAnfv2mC0CES5d+3dL0NAl X7mnuyXpi0mSw== Date: Thu, 21 Oct 2021 12:05:07 -0500 From: Bjorn Helgaas To: Naveen Naidu Cc: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v4 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Message-ID: <20211021170507.GA2701463@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021163611.rsfmberxw6dqn5gx@theprophet> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021 at 10:06:11PM +0530, Naveen Naidu wrote: > On 20/10, Bjorn Helgaas wrote: > > On Tue, Oct 05, 2021 at 10:48:11PM +0530, Naveen Naidu wrote: > > > dpc_process_error() clears both AER fatal and non fatal status > > > registers. Instead of clearing each status registers via a different > > > function call use pci_aer_clear_status(). > > > > > > This helps clean up the code a bit. > > > > > > Signed-off-by: Naveen Naidu > > > --- > > > drivers/pci/pcie/dpc.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > > > index df3f3a10f8bc..faf4a1e77fab 100644 > > > --- a/drivers/pci/pcie/dpc.c > > > +++ b/drivers/pci/pcie/dpc.c > > > @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev) > > > dpc_get_aer_uncorrect_severity(pdev, &info) && > > > aer_get_device_error_info(pdev, &info)) { > > > aer_print_error(pdev, &info); > > > - pci_aer_clear_nonfatal_status(pdev); > > > - pci_aer_clear_fatal_status(pdev); > > > + pci_aer_clear_status(pdev); > > > > The commit log suggests that this is a simple cleanup that doesn't > > change any behavior, but that's not quite true: > > > > - The new code would clear PCI_ERR_ROOT_STATUS, but the old code > > does not. > > > > - The old code masks the status bits with the severity bits before > > clearing, but the new code does not. > > > > The commit log needs to show why these changes are what we want. > > > > Reading through the code again, I realize how wrong(stupid) I was when > making this patch. I was thinking that: > > pci_aer_clear_status() = pci_aer_clear_fatal_status() + pci_aer_clear_nonfatal_status() > > Now I understand, that it is not at all the case. I apologize for the > mistake. I'll make sure to be meticulous while reading functions and not > just assume their behaviour just from their function names. No problem, one could argue that the collection of pci_aer_clear_*() functions that do slightly different things is itself a defect. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A084C433F5 for ; Thu, 21 Oct 2021 17:05:18 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BB5B61037 for ; Thu, 21 Oct 2021 17:05:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9BB5B61037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6FE6D40771; Thu, 21 Oct 2021 17:05:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CqM1ugW_AAwo; Thu, 21 Oct 2021 17:05:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8B4D440703; Thu, 21 Oct 2021 17:05:12 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 64AFFC0033; Thu, 21 Oct 2021 17:05:12 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C736C0011 for ; Thu, 21 Oct 2021 17:05:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id ED78440735 for ; Thu, 21 Oct 2021 17:05:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TDtBNXhzQsca for ; Thu, 21 Oct 2021 17:05:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id CD09140733 for ; Thu, 21 Oct 2021 17:05:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 32DF2613B3; Thu, 21 Oct 2021 17:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634835909; bh=Mtct3V9y7jFFGgbR+ibjjD7+N+gDCqWxEZbjvas13mE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LGWfVvzcHqc8yQRJdodC7oDOcxJa32yTi9zRNrtDJvhOqGMa33dLI9a+bTB6H7xVF 3NIyDQY/V5AjyMn0KbJ6Y3vzJ4/3zT0mNXb7IUaA6ac7bA/biJYzZ8WisOIonkmIW2 pcIkW73ffcBFKh571ioLdytq1cKNVR50zmV2lqNVxI3bnDA57aHYZE4UxJxVHH+M0U Qgrp2YS3GjymAg2qWmq0xbWuyG4XvQVqlD36Xcx/4r6WIc45uQ9u+woEonta5J+uKD 40EcCk+7QaQXGDAg9yysbvDvVBEavfT+E5Zd0kdII6HLOAnfv2mC0CES5d+3dL0NAl X7mnuyXpi0mSw== Date: Thu, 21 Oct 2021 12:05:07 -0500 From: Bjorn Helgaas To: Naveen Naidu Subject: Re: [PATCH v4 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Message-ID: <20211021170507.GA2701463@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021163611.rsfmberxw6dqn5gx@theprophet> Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, oohall@gmail.com, ruscur@russell.cc, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Oct 21, 2021 at 10:06:11PM +0530, Naveen Naidu wrote: > On 20/10, Bjorn Helgaas wrote: > > On Tue, Oct 05, 2021 at 10:48:11PM +0530, Naveen Naidu wrote: > > > dpc_process_error() clears both AER fatal and non fatal status > > > registers. Instead of clearing each status registers via a different > > > function call use pci_aer_clear_status(). > > > > > > This helps clean up the code a bit. > > > > > > Signed-off-by: Naveen Naidu > > > --- > > > drivers/pci/pcie/dpc.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > > > index df3f3a10f8bc..faf4a1e77fab 100644 > > > --- a/drivers/pci/pcie/dpc.c > > > +++ b/drivers/pci/pcie/dpc.c > > > @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev) > > > dpc_get_aer_uncorrect_severity(pdev, &info) && > > > aer_get_device_error_info(pdev, &info)) { > > > aer_print_error(pdev, &info); > > > - pci_aer_clear_nonfatal_status(pdev); > > > - pci_aer_clear_fatal_status(pdev); > > > + pci_aer_clear_status(pdev); > > > > The commit log suggests that this is a simple cleanup that doesn't > > change any behavior, but that's not quite true: > > > > - The new code would clear PCI_ERR_ROOT_STATUS, but the old code > > does not. > > > > - The old code masks the status bits with the severity bits before > > clearing, but the new code does not. > > > > The commit log needs to show why these changes are what we want. > > > > Reading through the code again, I realize how wrong(stupid) I was when > making this patch. I was thinking that: > > pci_aer_clear_status() = pci_aer_clear_fatal_status() + pci_aer_clear_nonfatal_status() > > Now I understand, that it is not at all the case. I apologize for the > mistake. I'll make sure to be meticulous while reading functions and not > just assume their behaviour just from their function names. No problem, one could argue that the collection of pci_aer_clear_*() functions that do slightly different things is itself a defect. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC679C4332F for ; Thu, 21 Oct 2021 17:05:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 004BA613B3 for ; Thu, 21 Oct 2021 17:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 004BA613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HZv4p4Pm2z3brd for ; Fri, 22 Oct 2021 04:05:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=LGWfVvzc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=LGWfVvzc; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HZv47363Cz2xr7 for ; Fri, 22 Oct 2021 04:05:11 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 32DF2613B3; Thu, 21 Oct 2021 17:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634835909; bh=Mtct3V9y7jFFGgbR+ibjjD7+N+gDCqWxEZbjvas13mE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LGWfVvzcHqc8yQRJdodC7oDOcxJa32yTi9zRNrtDJvhOqGMa33dLI9a+bTB6H7xVF 3NIyDQY/V5AjyMn0KbJ6Y3vzJ4/3zT0mNXb7IUaA6ac7bA/biJYzZ8WisOIonkmIW2 pcIkW73ffcBFKh571ioLdytq1cKNVR50zmV2lqNVxI3bnDA57aHYZE4UxJxVHH+M0U Qgrp2YS3GjymAg2qWmq0xbWuyG4XvQVqlD36Xcx/4r6WIc45uQ9u+woEonta5J+uKD 40EcCk+7QaQXGDAg9yysbvDvVBEavfT+E5Zd0kdII6HLOAnfv2mC0CES5d+3dL0NAl X7mnuyXpi0mSw== Date: Thu, 21 Oct 2021 12:05:07 -0500 From: Bjorn Helgaas To: Naveen Naidu Subject: Re: [PATCH v4 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Message-ID: <20211021170507.GA2701463@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021163611.rsfmberxw6dqn5gx@theprophet> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, oohall@gmail.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Oct 21, 2021 at 10:06:11PM +0530, Naveen Naidu wrote: > On 20/10, Bjorn Helgaas wrote: > > On Tue, Oct 05, 2021 at 10:48:11PM +0530, Naveen Naidu wrote: > > > dpc_process_error() clears both AER fatal and non fatal status > > > registers. Instead of clearing each status registers via a different > > > function call use pci_aer_clear_status(). > > > > > > This helps clean up the code a bit. > > > > > > Signed-off-by: Naveen Naidu > > > --- > > > drivers/pci/pcie/dpc.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c > > > index df3f3a10f8bc..faf4a1e77fab 100644 > > > --- a/drivers/pci/pcie/dpc.c > > > +++ b/drivers/pci/pcie/dpc.c > > > @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev) > > > dpc_get_aer_uncorrect_severity(pdev, &info) && > > > aer_get_device_error_info(pdev, &info)) { > > > aer_print_error(pdev, &info); > > > - pci_aer_clear_nonfatal_status(pdev); > > > - pci_aer_clear_fatal_status(pdev); > > > + pci_aer_clear_status(pdev); > > > > The commit log suggests that this is a simple cleanup that doesn't > > change any behavior, but that's not quite true: > > > > - The new code would clear PCI_ERR_ROOT_STATUS, but the old code > > does not. > > > > - The old code masks the status bits with the severity bits before > > clearing, but the new code does not. > > > > The commit log needs to show why these changes are what we want. > > > > Reading through the code again, I realize how wrong(stupid) I was when > making this patch. I was thinking that: > > pci_aer_clear_status() = pci_aer_clear_fatal_status() + pci_aer_clear_nonfatal_status() > > Now I understand, that it is not at all the case. I apologize for the > mistake. I'll make sure to be meticulous while reading functions and not > just assume their behaviour just from their function names. No problem, one could argue that the collection of pci_aer_clear_*() functions that do slightly different things is itself a defect.