From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE9CC433F5 for ; Thu, 21 Oct 2021 20:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76D3860241 for ; Thu, 21 Oct 2021 20:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbhJUUZT (ORCPT ); Thu, 21 Oct 2021 16:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231937AbhJUUZQ (ORCPT ); Thu, 21 Oct 2021 16:25:16 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65B7CC0613B9 for ; Thu, 21 Oct 2021 13:23:00 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id r4so1227698edi.5 for ; Thu, 21 Oct 2021 13:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jFmmxNUoXzyItR02/hWt9c3XRKJ19vzPlXV6udSTpt4=; b=bNrSEqccrWyxW5O/fFfOXrDgyI4vpRGtmC0FKdThUYwjxm3Z4fod8ssiNXKfTYyPPL Y/NqQGGas1xaGfw9teN0q8sWzGoJC3DOVoVMXHb1ECrSL4siHnDYtni9/QVlAB4L9U7s L2QhdBzmQXyR4pruNmy4D1iDGNmbVyuKWwqaQoXUjOXpkvqP/Wa2NNghau+hXUye2wcG fjU5Hv25eSscdTOr7SGpfHIj7oNgsnn2+309mXKJVjqf8ATXq+iDNC3U/fW2e80rsnvb ap4O84kPXluo9m91fSJt25qk0BxOzjz3hYa40ERrGDXRUTT7zw7Af6OVGPIrlP1IO2sP I20A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jFmmxNUoXzyItR02/hWt9c3XRKJ19vzPlXV6udSTpt4=; b=5rKT7OA1Ut5gKJq04InA+NdA58Oc5LJ8/nHJt0kino2WQwOfAHcXM7DlRSg+LZrGqr zNQ5+38jQY4VLo3kxKE3f7sW2b40smbuL/0aIsGtikkRpTfwTX963OaWDseCQuJkL4PR Re/UwSI2L40jXz9MmYPiK38DfVfNjoFXtM85yXlz8mTN1inGo8VTSybtELSlcc9PjqN0 ljQkh6m008oOFo0ZGaUA8GL6VZP/LU01TTlXRwwLX4qr+RI0PnVf2js2OZuJoj2xn3tw 0BLV1rgbIsgsyylBZeLQJqYj01e27Ufx0fZNftMzapLgImVJrvF19Xhe/I5+nFyJTMkJ O8bA== X-Gm-Message-State: AOAM532dr9WzDiRVyF6HVPO8kXXth3W/bColtURfkpz6ECQIjpLsuF/X 0Sn843MOSUdH26DcP4bVSoUWxg== X-Google-Smtp-Source: ABdhPJze9WNulDK5lWspCtacI+kKYFt3IVm56pbEalSY+y9H8jClVr56yt2N2xjKVv5/7S5H53VNaA== X-Received: by 2002:a17:906:3913:: with SMTP id f19mr9457463eje.357.1634847778971; Thu, 21 Oct 2021 13:22:58 -0700 (PDT) Received: from localhost ([31.134.121.151]) by smtp.gmail.com with ESMTPSA id d4sm3384750edk.78.2021.10.21.13.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 13:22:58 -0700 (PDT) From: Sam Protsenko To: Alessandro Zummo , Alexandre Belloni , Krzysztof Kozlowski Cc: linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] rtc: s3c: Remove usage of devm_rtc_device_register() Date: Thu, 21 Oct 2021 23:22:54 +0300 Message-Id: <20211021202256.28517-2-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211021202256.28517-1-semen.protsenko@linaro.org> References: <20211021202256.28517-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_rtc_device_register() is deprecated. Use devm_rtc_allocate_device() and devm_rtc_register_device() API instead. This change doesn't change the behavior, but allows for further improvements. Signed-off-by: Sam Protsenko Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Added R-b tag by Krzysztof Kozlowski drivers/rtc/rtc-s3c.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index e57d3ca70a78..10e591794276 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -447,15 +447,18 @@ static int s3c_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 1); - /* register RTC and exit */ - info->rtc = devm_rtc_device_register(&pdev->dev, "s3c", &s3c_rtcops, - THIS_MODULE); + info->rtc = devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(info->rtc)) { - dev_err(&pdev->dev, "cannot attach rtc\n"); ret = PTR_ERR(info->rtc); goto err_nortc; } + info->rtc->ops = &s3c_rtcops; + + ret = devm_rtc_register_device(info->rtc); + if (ret) + goto err_nortc; + ret = devm_request_irq(&pdev->dev, info->irq_alarm, s3c_rtc_alarmirq, 0, "s3c2410-rtc alarm", info); if (ret) { -- 2.30.2