From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/3] bus: mhi: Add inbound buffers allocation flag
Date: Fri, 22 Oct 2021 13:18:44 +0800 [thread overview]
Message-ID: <202110221333.OG9l1ld6-lkp@intel.com> (raw)
In-Reply-To: <20211016065734.28802-3-manivannan.sadhasivam@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 4679 bytes --]
Hi Manivannan,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on linux/master linus/master v5.15-rc6]
[cannot apply to char-misc/char-misc-testing next-20211021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/MHI-patches-for-v5-16/20211016-145939
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 502408a61f4b7eb4713f44bd77f4a48e6cb1b59a
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f0be8fa21fa4e6ddc6998710bf912a6483a3c09d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Manivannan-Sadhasivam/MHI-patches-for-v5-16/20211016-145939
git checkout f0be8fa21fa4e6ddc6998710bf912a6483a3c09d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/wwan/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/wwan/mhi_wwan_mbim.c: In function 'mhi_mbim_probe':
>> drivers/net/wwan/mhi_wwan_mbim.c:612:15: error: too few arguments to function 'mhi_prepare_for_transfer'
612 | err = mhi_prepare_for_transfer(mhi_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wwan/mhi_wwan_mbim.c:18:
include/linux/mhi.h:728:5: note: declared here
728 | int mhi_prepare_for_transfer(struct mhi_device *mhi_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/mhi_prepare_for_transfer +612 drivers/net/wwan/mhi_wwan_mbim.c
aa730a9905b7b0 Loic Poulain 2021-08-03 593
aa730a9905b7b0 Loic Poulain 2021-08-03 594 static int mhi_mbim_probe(struct mhi_device *mhi_dev, const struct mhi_device_id *id)
aa730a9905b7b0 Loic Poulain 2021-08-03 595 {
aa730a9905b7b0 Loic Poulain 2021-08-03 596 struct mhi_controller *cntrl = mhi_dev->mhi_cntrl;
aa730a9905b7b0 Loic Poulain 2021-08-03 597 struct mhi_mbim_context *mbim;
aa730a9905b7b0 Loic Poulain 2021-08-03 598 int err;
aa730a9905b7b0 Loic Poulain 2021-08-03 599
aa730a9905b7b0 Loic Poulain 2021-08-03 600 mbim = devm_kzalloc(&mhi_dev->dev, sizeof(*mbim), GFP_KERNEL);
aa730a9905b7b0 Loic Poulain 2021-08-03 601 if (!mbim)
aa730a9905b7b0 Loic Poulain 2021-08-03 602 return -ENOMEM;
aa730a9905b7b0 Loic Poulain 2021-08-03 603
94c0a6fbd5cfc3 Wei Yongjun 2021-08-08 604 spin_lock_init(&mbim->tx_lock);
aa730a9905b7b0 Loic Poulain 2021-08-03 605 dev_set_drvdata(&mhi_dev->dev, mbim);
aa730a9905b7b0 Loic Poulain 2021-08-03 606 mbim->mdev = mhi_dev;
aa730a9905b7b0 Loic Poulain 2021-08-03 607 mbim->mru = mhi_dev->mhi_cntrl->mru ? mhi_dev->mhi_cntrl->mru : MHI_DEFAULT_MRU;
aa730a9905b7b0 Loic Poulain 2021-08-03 608
aa730a9905b7b0 Loic Poulain 2021-08-03 609 INIT_DELAYED_WORK(&mbim->rx_refill, mhi_net_rx_refill_work);
aa730a9905b7b0 Loic Poulain 2021-08-03 610
aa730a9905b7b0 Loic Poulain 2021-08-03 611 /* Start MHI channels */
97c78d0af55fff Jakub Kicinski 2021-08-26 @612 err = mhi_prepare_for_transfer(mhi_dev);
aa730a9905b7b0 Loic Poulain 2021-08-03 613 if (err)
aa730a9905b7b0 Loic Poulain 2021-08-03 614 return err;
aa730a9905b7b0 Loic Poulain 2021-08-03 615
aa730a9905b7b0 Loic Poulain 2021-08-03 616 /* Number of transfer descriptors determines size of the queue */
aa730a9905b7b0 Loic Poulain 2021-08-03 617 mbim->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
aa730a9905b7b0 Loic Poulain 2021-08-03 618
aa730a9905b7b0 Loic Poulain 2021-08-03 619 /* Register wwan link ops with MHI controller representing WWAN instance */
aa730a9905b7b0 Loic Poulain 2021-08-03 620 return wwan_register_ops(&cntrl->mhi_dev->dev, &mhi_mbim_wwan_ops, mbim, 0);
aa730a9905b7b0 Loic Poulain 2021-08-03 621 }
aa730a9905b7b0 Loic Poulain 2021-08-03 622
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61345 bytes --]
next prev parent reply other threads:[~2021-10-22 5:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 6:57 [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 1/3] MAINTAINERS: Update the entry for MHI bus Manivannan Sadhasivam
2021-10-16 7:34 ` Greg KH
2021-10-19 4:19 ` Hemant Kumar
2021-10-19 12:24 ` Greg KH
2021-10-19 13:26 ` Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 2/3] bus: mhi: Add inbound buffers allocation flag Manivannan Sadhasivam
2021-10-16 7:39 ` Greg KH
2021-10-16 16:31 ` Manivannan Sadhasivam
2021-10-17 7:07 ` Greg KH
2021-10-22 5:18 ` kernel test robot [this message]
2021-10-16 6:57 ` [PATCH 3/3] bus: mhi: replace snprintf in show functions with sysfs_emit Manivannan Sadhasivam
2021-10-16 7:37 ` Greg KH
2021-10-16 10:24 ` Joe Perches
2021-10-16 15:07 ` Greg KH
2021-10-16 15:13 ` Joe Perches
2021-10-16 16:15 ` Manivannan Sadhasivam
2021-10-19 4:30 ` Hemant Kumar
2021-10-16 16:19 ` Manivannan Sadhasivam
2021-10-16 7:00 ` [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110221333.OG9l1ld6-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.