All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: "Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Wolfgang Denk" <wd@denx.de>,
	u-boot-board-maintainers@lists.denx.de,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	u-boot-custodians@lists.denx.de,
	"Marek Behún" <marek.behun@nic.cz>,
	"Alexander Dahl" <ada@thorsis.com>
Subject: Re: [PATCH v10 8/9] sandbox: Update the test MAC/IP addresses
Date: Sun, 24 Oct 2021 17:39:39 -0400	[thread overview]
Message-ID: <20211024213939.GR3577824@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2A_Q86W6jQ3AuUEDeoiezskzc2JMyFRuERE71sQXyCsA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

On Sun, Oct 24, 2021 at 01:54:17PM -0600, Simon Glass wrote:
> Hi Heinrich,
> 
> On Sat, 23 Oct 2021 at 02:30, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> >
> >
> > On 10/22/21 05:08, Simon Glass wrote:
> > > These conflict with real-word addresses. Use locally administered
> > > MAC addresses and a suitable IPv4 address from 192.0.2.0/24
> > > (TEST-NET-1).
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > Suggested-by: Alexander Dahl <ada@thorsis.com>
> > > ---
> > >
> > > Changes in v10:
> > > - Add new patch to update the test MAC/IP addresses
> > >
> > >   board/sandbox/sandbox.env | 14 +++++++-------
> > >   1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/board/sandbox/sandbox.env b/board/sandbox/sandbox.env
> > > index 0f8d95b8db0..b4c04635a48 100644
> > > --- a/board/sandbox/sandbox.env
> > > +++ b/board/sandbox/sandbox.env
> > > @@ -5,13 +5,13 @@ stdin+=,cros-ec-keyb,usbkbd
> > >   stdout=serial,vidconsole
> > >   stderr=serial,vidconsole
> > >
> > > -ethaddr=00:00:11:22:33:44
> > > -eth2addr=00:00:11:22:33:48
> > > -eth3addr=00:00:11:22:33:45
> > > -eth4addr=00:00:11:22:33:48
> > > -eth5addr=00:00:11:22:33:46
> > > -eth6addr=00:00:11:22:33:47
> > > -ipaddr=1.2.3.4
> > > +ethaddr=02:00:11:22:33:44
> > > +eth2addr=02:00:11:22:33:48
> > > +eth3addr=02:00:11:22:33:45
> > > +eth4addr=02:00:11:22:33:48
> >
> > Ethernet addresses should be unique.
> >
> > Should it be on purpose that two Ethernet address are the same, please
> > add a comment in the code.
> 
> Can you please explain what you are getting out here? Which ones are not unique?

I think you made a mistake ages ago by not doing eth..eth6 in sequence
and updating the last digit each time.  Before and after eth2addr and
eth4addr both end in 48.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-10-24 21:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22  3:08 [PATCH v10 0/9] env: Allow environment in text files Simon Glass
2021-10-22  3:08 ` [PATCH v10 1/9] sandbox: Drop distro_boot Simon Glass
2021-11-17  1:57   ` Tom Rini
2021-10-22  3:08 ` [PATCH v10 2/9] doc: Move environment documentation to rST Simon Glass
2021-10-22  3:08 ` [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-22  8:29   ` Wolfgang Denk
2021-10-22 14:29     ` Tom Rini
2021-10-22 23:29       ` Tony Dinh
2021-10-24 15:41       ` Wolfgang Denk
2021-11-12 18:12   ` Daniel Golle
2021-11-13 14:19     ` Simon Glass
2022-02-10 11:20   ` Patrick DELAUNAY
2022-03-12 18:14     ` Simon Glass
2021-10-22  3:08 ` [PATCH v10 4/9] sandbox: Use a text-based environment Simon Glass
2021-10-22  3:08 ` [PATCH v10 5/9] doc: Mention CONFIG_DEFAULT_ENV_FILE Simon Glass
2021-10-22  3:08 ` [PATCH v10 6/9] doc: Improve environment documentation Simon Glass
2021-10-22  3:08 ` [PATCH v10 7/9] doc: Improve environment documentation further Simon Glass
2021-10-23  8:23   ` Heinrich Schuchardt
2022-03-12  2:24     ` Simon Glass
2021-10-22  3:08 ` [PATCH v10 8/9] sandbox: Update the test MAC/IP addresses Simon Glass
2021-10-23  8:29   ` Heinrich Schuchardt
2021-10-24 19:54     ` Simon Glass
2021-10-24 21:39       ` Tom Rini [this message]
2021-10-22  3:08 ` [PATCH v10 9/9] bootm: Tidy up use of autostart env var Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211024213939.GR3577824@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=ada@thorsis.com \
    --cc=marek.behun@nic.cz \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=u-boot-board-maintainers@lists.denx.de \
    --cc=u-boot-custodians@lists.denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.