From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Eli Cohen <elic@nvidia.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH linux-next v4 5/8] vdpa_sim_net: Enable user to set mac address and mtu
Date: Mon, 25 Oct 2021 04:16:22 -0400 [thread overview]
Message-ID: <20211025041220-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481624C8C6F35197B5AF6A1DC839@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, Oct 25, 2021 at 08:10:15AM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Monday, October 25, 2021 1:39 PM
> >
> > On Mon, Oct 25, 2021 at 07:11:23AM +0000, Parav Pandit wrote:
> > >
> > >
> > > > From: Jason Wang <jasowang@redhat.com>
> > > > Sent: Monday, October 25, 2021 12:32 PM
> > > >
> > > >
> > > > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > > > Enable user to set the mac address and mtu so that each vdpa
> > > > > device can have its own user specified mac address and mtu.
> > > > > This is done by implementing the management device's configuration
> > > > > layout fields setting callback routine.
> > > > >
> > > > > Now that user is enabled to set the mac address, remove the module
> > > > > parameter for same.
> > > > >
> > > > > And example of setting mac addr and mtu:
> > > > > $ vdpa mgmtdev show
> > > > >
> > > > > $ vdpa dev add name bar mgmtdev vdpasim_net $ vdpa dev config set
> > > > > bar mac 00:11:22:33:44:55 mtu 9000
> > > >
> > > >
> > > > The attributes were set during dev add if I was not wrong.
> > > >
> > > You are right. I missed to update the example here. Code is just fine.
> > >
> > > > Thanks
> > > >
> >
> > Want to send a corrected commit log?
> Yes. would like to send v5 with the corrected commit log and ACK from Jason on other patches.
Go ahead, I will pick it up if merge window does not open yet.
There was also one comment by Jason you didn't resolve patch 1 I think?.
And it can't hurt to add a comment near the capability check
explaining why don't check if no attributes.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-25 8:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 16:35 [PATCH linux-next v4 0/8] vdpa: enable user to set mac, mtu Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 1/8] vdpa: Introduce and use vdpa device get, set config helpers Parav Pandit via Virtualization
2021-10-25 6:03 ` Jason Wang
2021-10-25 11:24 ` Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 2/8] vdpa: Introduce query of device config layout Parav Pandit via Virtualization
2021-10-25 6:05 ` Jason Wang
2021-10-25 6:59 ` Parav Pandit via Virtualization
2021-10-25 8:10 ` Michael S. Tsirkin
2021-10-26 2:45 ` Jason Wang
2021-10-25 11:43 ` Parav Pandit via Virtualization
2021-10-21 16:35 ` [PATCH linux-next v4 3/8] vdpa: Use kernel coding style for structure comments Parav Pandit via Virtualization
2021-10-25 6:06 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device Parav Pandit via Virtualization
2021-10-25 7:01 ` Jason Wang
2021-10-25 7:06 ` Parav Pandit via Virtualization
2021-10-25 8:08 ` Michael S. Tsirkin
2021-10-25 8:26 ` Parav Pandit via Virtualization
2021-10-26 2:40 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 5/8] vdpa_sim_net: Enable user to set mac address and mtu Parav Pandit via Virtualization
2021-10-25 7:02 ` Jason Wang
2021-10-25 7:11 ` Parav Pandit via Virtualization
2021-10-25 8:09 ` Michael S. Tsirkin
2021-10-25 8:10 ` Parav Pandit via Virtualization
2021-10-25 8:16 ` Michael S. Tsirkin [this message]
2021-10-21 16:35 ` [PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit Parav Pandit via Virtualization
2021-10-25 7:05 ` Jason Wang
2021-10-25 7:08 ` Parav Pandit via Virtualization
2021-10-26 2:42 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 7/8] vdpa/mlx5: Support configuration of MAC Parav Pandit via Virtualization
2021-10-25 7:07 ` Jason Wang
2021-10-21 16:35 ` [PATCH linux-next v4 8/8] vdpa/mlx5: Forward only packets with allowed MAC address Parav Pandit via Virtualization
2021-10-22 10:41 ` [PATCH linux-next v4 0/8] vdpa: enable user to set mac, mtu Michael S. Tsirkin
2021-10-22 15:07 ` Parav Pandit via Virtualization
2021-10-23 20:03 ` Michael S. Tsirkin
2021-10-23 21:15 ` Michael S. Tsirkin
2021-10-25 3:43 ` Parav Pandit via Virtualization
2021-10-25 7:27 ` Parav Pandit via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025041220-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.