From: Karel Zak <kzak@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
Lennart Poettering <lennart@poettering.net>,
Martijn Coenen <maco@android.com>,
linux-block@vger.kernel.org, Luca Boccassi <bluca@debian.org>
Subject: Re: Is LO_FLAGS_DIRECT_IO by default a good idea?
Date: Mon, 25 Oct 2021 12:37:50 +0200 [thread overview]
Message-ID: <20211025103750.dhfmof4izoh5ybrq@ws.net.home> (raw)
In-Reply-To: <32ccb509-37b7-c9f0-14f3-d68c24c55dad@kernel.dk>
On Tue, Oct 19, 2021 at 06:24:34AM -0600, Jens Axboe wrote:
> On 10/19/21 1:44 AM, Ming Lei wrote:
> > On Mon, Oct 18, 2021 at 05:05:50PM +0200, Christoph Hellwig wrote:
> >> On Mon, Oct 18, 2021 at 04:19:20PM +0200, Lennart Poettering wrote:
> >>> A brief answer like "yes, please, enable by default" would already
> >>> make me happy.
> >>
> >> I thikn enabling it by default is a good idea. The only good use
> >> case I can think of for using buffered I/O is when the image has
> >> a smaller block size than supported on the host file.
> >
> > Maybe we can enable it at default in kernel side, then fackback to
> > buffered IO if DIO is failed.
>
> Yes I think that's sane, pure DIO probably isn't a great idea by
> default. But if we have a sane fallback, then I do think it'd be the
> best way to run it.
So, I can wait for kernel rather than enable it by default in
losetup/mount, right? :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2021-10-25 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 14:19 Is LO_FLAGS_DIRECT_IO by default a good idea? Lennart Poettering
2021-10-18 15:05 ` Christoph Hellwig
2021-10-19 7:28 ` Lennart Poettering
2021-10-19 7:44 ` Ming Lei
2021-10-19 12:24 ` Jens Axboe
2021-10-25 10:37 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025103750.dhfmof4izoh5ybrq@ws.net.home \
--to=kzak@redhat.com \
--cc=axboe@kernel.dk \
--cc=bluca@debian.org \
--cc=hch@lst.de \
--cc=lennart@poettering.net \
--cc=linux-block@vger.kernel.org \
--cc=maco@android.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.